Message ID | 20230319151017.531737-24-bugaevc@gmail.com |
---|---|
State | Committed, archived |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DBAE13948829 for <patchwork@sourceware.org>; Sun, 19 Mar 2023 15:16:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DBAE13948829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679238966; bh=16MJsJScpYPA0KQa4Y/NKWPT1vq+jdOV8WSMLONJpZ8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lYZZxc60WLrnm7iIU1z28nhZAtlzsBc5tHZTPns9nQoVeJISADOpbM9MGdGg4V/Ce zJXKrpbC2IC5oPh0Dhg4DtRS75+47FRVz6i13wLKb6JzlYcKrOapWyvnJtW+2+1Uzm E8U1hOcvjPZ3FbSqMP5Xtb1E/gScEzDzO6JK9wug= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 0D26738555B6 for <libc-alpha@sourceware.org>; Sun, 19 Mar 2023 15:11:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D26738555B6 Received: by mail-lf1-x12f.google.com with SMTP id s8so11743484lfr.8 for <libc-alpha@sourceware.org>; Sun, 19 Mar 2023 08:11:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679238678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=16MJsJScpYPA0KQa4Y/NKWPT1vq+jdOV8WSMLONJpZ8=; b=JO+eTe5WtRhBrTzp7AadurP6vYh7fgUJyApWvbkPZfLNMei0yI8Luv/ICr2Tb60PiO +rOkoTAmQvPnXqe+RfCnxoq2gGfEyB8CKJH6r+t00VL986yWE5UW10g5LI2yiWqN5fnj Cy/jq0aqNfkCN1jIuRdAi8QFmDbnCp0qT92I+QxmFjXraa1dwgxRkRS3s2nteImdnL32 EpmCAbHrW2uX6LuovbMI5SQr1y/tSGfXxqeseICnSssIXPWWEgkpDcIdutjaP/qKHW0W Bv+AwATZ0UEFrKPczSjc7hy9NHLyEpesUQ2dMUoipk8egIBvmLDhWJPIbQfRAQuDilPr ZI4A== X-Gm-Message-State: AO0yUKUdQqNyhCrKmIqGk04ytK8Ug0bBwkUAwndscTAHWm97fayHVO/4 RyAojML+3mbrd3oQDXpnwnpn1WyTt/7dFg== X-Google-Smtp-Source: AK7set/sCTlXBFG3hT6fC4rjdX/GH2oxbAJy5vr/vVcnxU37bw23gS4gr1B/yjXi9zCCsp3XC5ZF7g== X-Received: by 2002:ac2:5621:0:b0:4cd:47e:47a9 with SMTP id b1-20020ac25621000000b004cd047e47a9mr5208923lff.58.1679238678188; Sun, 19 Mar 2023 08:11:18 -0700 (PDT) Received: from surface-pro-6.. ([2a00:1370:818c:4a57:577a:76f4:df43:5e66]) by smtp.gmail.com with ESMTPSA id m19-20020ac24253000000b004e90dee5469sm1274089lfl.157.2023.03.19.08.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 08:11:17 -0700 (PDT) To: libc-alpha@sourceware.org, bug-hurd@gnu.org Cc: Samuel Thibault <samuel.thibault@gnu.org>, Sergey Bugaev <bugaevc@gmail.com> Subject: [RFC PATCH glibc 23/34] elf: Stop including tls.h in ldsodefs.h Date: Sun, 19 Mar 2023 18:10:06 +0300 Message-Id: <20230319151017.531737-24-bugaevc@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230319151017.531737-1-bugaevc@gmail.com> References: <20230319151017.531737-1-bugaevc@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Sergey Bugaev via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Sergey Bugaev <bugaevc@gmail.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
The rest of the x86_64-gnu port
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Sergey Bugaev
March 19, 2023, 3:10 p.m. UTC
Nothing in there needs tls.h
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
---
sysdeps/generic/ldsodefs.h | 1 -
1 file changed, 1 deletion(-)
Comments
Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > Nothing in there needs tls.h Ok but includers might be erroneously relying on it. Did you try to build various configurations, to make sure that this isn't breaking any? > > Signed-off-by: Sergey Bugaev <bugaevc@gmail.com> > --- > sysdeps/generic/ldsodefs.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > index c99dad77..5f21bc63 100644 > --- a/sysdeps/generic/ldsodefs.h > +++ b/sysdeps/generic/ldsodefs.h > @@ -38,7 +38,6 @@ > #include <dl-fixup-attribute.h> > #include <libc-lock.h> > #include <hp-timing.h> > -#include <tls.h> > #include <list_t.h> > > __BEGIN_DECLS > -- > 2.39.2 >
On Mon, Apr 3, 2023 at 2:20 AM Samuel Thibault <samuel.thibault@gnu.org> wrote: > Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > > Nothing in there needs tls.h > > Ok but includers might be erroneously relying on it. Did you try to > build various configurations, to make sure that this isn't breaking any? There (unfortunately) still are multiple other ways that <ldsodefs.h> ends up including <tls.h> (in particular through <link.h>), so this change should not immediately break anything. See the cover letter for some more details about this. That being said, it sounds like glibc would benefit from a run of https://include-what-you-use.org/ over the code base. This would both trim the extraneous includes (such as this #include <tls.h>) and add the ones that are required, but (as you're saying, erroneously) not explicitly mentioned. Sergey
Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > Nothing in there needs tls.h > > Signed-off-by: Sergey Bugaev <bugaevc@gmail.com> > --- > sysdeps/generic/ldsodefs.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > index c99dad77..5f21bc63 100644 > --- a/sysdeps/generic/ldsodefs.h > +++ b/sysdeps/generic/ldsodefs.h > @@ -38,7 +38,6 @@ > #include <dl-fixup-attribute.h> > #include <libc-lock.h> > #include <hp-timing.h> > -#include <tls.h> > #include <list_t.h> > > __BEGIN_DECLS > -- > 2.39.2 >
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h index c99dad77..5f21bc63 100644 --- a/sysdeps/generic/ldsodefs.h +++ b/sysdeps/generic/ldsodefs.h @@ -38,7 +38,6 @@ #include <dl-fixup-attribute.h> #include <libc-lock.h> #include <hp-timing.h> -#include <tls.h> #include <list_t.h> __BEGIN_DECLS