From patchwork Tue Feb 28 18:23:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 65808 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4F6AF385840C for ; Tue, 28 Feb 2023 18:23:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F6AF385840C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677608633; bh=OxnXbb6rWbNzLxEkqBnZne09tT8s1miaXSamgcgzcRU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=yJic8f0oA5V/6OuLgPEJcncy6Bc+/Vrfs6a2tUjpRMkrTltpZDASTbZUJNW3hvG/r kI1Grp9s0Zr0rtVqWnGcGvk1Toda9vbJ1SA90uZ7zEOZSjxQ2+d2PfUF5EHCRRMqd3 ruu68MTowoXCLWzQW0z8iKWMfzGxgN5thedqUKG4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id 067103858D33 for ; Tue, 28 Feb 2023 18:23:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 067103858D33 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-172b0ba97b0so11843117fac.4 for ; Tue, 28 Feb 2023 10:23:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677608610; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OxnXbb6rWbNzLxEkqBnZne09tT8s1miaXSamgcgzcRU=; b=7PNX0CSbpz0vnPc/Zl5iQ6HWrDqT3JOh/ZIkh7pqCuprzsv19GlKBGyJv6uicdFCVT 8fXjDOOlEKOIrVDeQVEM+AyIuUISUU3BCEtd0Rkm3NJ/Y3xaCBgsmH/RbLMpmm6V+3ay DGdVayszu3BkqD5zhplfEHpDAq7DP2wff1hjjzU2IgRHvTEq+hF0npQBKbRRr7ff8v3x nXOhVy9GXsioBOOlAllhWsYDCUBB93ss96jCzYWitUEi6CEWPh/S9iBeo9CxfObT3vmZ rmn8casL+6ens3pUeJ+U85HDWldHffEtacHaqhPhKb8DmXy+ddz/YfitkNPU3ltOGa7D YAtw== X-Gm-Message-State: AO0yUKUxS75OL437/8DgLMZdT704mI024a/g6R+FGUBg6hAaDD1FcY+0 XxF18aV3yk+h/b+Dw6ICtVkxJkQJN1TBzdVNAwk= X-Google-Smtp-Source: AK7set80gbQBTvUP9Ku5xqNSPaNXAPdo5ds8brx9M9ZwagtbYh9EkhliNXh1qkPV1P3XZy6OlkK4Kg== X-Received: by 2002:a05:6870:4395:b0:172:899a:f473 with SMTP id r21-20020a056870439500b00172899af473mr2058327oah.42.1677608609744; Tue, 28 Feb 2023 10:23:29 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c3:d849:7299:419:6fb3:7a8]) by smtp.gmail.com with ESMTPSA id yy23-20020a056871259700b0017264f96879sm3482079oab.17.2023.02.28.10.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 10:23:29 -0800 (PST) To: libc-alpha@sourceware.org, Wilco Dijkstra Subject: [PATCH] arm: Remove __builtin_arm_uqsub8 usage on string-fza.h Date: Tue, 28 Feb 2023 15:23:25 -0300 Message-Id: <20230228182325.3127358-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The __builtin_arm_uqsub8 is an internal GCC builtin which might change in future release (the correct way is to include "arm_acle.h" and use __uqsub8 ()). Since not all compilers support it, just use the inline assembler instead. Checked on armv7a-linux-gnueabihf. Reviewed-by: Wilco Dijkstra --- sysdeps/arm/armv6t2/string-fza.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sysdeps/arm/armv6t2/string-fza.h b/sysdeps/arm/armv6t2/string-fza.h index d85ce86434..fb75011991 100644 --- a/sysdeps/arm/armv6t2/string-fza.h +++ b/sysdeps/arm/armv6t2/string-fza.h @@ -33,13 +33,9 @@ find_zero_all (op_t x) /* Use unsigned saturated subtraction from 1 in each byte. That leaves 1 for every byte that was zero. */ op_t ones = repeat_bytes (0x01); -#if __GNUC_PREREQ (10, 0) - return __builtin_arm_uqsub8 (ones, x); -#else op_t ret; asm ("uqsub8 %0,%1,%2" : "=r"(ret) : "r"(ones), "r"(x)); return ret; -#endif } /* Identify bytes that are equal between X1 and X2. */