diff mbox series

[RFC,3/9] hurd: Fix xattr function return type

Message ID	20230218203717.373211-4-bugaevc@gmail.com
State	Committed, archived
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 20B35385841E To: bug-hurd@gnu.org, libc-alpha@sourceware.org Cc: =?utf-8?q?Fl=C3=A1vio_Cruz?= <flaviocruz@gmail.com>, Sergey Bugaev <bugaevc@gmail.com> Subject: [RFC PATCH 3/9] hurd: Fix xattr function return type Date: Sat, 18 Feb 2023 23:37:11 +0300 Message-Id: <20230218203717.373211-4-bugaevc@gmail.com> In-Reply-To: <20230218203717.373211-1-bugaevc@gmail.com> References: <20230218203717.373211-1-bugaevc@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Sergey Bugaev via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Sergey Bugaev <bugaevc@gmail.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org>
Series	More x86_64-gnu glibc work \| [RFC,0/9] More x86_64-gnu glibc work [RFC,1/9] hurd: Move thread state manipulation into _hurd_tls_new () [RFC,2/9] hurd: Use proper integer types [RFC,3/9] hurd: Fix xattr function return type [RFC,4/9] hurd: Make timer_t pointer-sized [RFC,5/9] hurd: Simplify init-first.c a bit [RFC,6/9] mach: Use PAGE_SIZE [RFC,7/9] hurd: Generalize init-first.c to support x86_64 [RFC,8/9,gnumach] Add i386_fsgs_base_state [RFC,9/9] hurd, htl: Add some more x86_64-specific code

Checks

Context	Check	Description
dj/TryBot-apply_patch	success	Patch applied to master at the time it was sent

Commit Message

Sergey Bugaev Feb. 18, 2023, 8:37 p.m. UTC

  They all return int, not size_t.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
---
 sysdeps/mach/hurd/fsetxattr.c    | 2 +-
 sysdeps/mach/hurd/lremovexattr.c | 2 +-
 sysdeps/mach/hurd/lsetxattr.c    | 2 +-
 sysdeps/mach/hurd/removexattr.c  | 2 +-
 sysdeps/mach/hurd/setxattr.c     | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Comments

Samuel Thibault Feb. 19, 2023, 11:34 p.m. UTC | #1

Applied, thanks!

Sergey Bugaev, le sam. 18 févr. 2023 23:37:11 +0300, a ecrit:
> They all return int, not size_t.
> 
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
>  sysdeps/mach/hurd/fsetxattr.c    | 2 +-
>  sysdeps/mach/hurd/lremovexattr.c | 2 +-
>  sysdeps/mach/hurd/lsetxattr.c    | 2 +-
>  sysdeps/mach/hurd/removexattr.c  | 2 +-
>  sysdeps/mach/hurd/setxattr.c     | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sysdeps/mach/hurd/fsetxattr.c b/sysdeps/mach/hurd/fsetxattr.c
> index 71ee7599..dcc48fa0 100644
> --- a/sysdeps/mach/hurd/fsetxattr.c
> +++ b/sysdeps/mach/hurd/fsetxattr.c
> @@ -22,7 +22,7 @@
>  #include <hurd/xattr.h>
>  #include <hurd/fd.h>
>  
> -ssize_t
> +int
>  fsetxattr (int fd, const char *name, const void *value, size_t size, int flags)
>  {
>    error_t err;
> diff --git a/sysdeps/mach/hurd/lremovexattr.c b/sysdeps/mach/hurd/lremovexattr.c
> index 1d761e2d..cb6a1f8f 100644
> --- a/sysdeps/mach/hurd/lremovexattr.c
> +++ b/sysdeps/mach/hurd/lremovexattr.c
> @@ -22,7 +22,7 @@
>  #include <hurd/xattr.h>
>  #include <fcntl.h>
>  
> -ssize_t
> +int
>  lremovexattr (const char *path, const char *name)
>  {
>    error_t err;
> diff --git a/sysdeps/mach/hurd/lsetxattr.c b/sysdeps/mach/hurd/lsetxattr.c
> index 56c138dc..4e1e2de2 100644
> --- a/sysdeps/mach/hurd/lsetxattr.c
> +++ b/sysdeps/mach/hurd/lsetxattr.c
> @@ -22,7 +22,7 @@
>  #include <hurd/xattr.h>
>  #include <fcntl.h>
>  
> -ssize_t
> +int
>  lsetxattr (const char *path, const char *name, const void *value, size_t size,
>  	   int flags)
>  {
> diff --git a/sysdeps/mach/hurd/removexattr.c b/sysdeps/mach/hurd/removexattr.c
> index 128d0e01..fedc5370 100644
> --- a/sysdeps/mach/hurd/removexattr.c
> +++ b/sysdeps/mach/hurd/removexattr.c
> @@ -21,7 +21,7 @@
>  #include <hurd.h>
>  #include <hurd/xattr.h>
>  
> -ssize_t
> +int
>  removexattr (const char *path, const char *name)
>  {
>    error_t err;
> diff --git a/sysdeps/mach/hurd/setxattr.c b/sysdeps/mach/hurd/setxattr.c
> index be3b172b..ba6047cd 100644
> --- a/sysdeps/mach/hurd/setxattr.c
> +++ b/sysdeps/mach/hurd/setxattr.c
> @@ -21,7 +21,7 @@
>  #include <hurd.h>
>  #include <hurd/xattr.h>
>  
> -ssize_t
> +int
>  setxattr (const char *path, const char *name, const void *value, size_t size,
>  	  int flags)
>  {
> -- 
> 2.39.2
> 
>

diff mbox series

Patch

diff --git a/sysdeps/mach/hurd/fsetxattr.c b/sysdeps/mach/hurd/fsetxattr.c
index 71ee7599..dcc48fa0 100644
--- a/sysdeps/mach/hurd/fsetxattr.c
+++ b/sysdeps/mach/hurd/fsetxattr.c
@@ -22,7 +22,7 @@ 
 #include <hurd/xattr.h>
 #include <hurd/fd.h>
 
-ssize_t
+int
 fsetxattr (int fd, const char *name, const void *value, size_t size, int flags)
 {
   error_t err;
diff --git a/sysdeps/mach/hurd/lremovexattr.c b/sysdeps/mach/hurd/lremovexattr.c
index 1d761e2d..cb6a1f8f 100644
--- a/sysdeps/mach/hurd/lremovexattr.c
+++ b/sysdeps/mach/hurd/lremovexattr.c
@@ -22,7 +22,7 @@ 
 #include <hurd/xattr.h>
 #include <fcntl.h>
 
-ssize_t
+int
 lremovexattr (const char *path, const char *name)
 {
   error_t err;
diff --git a/sysdeps/mach/hurd/lsetxattr.c b/sysdeps/mach/hurd/lsetxattr.c
index 56c138dc..4e1e2de2 100644
--- a/sysdeps/mach/hurd/lsetxattr.c
+++ b/sysdeps/mach/hurd/lsetxattr.c
@@ -22,7 +22,7 @@ 
 #include <hurd/xattr.h>
 #include <fcntl.h>
 
-ssize_t
+int
 lsetxattr (const char *path, const char *name, const void *value, size_t size,
 	   int flags)
 {
diff --git a/sysdeps/mach/hurd/removexattr.c b/sysdeps/mach/hurd/removexattr.c
index 128d0e01..fedc5370 100644
--- a/sysdeps/mach/hurd/removexattr.c
+++ b/sysdeps/mach/hurd/removexattr.c
@@ -21,7 +21,7 @@ 
 #include <hurd.h>
 #include <hurd/xattr.h>
 
-ssize_t
+int
 removexattr (const char *path, const char *name)
 {
   error_t err;
diff --git a/sysdeps/mach/hurd/setxattr.c b/sysdeps/mach/hurd/setxattr.c
index be3b172b..ba6047cd 100644
--- a/sysdeps/mach/hurd/setxattr.c
+++ b/sysdeps/mach/hurd/setxattr.c
@@ -21,7 +21,7 @@ 
 #include <hurd.h>
 #include <hurd/xattr.h>
 
-ssize_t
+int
 setxattr (const char *path, const char *name, const void *value, size_t size,
 	  int flags)
 {