diff mbox series

Naming the parameter of dummy_sa_handler

Message ID 20230213150703.2638293-1-bmahi496@linux.ibm.com
State Committed
Commit 000ca24f807762a1fa6bf076d80f152d2512f17d
Headers
Series Naming the parameter of dummy_sa_handler |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

MAHESH BODAPATI Feb. 13, 2023, 3:07 p.m. UTC 
  From: Mahesh Bodapati <mahesh.bodapati@ibm.com>

ISO C does not support omitting parameter names in function definitions
before C2X,the compiler is giving an error with older versions of gcc and
this commit will resolve the test failure "error: parameter name omitted"
---
 posix/tst-spawn7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adhemerval Zanella Netto Feb. 13, 2023, 4:22 p.m. UTC | #1 
On 13/02/23 12:07, MAHESH BODAPATI via Libc-alpha wrote:
> From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
> 
> ISO C does not support omitting parameter names in function definitions
> before C2X,the compiler is giving an error with older versions of gcc and
> this commit will resolve the test failure "error: parameter name omitted"

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  posix/tst-spawn7.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c
> index a1c0d9d942..fedb09fb94 100644
> --- a/posix/tst-spawn7.c
> +++ b/posix/tst-spawn7.c
> @@ -92,7 +92,7 @@ spawn_signal_test (const char *type, const posix_spawnattr_t *attr)
>  }
>  
>  static void
> -dummy_sa_handler (int)
> +dummy_sa_handler (int signal)
>  {
>  }
>
diff mbox series

Patch

diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c
index a1c0d9d942..fedb09fb94 100644
--- a/posix/tst-spawn7.c
+++ b/posix/tst-spawn7.c
@@ -92,7 +92,7 @@  spawn_signal_test (const char *type, const posix_spawnattr_t *attr)
 }
 
 static void
-dummy_sa_handler (int)
+dummy_sa_handler (int signal)
 {
 }