From patchwork Sun Feb 12 11:10:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Bugaev X-Patchwork-Id: 64780 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 579ED38654A3 for ; Sun, 12 Feb 2023 11:12:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 579ED38654A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676200361; bh=H/ZBpbn7xwlXkd2NGAJAqZdzWG/T+RELX+zXAFKUFB8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=a5bw3kOZphg5AuEb2KGSn2cxoTBuJ1DNxwC/J9efGBjGtmy1//fKjN2JPOBDE956J L4R3OCtBsRVp67VfjUsqYrXOdV57edP6bO3VnLiTrzdqPsvEnY/chBG+4F//t8+/Vf YaLq7D5Es7e2oWaagUxRPb3CgrREbwXIO1FmsG1o= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 2A50038582BC for ; Sun, 12 Feb 2023 11:11:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A50038582BC Received: by mail-ed1-x532.google.com with SMTP id u21so9450861edv.3 for ; Sun, 12 Feb 2023 03:11:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H/ZBpbn7xwlXkd2NGAJAqZdzWG/T+RELX+zXAFKUFB8=; b=dggsG+5nIwwr4yMkOONkppherhC1UMShZQUgoV6SvHXeY/xSzJmk+tPBTRHSo5wgob yzGT+pVELDcsENqDwULZUIJYLGLxxg4T59YS1mG+LI4LGKeLq9kme9DgSaZPByJ3uyZ9 8zDkJ5kKSI/NxyHn0fHr/7gV6ZhRAFuPJ9d8dnHamU973IG/CY514siGjbOTo4UTulpi TQFlVu17Grxba6yoYiKKW9/GFX56V7XRz5TANtTUlbt+vhUF1Qzw3svSDbknaUczBDCg tzFMm2t/Fg3RdxsVKdn/kzp6Qr45kUn5bjKpP2+PZd8SCDcOvVcudM46cVBd+dTBP87f T9hg== X-Gm-Message-State: AO0yUKXt1+CEBM1b3UOMOYAp5HzoTP3DRqxGO2PAqmZ6sICWJvY08DyP v48Uykprzph/71ePy/+3uQVKkmnYEcyRFQ== X-Google-Smtp-Source: AK7set/bJBdzeagYZ8Y0hP1OOqTxEpS1RJxovQDR6wTs7XEQ6ndQhNYncX8w5T2W+gVte0BlCPGrKQ== X-Received: by 2002:a50:cc9d:0:b0:4ab:2504:c7ff with SMTP id q29-20020a50cc9d000000b004ab2504c7ffmr11486264edi.23.1676200276908; Sun, 12 Feb 2023 03:11:16 -0800 (PST) Received: from surface-pro-6.. ([2a00:1370:818c:4a57:2186:c463:9ced:e6fe]) by smtp.gmail.com with ESMTPSA id c61-20020a509fc3000000b004acbe0b36d2sm1266910edf.6.2023.02.12.03.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 03:11:16 -0800 (PST) To: bug-hurd@gnu.org, libc-alpha@sourceware.org Cc: =?utf-8?q?Fl=C3=A1vio_Cruz?= , Sergey Bugaev Subject: [RFC PATCH glibc 4/12] hurd: Fix xattr error value Date: Sun, 12 Feb 2023 14:10:35 +0300 Message-Id: <20230212111044.610942-5-bugaevc@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230212111044.610942-1-bugaevc@gmail.com> References: <20230212111044.610942-1-bugaevc@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Sergey Bugaev via Libc-alpha From: Sergey Bugaev Reply-To: Sergey Bugaev Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This does not seem like it is supposed to return negative error codes. Signed-off-by: Sergey Bugaev --- hurd/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hurd/xattr.c b/hurd/xattr.c index 48914bcf..5a0fc263 100644 --- a/hurd/xattr.c +++ b/hurd/xattr.c @@ -68,7 +68,7 @@ _hurd_xattr_get (io_t port, const char *name, void *value, size_t *size) { if (buf != value) __munmap (buf, bufsz); - return -ERANGE; + return ERANGE; } if (buf != value && bufsz > 0) {