[1/3] string: Add libc_hidden_proto for strchrnul
Checks
| Context |
Check |
Description |
| dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
Although static linker can optimize it to local call, it follow the
internal scheme to provide hidden proto and definitions.
---
include/string.h | 1 +
string/strchrnul.c | 1 +
sysdeps/aarch64/strchrnul.S | 1 +
sysdeps/i386/strchrnul.S | 1 +
sysdeps/m68k/strchrnul.S | 1 +
.../power4/multiarch/strchrnul-ppc32.c | 7 +++++++
.../powerpc32/power4/multiarch/strchrnul.c | 17 +++++++++--------
sysdeps/powerpc/powerpc64/multiarch/strchrnul.c | 1 +
sysdeps/s390/strchrnul-c.c | 4 +++-
sysdeps/s390/strchrnul.c | 8 +++++---
sysdeps/x86_64/multiarch/strchrnul.c | 4 ++++
sysdeps/x86_64/strchrnul.S | 1 +
12 files changed, 35 insertions(+), 12 deletions(-)
Comments
On Tue, 7 Feb 2023 at 10:14, Adhemerval Zanella via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Although static linker can optimize it to local call, it follow the
> internal scheme to provide hidden proto and definitions.
> ---
Just a typo in the commit message (s/follow/follows/), otherwise, LGTM.
Reviewed-by: Carlos Eduardo Seo <carlos.seo@linaro.org>
On Wed, 8 Feb 2023 at 14:14, Carlos Seo <carlos.seo@linaro.org> wrote:
>
> On Tue, 7 Feb 2023 at 10:14, Adhemerval Zanella via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > Although static linker can optimize it to local call, it follow the
> > internal scheme to provide hidden proto and definitions.
> > ---
>
> Just a typo in the commit message (s/follow/follows/), otherwise, LGTM.
@@ -95,6 +95,7 @@ libc_hidden_proto (__rawmemchr)
libc_hidden_proto (__strcasecmp)
libc_hidden_proto (__strcasecmp_l)
libc_hidden_proto (__strncasecmp_l)
+libc_hidden_proto (__strchrnul)
extern __typeof (strncat) __strncat;
libc_hidden_proto (__strncat)
libc_hidden_proto (__strdup)
@@ -51,5 +51,6 @@ __strchrnul (const char *str, int c_in)
return (char *) word_ptr + index_first_zero_eq (word, repeated_c);
}
#ifndef STRCHRNUL
+libc_hidden_def (__strchrnul)
weak_alias (__strchrnul, strchrnul)
#endif
@@ -95,4 +95,5 @@ L(end):
ret
END(__strchrnul)
+libc_hidden_def (__strchrnul)
weak_alias (__strchrnul, strchrnul)
@@ -273,4 +273,5 @@ L(6): popl %edi /* restore saved register content */
ret
END (__strchrnul)
+libc_hidden_def (__strchrnul)
weak_alias (__strchrnul, strchrnul)
@@ -263,4 +263,5 @@ L(L9:)
rts
END(__strchrnul)
+libc_hidden_def (__strchrnul)
weak_alias (__strchrnul, strchrnul)
@@ -22,3 +22,10 @@
extern __typeof (strchrnul) __strchrnul_ppc attribute_hidden;
#include <string/strchrnul.c>
+#undef __strchrnul
+weak_alias (__strchrnul_ppc, __strchrnul)
+#ifdef SHARED
+__hidden_ver1 (__strchrnul_ppc, __GI___strchrnul, __strchrnul_ppc);
+#else
+weak_alias (__strchrnul_ppc, strchrnul)
+#endif
@@ -16,22 +16,23 @@
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
-#if IS_IN (libc)
+#if defined SHARED && IS_IN (libc)
+# define __strchrnul __redirect___strchrnul
+# define strchrnul __redirect_strchrnul
# include <string.h>
# include <shlib-compat.h>
# include "init-arch.h"
extern __typeof (__strchrnul) __strchrnul_ppc attribute_hidden;
extern __typeof (__strchrnul) __strchrnul_power7 attribute_hidden;
+# undef __strchrnul
+# undef strchrnul
/* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
ifunc symbol properly. */
-libc_ifunc (__strchrnul,
- (hwcap & PPC_FEATURE_HAS_VSX)
- ? __strchrnul_power7
- : __strchrnul_ppc);
-
+libc_ifunc_redirected (__redirect___strchrnul, __strchrnul,
+ (hwcap & PPC_FEATURE_HAS_VSX)
+ ? __strchrnul_power7
+ : __strchrnul_ppc);
weak_alias (__strchrnul, strchrnul)
-#else
-#include <string/strchrnul.c>
#endif
@@ -35,6 +35,7 @@ libc_ifunc (__strchrnul,
? __strchrnul_power7
: __strchrnul_ppc);
+libc_hidden_def (__strchrnul)
weak_alias (__strchrnul, strchrnul)
#else
#include <string/strchrnul.c>
@@ -21,8 +21,10 @@
#if HAVE_STRCHRNUL_C
# if HAVE_STRCHRNUL_IFUNC
# define STRCHRNUL STRCHRNUL_C
-# define __strchrnul STRCHRNUL
# endif
# include <string/strchrnul.c>
+# if defined SHARED && IS_IN (libc)
+__hidden_ver1 (__strchrnul_c, __GI___strchrnul, __strchrnul_c);
+# endif
#endif
@@ -19,18 +19,20 @@
#include <ifunc-strchrnul.h>
#if HAVE_STRCHRNUL_IFUNC
+# define __strchrnul __redirect_strchrnul
# include <string.h>
+# undef __strchrnul
# include <ifunc-resolve.h>
# if HAVE_STRCHRNUL_C
-extern __typeof (__strchrnul) STRCHRNUL_C attribute_hidden;
+extern __typeof (__redirect_strchrnul) STRCHRNUL_C attribute_hidden;
# endif
# if HAVE_STRCHRNUL_Z13
-extern __typeof (__strchrnul) STRCHRNUL_Z13 attribute_hidden;
+extern __typeof (__redirect_strchrnul) STRCHRNUL_Z13 attribute_hidden;
# endif
-s390_libc_ifunc_expr (__strchrnul, __strchrnul,
+s390_libc_ifunc_expr (__redirect_strchrnul, __strchrnul,
(HAVE_STRCHRNUL_Z13 && (hwcap & HWCAP_S390_VX))
? STRCHRNUL_Z13
: STRCHRNUL_DEFAULT
@@ -31,4 +31,8 @@
libc_ifunc_redirected (__redirect_strchrnul, __strchrnul,
IFUNC_SELECTOR ());
weak_alias (__strchrnul, strchrnul)
+# ifdef SHARED
+__hidden_ver1 (__strchrnul, __GI___strchrnul, __redirect_strchrnul)
+ __attribute__((visibility ("hidden"))) __attribute_copy__ (strchrnul);
+# endif
#endif
@@ -24,4 +24,5 @@
#include "isa-default-impl.h"
+libc_hidden_def (__strchrnul)
weak_alias (__strchrnul, strchrnul)