From patchwork Fri Feb 3 17:12:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 64263 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC24C3858407 for ; Fri, 3 Feb 2023 17:13:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC24C3858407 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675444389; bh=uROL8lIHbdLh0AW8KEzKnHVBlyjiYxT40hqlzO73OrY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=iZqLFuyG6RSDSRkQH8nz3axcp6hv4E6sEkkaxuFvjEorgLQgUhWOI7Y3j+VlKGNYO GUCpPodFvpGxQuTOMnJnjjsuABNsIp4QprjhzhwImmcwUHe6tJDoP0/eRdOUpfEeTp ZRd1o+WxgiJ/7aU84sqvy9OQjviBZuTlk/W03png= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 82F8B3858C52 for ; Fri, 3 Feb 2023 17:12:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82F8B3858C52 Received: by mail-ot1-x32e.google.com with SMTP id r34-20020a05683044a200b0068d4a8a8d2dso1534656otv.12 for ; Fri, 03 Feb 2023 09:12:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uROL8lIHbdLh0AW8KEzKnHVBlyjiYxT40hqlzO73OrY=; b=Ryb8A2d5+ZE0IPUvyilAMdpeQokwkkySV/s/Y4QSeMRjMRhvGBhKsTMB4oJTlaAPD/ BUhUl5pkCk2TpOhlaqVXj9sOhWB/FxgvKaPc1vZckiJ/tM8kk2PTnknaXCRLMndAIHS3 ZlS30oXXeK5XcaWnbizRE70es+Jt4vsBXtd59YfPImXQgUFe+V0OJpwyb5h+PubJFgck LKnP32oP/93nz4MFu2h8BTtsMQKOTttcKfRtb9P0IybTJpWiu0TVhRfA0wpknGom9tvO dwAZD77h7sgCLu16RWJDQ6+/eWFoEWeyWzs4HGKFKR7Qt3qmuq+b6gY16IJLTq7etUTZ QhiA== X-Gm-Message-State: AO0yUKUQGr1jLQc1Psoe1KQ5Z7hHKNkwf38wa+b3eiokwIkF9/B/G/1U VmBNjaQU8i4L0vJpBtU6Vk3sQxYs79jIoHKvdcU= X-Google-Smtp-Source: AK7set+vbcS4128K8sDMON5OVcwjdVZrYOg69GqIo0h3X4mXofAUsAJvP7OdcZB+zbCiqWHuVbIPfQ== X-Received: by 2002:a9d:6b0d:0:b0:68d:53d5:f7d2 with SMTP id g13-20020a9d6b0d000000b0068d53d5f7d2mr2841015otp.31.1675444363014; Fri, 03 Feb 2023 09:12:43 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c2:1887:38a0:ca4:680a:31ed]) by smtp.gmail.com with ESMTPSA id cp23-20020a056830661700b0068bdd78f763sm1346672otb.29.2023.02.03.09.12.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 09:12:42 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH 1/5] powerpc64: Add the clone3 wrapper Date: Fri, 3 Feb 2023 14:12:33 -0300 Message-Id: <20230203171237.1220878-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230203171237.1220878-1-adhemerval.zanella@linaro.org> References: <20230203171237.1220878-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" It follows the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); The powerpc64 ABI requires an initial stackframe so the child can store/restore the TOC. It is create prior calling clone3 by adjusting the stack size (since kernel will compute the stack as stack plus size). Checked on powerpc64-linux-gnu (power8, kernel 6.0) and powerpc64le-linux-gnu (power9, kernel 4.18). Reviewed-by: Paul E. Murphy --- .../sysv/linux/powerpc/powerpc64/clone3.S | 157 ++++++++++++++++++ sysdeps/unix/sysv/linux/powerpc/sysdep.h | 1 + 2 files changed, 158 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S new file mode 100644 index 0000000000..3c50fe392f --- /dev/null +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone3.S @@ -0,0 +1,157 @@ +/* The clone3 syscall wrapper. Linux/powerpc64 version. + Copyright (C) 2023 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#define _ERRNO_H 1 +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + r3: cl_args + r4: size + r5: func + r6: arg */ + +#ifdef USE_PPC_SCV +/* This is equivalent to DO_CALL_SCV, but we cannot use the macro here + because it uses CFI directives and we just called cfi_endproc. */ +# define DO_CLONE3_SVC_CALL(jumpfalse) \ + CHECK_SCV_SUPPORT r28 jumpfalse; \ + mflr r9; \ + std r9, FRAME_LR_SAVE(r1); \ + .machine "push"; \ + .machine "power9"; \ + scv 0; \ + .machine "pop"; \ + ld r9, FRAME_LR_SAVE(r1); \ + mtlr r9; \ + /* With scv an, an error is a value -4095 <= x < 0. */ \ + cmpdi cr1, r3, 0; \ + b 1f; +#else +# define DO_CLONE3_SVC_CALL(fail_branch) +#endif + + .text +ENTRY(__clone3) + CALL_MCOUNT 4 + + /* Sanity checks args. */ + cmpdi cr0, r3, 0 + cmpdi cr1, r5, 0 + cror cr0*4+eq, cr1*4+eq, cr0*4+eq + beq cr0,L(badargs) + + /* Save some regs in the "red zone". */ +#ifdef USE_PPC_SCV + std r28, -24(r1) + cfi_offset (r28, -24) +#endif + std r29, -16(r1) + std r30, -8(r1) + cfi_offset (r29, -16) + cfi_offset (r30, -8) + + /* Save func and arg across syscall. */ + mr r30, r5 /* Function in r30. */ + mr r29, r6 /* Argument in r29. */ + + /* End FDE now, because in the child the unwind info will be + wrong. */ + cfi_endproc + + /* Setup a minimum stack frame for child. It needs to first calculate + the effective stack address, write the start empty backchain pointer, + and update the frame size in the input cl_args. */ + ld r7, 40(r3) /* Load stack value. */ + ld r8, 48(r3) /* Load stack_size value. */ + li r10, 0 + add r7, r7, r8 /* Calculate effective stack address. */ + std r10, -FRAME_MIN_SIZE_PARM(r7) + addi r8, r8, -FRAME_MIN_SIZE_PARM + std r8, 48(r3) + + /* Do the system call, the kernel expects: + r0: system call numer + r3: cl_args + r4: size */ + li r0, SYS_ify(clone3) + DO_CLONE3_SVC_CALL (0f) +0: DO_CALL_SC + + /* With sc, error is indicated by cr0.SO. */ + cmpdi cr1, r3, 0 + crandc cr1*4+eq, cr1*4+eq, cr0*4+so + +1: bne- cr1,L(parent) + + /* Child, load the function and arguments. */ + std r2, FRAME_TOC_SAVE(r1) + PPC64_LOAD_FUNCPTR r30 + mr r3, r29 + bctrl + ld r2, FRAME_TOC_SAVE(r1) + + li r0, SYS_ify(exit) + DO_CLONE3_SVC_CALL (2f) +2: DO_CALL_SC + /* We won't ever get here but provide a nop so that the linker + will insert a toc adjusting stub if necessary. */ + nop + +L(badargs): + cfi_startproc + li r3, EINVAL + TAIL_CALL_SYSCALL_ERROR + +L(parent): + /* Check if scv is available. */ + cmpdi cr1, r28, 0 + + /* Parent. Restore registers & return. */ +#ifdef USE_PPC_SCV + cfi_offset (r28, -24) + ld r28, -24(r1) + cfi_restore (r28) +#endif + cfi_offset (r29,-16) + cfi_offset (r30,-8) + ld r29, -16(r1) + ld r30, -8(r1) + cfi_restore (r29) + cfi_restore (r30) + +#ifdef USE_PPC_SCV + beq cr1, 0f + RET_SCV + b 1f +#endif +0: RET_SC +1: TAIL_CALL_SYSCALL_ERROR + +PSEUDO_END (__clone3) + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/powerpc/sysdep.h b/sysdeps/unix/sysv/linux/powerpc/sysdep.h index 9859cb8171..96a0edc38f 100644 --- a/sysdeps/unix/sysv/linux/powerpc/sysdep.h +++ b/sysdeps/unix/sysv/linux/powerpc/sysdep.h @@ -214,6 +214,7 @@ #if defined(__PPC64__) || defined(__powerpc64__) #define HAVE_CLOCK_GETRES64_VSYSCALL "__kernel_clock_getres" #define HAVE_CLOCK_GETTIME64_VSYSCALL "__kernel_clock_gettime" +#define HAVE_CLONE3_WRAPPER 1 #else #define HAVE_CLOCK_GETRES_VSYSCALL "__kernel_clock_getres" #define HAVE_CLOCK_GETTIME_VSYSCALL "__kernel_clock_gettime"