From patchwork Thu Feb 2 18:11:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 64164 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ACFFA385802F for ; Thu, 2 Feb 2023 18:13:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACFFA385802F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675361602; bh=bSd7SA8Na6FigOWp4XOKr27O+fBOT5QrDyAGCcSMAVw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=n+KL2WGnQR66I9F1QHjbqqHrnw8yKQ+n2Ccd2xfoPNmmIHpUwvuVPL14DfNpsmxBO OZe8pCqcr0zSDToZMtvNn0GytluZg+FGvxDNRQgENkBTUxRdBfj6UNLFIVf6St1kmS PaSEBK6oHFo7/1buRNFx8DHPyL+m2Ert5vTtZwOs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 32FC7385B53B for ; Thu, 2 Feb 2023 18:12:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32FC7385B53B Received: by mail-ot1-x334.google.com with SMTP id 14-20020a9d010e000000b0068bdddfa263so695931otu.2 for ; Thu, 02 Feb 2023 10:12:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bSd7SA8Na6FigOWp4XOKr27O+fBOT5QrDyAGCcSMAVw=; b=NInKU7DGzjer04h7BCTSK5IZsjn/CxQfSA59cjWjB4Mk+y1IQluOUUddf65QphHr8v rOtzLQ0JERd/8wsmNi7M/ycMlTgpKwbWUuucIIZCkW1XVWhfPivd7zMBL1kuorw5yNHJ R/RytFEHbZfCIofNscHnsI+ZjL+d6A6okXqxqckkpoSTeI3HqVA5eaKdCW2Wyni2aqBv edZuRe19WUko8PnMTZa+3m9uT49GH7ATfL0bIk0qN6KS0jnEN4kapv/nYngkUgsfZaZ6 kcBGzLsx9p5fBP1MAo9DaWtMmzTZm6KPtNCXpb7qToHUCTE+L5fIoTxwnPJgZmQ40cRl qE7w== X-Gm-Message-State: AO0yUKV3O5FLyra8/eyDOLyVy0T6s9Jl/Ovk256axaqV4u1sQh//27xt YTJ/XkZPy1RnZXGD/rLzgguXoZ4J16wOGnZ/+J0= X-Google-Smtp-Source: AK7set/FQ4RSyGafLQ36j9IM+43gsAzTuYpkGi/46WEeAhpVDiX3ObyZynMjMHhPGIGZsIUybhT7FA== X-Received: by 2002:a9d:841:0:b0:68b:cec3:7fe5 with SMTP id 59-20020a9d0841000000b0068bcec37fe5mr4544923oty.4.1675361540996; Thu, 02 Feb 2023 10:12:20 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c2:1887:da12:b9d3:2162:a28c]) by smtp.gmail.com with ESMTPSA id ci10-20020a05683063ca00b00684a10970adsm126689otb.16.2023.02.02.10.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 10:12:20 -0800 (PST) To: libc-alpha@sourceware.org, Richard Henderson , Jeff Law , Xi Ruoyao , Noah Goldstein Subject: [PATCH v12 10/31] string: Improve generic strcpy Date: Thu, 2 Feb 2023 15:11:28 -0300 Message-Id: <20230202181149.2181553-11-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230202181149.2181553-1-adhemerval.zanella@linaro.org> References: <20230202181149.2181553-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Now that stpcpy is vectorized based on op_t, it should be better to call it instead of strlen plus memcpy. Checked on x86_64-linux-gnu, i686-linux-gnu, powerpc64-linux-gnu, and powerpc-linux-gnu by removing the arch-specific assembly implementation and disabling multi-arch (it covers both LE and BE for 64 and 32 bits). Reviewed-by: Richard Henderson Reviewed-by: Noah Goldstein --- string/strcpy.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/string/strcpy.c b/string/strcpy.c index 0345c71d15..d945d8fdf0 100644 --- a/string/strcpy.c +++ b/string/strcpy.c @@ -19,6 +19,9 @@ #include #undef strcpy +/* Disable internal stpcpy optimization, otherwise the __stpcpy might it + generate a strcpy call. */ +#undef __stpcpy #ifndef STRCPY # define STRCPY strcpy @@ -28,6 +31,7 @@ char * STRCPY (char *dest, const char *src) { - return memcpy (dest, src, strlen (src) + 1); + __stpcpy (dest, src); + return dest; } libc_hidden_builtin_def (strcpy)