From patchwork Thu Jan 12 13:58:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 63097 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A38AA3854390 for ; Thu, 12 Jan 2023 13:59:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A38AA3854390 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673531963; bh=ZtIhO9j+xvydNqIUsWUpTH9JjRj2L8fr2xNYVR69ATg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=D0+r3RQEcyYqM6jy/G5IzLy9WflxEMmaXPAYPuMi0kdhkp9h0I5sZGdSvS2ClKefj vNVJVTfuS1PTgdqr3tkFLlxp/U5M/pcFnAM3BvegiGbWJdOMUs1kCciSsyewAbncE/ knpRWkFHHDcEJWJfbP6zT0q9hN3F/AJvkXV7FC1E= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by sourceware.org (Postfix) with ESMTPS id 0FF123858C27 for ; Thu, 12 Jan 2023 13:59:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FF123858C27 Received: by mail-oo1-xc34.google.com with SMTP id s10-20020a4aa54a000000b004f240f120b3so1012746oom.1 for ; Thu, 12 Jan 2023 05:59:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZtIhO9j+xvydNqIUsWUpTH9JjRj2L8fr2xNYVR69ATg=; b=sTJGxCyg0SZIDhduGrcLk8wYfJZF0HhrCLws9vUIY6OWKGnXI70fJLfHx2Kiqjhgn7 WmM0vfZNyC+hbLPTbQOaLWRme9Ij6tNGqxjLH4rK8okT3i1atvH5vQu6qISy+itb3y0x E8T805pZdNl6VT9IxAj1cAPsDfHOEz1iuZdl2bD831iBXNOhD4FNvnaYCL5UD8sFbI7m cp21B6NDJuuALh56Nkbobsv4TeYJjS6MT5wT2spiRdrej9fvujDFAhk5tYctYo5FawAA JFbECc5BcDzC+I3x9VkOvbT5ooWRFz4Qh6TRq+D2ckm0h4jE1iWRGwcey1hga5zPpbxL +b3Q== X-Gm-Message-State: AFqh2kpSMUfUoGbuoj9ElSK2F2byj3jr1RVMreWC58TtUMHRLlQ/1qgv +AmQVvwp09mFrmDxoVZlZRNB5ypo1lNn8rXAnVc= X-Google-Smtp-Source: AMrXdXu/TlaQnLvi4mhAMqkvOFnFKQg8VUn4YiosMxVqjv1Npe202DRi4v/Rokpejjk2mo4eEQ5LRA== X-Received: by 2002:a4a:ce8b:0:b0:4f2:85eb:a with SMTP id f11-20020a4ace8b000000b004f285eb000amr439100oos.4.1673531939808; Thu, 12 Jan 2023 05:58:59 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c0:a93a:bf1c:dea8:4fd2:4310]) by smtp.gmail.com with ESMTPSA id m26-20020a4abc9a000000b004a0aac2d28fsm8335402oop.35.2023.01.12.05.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 05:58:59 -0800 (PST) To: libc-alpha@sourceware.org, Carlos O'Donell Subject: [PATCH v4 1/6] linux: Do not reset signal handler in posix_spawn if it is already SIG_DFL Date: Thu, 12 Jan 2023 10:58:48 -0300 Message-Id: <20230112135853.3786675-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230112135853.3786675-1-adhemerval.zanella@linaro.org> References: <20230112135853.3786675-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" There is no need to issue another sigaction if the disposition is already SIG_DFL. Checked on x86_64-linux-gnu. Reviewed-by: Carlos O'Donell --- sysdeps/unix/sysv/linux/spawni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c index b7a6fe320d..a1a14a58ae 100644 --- a/sysdeps/unix/sysv/linux/spawni.c +++ b/sysdeps/unix/sysv/linux/spawni.c @@ -129,7 +129,7 @@ __spawni_child (void *arguments) else { __libc_sigaction (sig, 0, &sa); - if (sa.sa_handler == SIG_IGN) + if (sa.sa_handler == SIG_IGN || sa.sa_handler == SIG_DFL) continue; sa.sa_handler = SIG_DFL; }