From patchwork Wed Dec 14 22:23:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 61955 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7377D384F730 for ; Wed, 14 Dec 2022 22:23:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7377D384F730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671056615; bh=ZxUfxcdL3dlaIJD7K9+OFLKLnaqzsWThRobJzaSrimk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ClITsAXzeRS4lQEKaHHxzG89NxU+j7kxT9FreEykpyMnd+Hu2S9ISfyuqfCOlEQJ3 kbK6Kze/Jsob/nSyLar7AIPxh4HBlwglyL71DL/+N9AJCBwWrIqFdT/x+PEBkqMmJS iECTY7gcY8XgLvBq++WGnhy9wv+jSvkPiamHntrE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id 0CACE385189C for ; Wed, 14 Dec 2022 22:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0CACE385189C Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1322d768ba7so18606423fac.5 for ; Wed, 14 Dec 2022 14:23:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZxUfxcdL3dlaIJD7K9+OFLKLnaqzsWThRobJzaSrimk=; b=6ZDkgZ3qpBGCk7bAmCNhmjUg+Jm8lyaK8y3QnaeczO8vW1vnoT2QyKynOkRHzuO14/ XHSH1IopF2DWevn8kwMthAsZqI07kmjKJkvhg1womcpMGHlS4Op7kthDLcYjD72EkapZ MD17csiBZrtTIQYiV2iWX77IwBDnHAxDW3MAx9knyj5T62OQT/1bydw5IYd1glHdnpA3 edoPFfLWJFiodIuhjoQNWijh3lc0vU52jFTWLEiHR7bFCbEAhQUg/LRhKy0OaHu3xWw8 DKuWqUWcFHGr9VYWgxDgTA2lpJI+bBnLT/xEOM1yNBX3zpQr1xTwR76ZTphw+i5ehqP1 GkFw== X-Gm-Message-State: AFqh2kr8fqHMg04+V1cLL84yfLa5FBDYPSFi0vzMYCUJpwenw6hl2gG6 6rAFXPAAVJjTwD+sf4iuRdiIzMlmZ65x4YJ7k+A= X-Google-Smtp-Source: AMrXdXtrGG77dLNYb/wLJAr1KtG74Hkxp7tw6j73Vv0ITOHZfYYUg1/I5VwjEuFFt3nLX27Bt2u9RA== X-Received: by 2002:a05:6870:6d06:b0:14b:8ffa:a443 with SMTP id mw6-20020a0568706d0600b0014b8ffaa443mr2125874oab.49.1671056591705; Wed, 14 Dec 2022 14:23:11 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c2:f05e:65c9:2e7a:96b4:ab04]) by smtp.gmail.com with ESMTPSA id l12-20020a05687014cc00b001375188dae9sm3372681oab.16.2022.12.14.14.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 14:23:10 -0800 (PST) To: libc-alpha@sourceware.org, Florian Weimer Subject: [PATCH v2] elf: Fix tst-relro-symbols.py argument passing Date: Wed, 14 Dec 2022 19:23:07 -0300 Message-Id: <20221214222307.1045652-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Current scheme only consideres the first argument for both --required and --optional, where the idea is to append a new item. Checked on x86_64-linux-gnu. Reviewed-by: Florian Weimer --- elf/tst-relro-symbols.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/elf/tst-relro-symbols.py b/elf/tst-relro-symbols.py index 368ea3349f..a572a47148 100644 --- a/elf/tst-relro-symbols.py +++ b/elf/tst-relro-symbols.py @@ -56,10 +56,10 @@ def get_parser(): """Return an argument parser for this script.""" parser = argparse.ArgumentParser(description=__doc__) parser.add_argument('object', help='path to object file to check') - parser.add_argument('--required', metavar='NAME', default=(), - help='required symbol names', nargs='*') - parser.add_argument('--optional', metavar='NAME', default=(), - help='required symbol names', nargs='*') + parser.add_argument('--required', metavar='NAME', action='append', default=[], + help='required symbol names') + parser.add_argument('--optional', metavar='NAME', action='append', default=[], + help='required symbol names') return parser def main(argv):