From patchwork Wed Dec 14 21:20:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 61951 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0CD62383F216 for ; Wed, 14 Dec 2022 21:21:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0CD62383F216 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1671052865; bh=FZNsi4jM8UhDy2iFIGmSn6NIsRnyUBuZAewoK5bRpMY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=BhcwwxUtjK++L+Vjcy6atMday0ck3nrYpZtZQ6ujk2QChQ9hD8l6k68KbHO3C1Iy8 H0wtFijiG7QpWcKOrrm7moLes6GmUJ6Z7teayapKiUd3Kse02zzFjYq0D5C2Q67PTV YpcFo4FAjWsUh+AZQ0G7U/3xCJoPn9eatzodjIsM= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 041273871D2A for ; Wed, 14 Dec 2022 21:20:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 041273871D2A Received: by mail-oo1-xc2f.google.com with SMTP id e11-20020a4ab14b000000b0049be568062bso3097309ooo.4 for ; Wed, 14 Dec 2022 13:20:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FZNsi4jM8UhDy2iFIGmSn6NIsRnyUBuZAewoK5bRpMY=; b=VHilm/QLJrkYlNNDxAJhfUfqWfXCFiNnPXV+6wsdjUYxIQBMTbrsfEF1vr36kyNkig n9/XIHV2aZkdHLAVmUrFkqTab2DxgPW7HJAG9j08zUdfr21LXtRrUcMRmKnFMrwm2JOD TVxrVpw67yTfPrOFaHCscLJ8bPDs9HrfHF/1j/0WUBUa1ssweWawp3VGDDgpoySniKJy qY5WDVmuqpiLRya7lF0NCacjaqIT5WcjhjbN9IEmsFj7y9tz0gbiLLDQbnhSyvlottKv X9PqBZ/QUvYEe8T9NERTzZrLWLepiIO6xT2vMRohLmXeecULxz9ltJHarZCpj6EzW5am T7fg== X-Gm-Message-State: ANoB5pl4YUKQPQap+SvfQN89ro79a0lkZY8jerA8UwrpDNeYrt7SvVwU ZmDvnYI9lfVwUoGgek6qM0XHAcQm+dVU27dS53Y= X-Google-Smtp-Source: AA0mqf6zbm7hPgMpTYNKHtM7yNQlXR0Rph4+/ZI2vd3gkG2icuEfD1dB/mqRyTkG9V3OJKSqa1Pb8w== X-Received: by 2002:a4a:520a:0:b0:4a3:9bd7:60e9 with SMTP id d10-20020a4a520a000000b004a39bd760e9mr13542396oob.9.1671052840485; Wed, 14 Dec 2022 13:20:40 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c2:f05e:65c9:2e7a:96b4:ab04]) by smtp.gmail.com with ESMTPSA id a22-20020a4ab796000000b004a0a7b08d9asm2645557oop.19.2022.12.14.13.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 13:20:39 -0800 (PST) To: libc-alpha@sourceware.org, Florian Weimer Subject: [PATCH] elf: Fix tst-relro-symbols.py argument passing Date: Wed, 14 Dec 2022 18:20:36 -0300 Message-Id: <20221214212036.1038959-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Current scheme only consideres the first argument for both --required and --optional, where the idea is to append a new item. Checked on x86_64-linux-gnu. --- elf/tst-relro-symbols.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/elf/tst-relro-symbols.py b/elf/tst-relro-symbols.py index 368ea3349f..41e87b37ea 100644 --- a/elf/tst-relro-symbols.py +++ b/elf/tst-relro-symbols.py @@ -56,10 +56,10 @@ def get_parser(): """Return an argument parser for this script.""" parser = argparse.ArgumentParser(description=__doc__) parser.add_argument('object', help='path to object file to check') - parser.add_argument('--required', metavar='NAME', default=(), - help='required symbol names', nargs='*') - parser.add_argument('--optional', metavar='NAME', default=(), - help='required symbol names', nargs='*') + parser.add_argument('--required', metavar='NAME', action='append', + help='required symbol names') + parser.add_argument('--optional', metavar='NAME', action='append', + help='required symbol names') return parser def main(argv):