From patchwork Wed Dec 7 18:24:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 61668 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56B02382E75E for ; Wed, 7 Dec 2022 18:25:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56B02382E75E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670437507; bh=cGrGzIeyb5DjMuIttzm9TN+H8xEN+7/hZWcT4REECOM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=IcsWms2wW67hX6MU6goKO7oD3IYEmvjW1UYJfCSGBcIVz8XYAZndvkuaYOyvmuwiU 80J2v5Qfr0jinl4irWtJwWxb/qYGpZGkTRXIMtj74bUVmbI/Y8ldfUFW4VUWdgm1Cg E7bOuTFO5iceniYTRE8uYLA3j3TH7GR76ailUino= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id D482D383F23A for ; Wed, 7 Dec 2022 18:24:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D482D383F23A Received: by mail-oi1-x236.google.com with SMTP id s187so15468264oie.10 for ; Wed, 07 Dec 2022 10:24:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cGrGzIeyb5DjMuIttzm9TN+H8xEN+7/hZWcT4REECOM=; b=vKQQB/Up1w88nUqg6tLHoi1F10LMgiBWNa0n6od2V1hlTu9LP9DVPDf1LnAa3nsypp QjMNLNhLZ1PORKFK5bdy1I+x6Cn5QLWjqHtSh5/kunznmWAaqQSW1SOZGlGPpWMJxLHl PQVk7NDgtPBMkahaMrtfqu4U7xpYR59OZ/1ErWRztm0ECMKzHIlxxFX+ErTwucvoTY2w cFNQSKGQr8IN9HavDMZYGuhqYak+qbWWUCAQrqec5dtkvHi/UoI+Ha6QnJUaF1+9YRUC 8R89SK0yV52jOK6BEOVAdk1FYn/inxB5zWb8q9dYcvXkQ6LNPpe8UtUn3O5DEyjGNDMA 9fqg== X-Gm-Message-State: ANoB5plN4Ev3Hu6RTWZp+1cUVAySXmwnPayzKObuP1ZFJc20GXUBurYu IyPGuFHnrMKD2LZ+iO0jI6+G+qef24ngNROIedw= X-Google-Smtp-Source: AA0mqf4OdxHwwA5OJbbkwA6DxGEhF7AaMgdn6yq4aPF727vc+54ZUkp6MwKU6lofsj1GYXs0vU83zA== X-Received: by 2002:a05:6808:238d:b0:35b:bff7:cc45 with SMTP id bp13-20020a056808238d00b0035bbff7cc45mr19708756oib.0.1670437482852; Wed, 07 Dec 2022 10:24:42 -0800 (PST) Received: from ubuntu22-vm.. (201-92-181-161.dsl.telesp.net.br. [201.92.181.161]) by smtp.gmail.com with ESMTPSA id j22-20020a056870169600b001447a2a34dfsm7059484oae.40.2022.12.07.10.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 10:24:42 -0800 (PST) To: libc-alpha@sourceware.org, Andreas Schwab , arnaud.lb@gmail.com Subject: [PATCH v2] stdio: Do not ignore posix_spawn error on popen (BZ #29016) Date: Wed, 7 Dec 2022 18:24:38 +0000 Message-Id: <20221207182438.172691-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" To correctly return error in case of default shell is not present. Checked on x86_64-linux-gnu. --- libio/iopopen.c | 38 ++++++++++++++++++++++---------------- stdio-common/Makefile | 3 +++ stdio-common/tst-popen3.c | 38 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 63 insertions(+), 16 deletions(-) create mode 100644 stdio-common/tst-popen3.c diff --git a/libio/iopopen.c b/libio/iopopen.c index 06778cf110..66f5936114 100644 --- a/libio/iopopen.c +++ b/libio/iopopen.c @@ -66,11 +66,12 @@ unlock (void *not_used) be close (by transversing the proc_file_chain list) and the insertion of a new one after a successful posix_spawn this function should be called with proc_file_chain_lock acquired. */ -static bool +static int spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command, int do_cloexec, int pipe_fds[2], int parent_end, int child_end, int child_pipe_fd) { + int err; for (struct _IO_proc_file *p = proc_file_chain; p; p = p->next) { @@ -79,15 +80,19 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command, /* If any stream from previous popen() calls has fileno child_pipe_fd, it has been already closed by the adddup2 action above. */ - if (fd != child_pipe_fd - && __posix_spawn_file_actions_addclose (fa, fd) != 0) - return false; + if (fd != child_pipe_fd) + { + err = __posix_spawn_file_actions_addclose (fa, fd); + if (err != 0) + return err; + } } - if (__posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0, - (char *const[]){ (char*) "sh", (char*) "-c", - (char *) command, NULL }, __environ) != 0) - return false; + err = __posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0, + (char *const[]){ (char*) "sh", (char*) "-c", + (char *) command, NULL }, __environ); + if (err != 0) + return err; __close_nocancel (pipe_fds[child_end]); @@ -101,7 +106,7 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command, ((_IO_proc_file *) fp)->next = proc_file_chain; proc_file_chain = (_IO_proc_file *) fp; - return true; + return 0; } FILE * @@ -112,7 +117,7 @@ _IO_new_proc_open (FILE *fp, const char *command, const char *mode) int parent_end, child_end; int pipe_fds[2]; int child_pipe_fd; - bool spawn_ok; + int err; int do_read = 0; int do_write = 0; @@ -185,16 +190,17 @@ _IO_new_proc_open (FILE *fp, const char *command, const char *mode) pipe_fds[child_end] = tmp; } - if (__posix_spawn_file_actions_adddup2 (&fa, pipe_fds[child_end], - child_pipe_fd) != 0) + err = __posix_spawn_file_actions_adddup2 (&fa, pipe_fds[child_end], + child_pipe_fd); + if (err != 0) goto spawn_failure; #ifdef _IO_MTSAFE_IO _IO_cleanup_region_start_noarg (unlock); _IO_lock_lock (proc_file_chain_lock); #endif - spawn_ok = spawn_process (&fa, fp, command, do_cloexec, pipe_fds, - parent_end, child_end, child_pipe_fd); + err = spawn_process (&fa, fp, command, do_cloexec, pipe_fds, parent_end, + child_end, child_pipe_fd); #ifdef _IO_MTSAFE_IO _IO_lock_unlock (proc_file_chain_lock); _IO_cleanup_region_end (0); @@ -202,12 +208,12 @@ _IO_new_proc_open (FILE *fp, const char *command, const char *mode) __posix_spawn_file_actions_destroy (&fa); - if (!spawn_ok) + if (err != 0) { + __set_errno (err); spawn_failure: __close_nocancel (pipe_fds[child_end]); __close_nocancel (pipe_fds[parent_end]); - __set_errno (ENOMEM); return NULL; } diff --git a/stdio-common/Makefile b/stdio-common/Makefile index fe57dbdf56..9a9a37ae08 100644 --- a/stdio-common/Makefile +++ b/stdio-common/Makefile @@ -215,6 +215,9 @@ tests := \ xbug \ # tests +tests-container += \ + tst-popen3 + generated += \ errlist-data-aux-shared.S \ errlist-data-aux.S \ diff --git a/stdio-common/tst-popen3.c b/stdio-common/tst-popen3.c new file mode 100644 index 0000000000..47f4c8cd91 --- /dev/null +++ b/stdio-common/tst-popen3.c @@ -0,0 +1,38 @@ +/* Check if popen returns a correct error code if the default shell does not + exist (BZ#29016). + + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include + +int +do_test (void) +{ + xunlink (_PATH_BSHELL); + + FILE *f = popen ("/non-existent", "r"); + TEST_VERIFY (f == NULL); + TEST_COMPARE (errno, ENOENT); + return 0; +} + +#include