From patchwork Tue Dec 6 16:02:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 61591 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 19EE5383FD7F for ; Tue, 6 Dec 2022 16:03:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19EE5383FD7F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670342608; bh=2ROdcVpzFnQV7gJLLTWIFhGhtu8AZraQ5oI+hxY+IT8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BHZImfi45Wq3OIAbawnOU22HxiiS/cM2zlakBURBLCOOmFc2I4KbhX7LX7SAjuN7y CLKYASiZHqosYRYTlcatDZxEjMNVTW9TIfj6tJxq2j3UpyuAHueqx/hMHeVlnPo869 uQZMOntA50C1wBo6KSTnEYv/G/45dTls1ufLl7gw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 85EDD3842319 for ; Tue, 6 Dec 2022 16:03:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85EDD3842319 Received: by mail-ot1-x329.google.com with SMTP id v19-20020a9d5a13000000b0066e82a3872dso7510965oth.5 for ; Tue, 06 Dec 2022 08:03:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ROdcVpzFnQV7gJLLTWIFhGhtu8AZraQ5oI+hxY+IT8=; b=Mw+YX+dFNXMITF89xaPDYPk6iqHoSqtNFmEL9Gj0V4nal60HZNaotx1lqI+IOEBNAu QiOhK9PACxrKQyRW6m55Ik9ZzxrF2xiMc9ZoXgqRZd/Dl81R+oNDkCJnjlVU4xt2QR+1 62nHxUchwmO+mgQ+RNd5tWwofyhjLr9aF1GRKa6WCQAIFPPLCGkdpHGcfM3Xk/98HsLp DLb3heYsvn1MIgTkzJUFoJ9POv9dPB7uOoWP80NAISGiOS2/puS8i0/yowXTSctEKqSv dFbI1d51LEpTWs1xFCs8d2SubblXU1nDUyiSS1fPMfwfJVYwl7EpJXAQ6rM8pUC2/fQb uFOg== X-Gm-Message-State: ANoB5pndzL6NlQ0HLCQH43D7mIG3Ga/PeDKQbhiiq1hF5y/KAwr81h67 qSpcz9yoj5hTVPQJXKCeRLD3ZI2fNd7oDjKq1tk= X-Google-Smtp-Source: AA0mqf4gpFsMFGjER2pdBW7Fg8NpM0Xppe7pzGL5zw4xQhRpJkhB06KRl+YGb6P+LLHeQQMX1RgB6w== X-Received: by 2002:a05:6830:186:b0:66e:7d07:2ead with SMTP id q6-20020a056830018600b0066e7d072eadmr10983852ota.154.1670342585574; Tue, 06 Dec 2022 08:03:05 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c2:6793:6a7:7646:7f3f:684e]) by smtp.gmail.com with ESMTPSA id k6-20020a544686000000b00349a06c581fsm8495008oic.3.2022.12.06.08.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 08:03:05 -0800 (PST) To: libc-alpha@sourceware.org, Vineet Gupta , =?utf-8?q?Ludovic_Court=C3=A8s?= , Carlos O'Donell Subject: [PATCH v2 1/3] configure: Allow user override LD, AR, OBJCOPY, and GPROF Date: Tue, 6 Dec 2022 13:02:41 -0300 Message-Id: <20221206160243.455627-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221206160243.455627-1-adhemerval.zanella@linaro.org> References: <20221206160243.455627-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The only way to override LD, AR, OBJCOPY, and GPROF is through --with-binutils (setting the environments variables on configure is overridden by LIBC_PROG_BINUTILS). The build-many-glibcs.py (bmg) glibcs option generates a working config, but not fully concise (some tools will be set from environment variable, while other will be set from $CC --print-prog-name). So remove the environment variable set to always use the "$CC --print-prog-name". Reviewed-by: Carlos O'Donell --- aclocal.m4 | 16 ++++++++++++---- configure | 16 ++++++++++++---- scripts/build-many-glibcs.py | 3 --- 3 files changed, 24 insertions(+), 11 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index 7ab8ac023b..cbe3c4698a 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -118,12 +118,20 @@ case "$CC" in *fuse-ld=lld*) LDNAME=ld.lld;; *) LDNAME=ld;; esac -LD=`$CC -print-prog-name=$LDNAME` -AR=`$CC -print-prog-name=ar` +if test -z "$LD"; then + LD=`$CC -print-prog-name=$LDNAME` +fi +if test -z "$AR"; then + AR=`$CC -print-prog-name=ar` +fi AC_SUBST(AR) -OBJCOPY=`$CC -print-prog-name=objcopy` +if test -z "$OBJCOPY"; then + OBJCOPY=`$CC -print-prog-name=objcopy` +fi AC_SUBST(OBJCOPY) -GPROF=`$CC -print-prog-name=gprof` +if test -z "$GPROF"; then + GPROF=`$CC -print-prog-name=gprof` +fi AC_SUBST(GPROF) ]) diff --git a/configure b/configure index 62c2581cb0..8f91bb6e11 100755 --- a/configure +++ b/configure @@ -4145,12 +4145,20 @@ case "$CC" in *fuse-ld=lld*) LDNAME=ld.lld;; *) LDNAME=ld;; esac -LD=`$CC -print-prog-name=$LDNAME` -AR=`$CC -print-prog-name=ar` +if test -z "$LD"; then + LD=`$CC -print-prog-name=$LDNAME` +fi +if test -z "$AR"; then + AR=`$CC -print-prog-name=ar` +fi -OBJCOPY=`$CC -print-prog-name=objcopy` +if test -z "$OBJCOPY"; then + OBJCOPY=`$CC -print-prog-name=objcopy` +fi -GPROF=`$CC -print-prog-name=gprof` +if test -z "$GPROF"; then + GPROF=`$CC -print-prog-name=gprof` +fi diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py index 9292a0d3ff..887ef7b6d5 100755 --- a/scripts/build-many-glibcs.py +++ b/scripts/build-many-glibcs.py @@ -1521,10 +1521,7 @@ class GlibcPolicyDefault(object): '--host=%s' % glibc.triplet, 'CC=%s' % glibc.tool_name('gcc'), 'CXX=%s' % glibc.tool_name('g++'), - 'AR=%s' % glibc.tool_name('ar'), - 'LD=%s' % glibc.tool_name('ld'), 'NM=%s' % glibc.tool_name('nm'), - 'OBJCOPY=%s' % glibc.tool_name('objcopy'), 'OBJDUMP=%s' % glibc.tool_name('objdump'), 'RANLIB=%s' % glibc.tool_name('ranlib'), 'READELF=%s' % glibc.tool_name('readelf'),