Message ID | 20221028173532.876027-6-adhemerval.zanella@linaro.org |
---|---|
State | Committed |
Commit | 6ee5a9767a245455720d39eeaa3ce136825e8a42 |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0C29A3858C52 for <patchwork@sourceware.org>; Fri, 28 Oct 2022 17:36:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C29A3858C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666978578; bh=nyIsZKrHHG8RpTg/Ivr9SYtxUycdQKiU6mHffPnaPuE=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AjQtSjwTLsysnprTRMrrzOqRGvW2/cASujKaXKVy2Lwc5prb3XLAanhQobLhgqhFJ ptV/o2n+dyaIDR+wl5IE/OJUSKDkv9Tb+UVY89zZ0hkANGJkAKGpikLuht7VbNhwSq g5gS3Oee/4TDNoj0C6/433DJCOwdkZjzv+qJ7jAs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by sourceware.org (Postfix) with ESMTPS id 713D13858298 for <libc-alpha@sourceware.org>; Fri, 28 Oct 2022 17:35:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 713D13858298 Received: by mail-oo1-xc33.google.com with SMTP id r76-20020a4a374f000000b004988a70de2eso136271oor.2 for <libc-alpha@sourceware.org>; Fri, 28 Oct 2022 10:35:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nyIsZKrHHG8RpTg/Ivr9SYtxUycdQKiU6mHffPnaPuE=; b=NejEoXhHkMqwnEMh6pdpmveKhWVmpEu7WPzwI+PL4knqwjsCodYc3qjUsZ7ZD1/ovs VCD5T5uFOy8gsRWmY+cbPxp3bDi6Y0ODtnuE4Wmije1xsiFuWA4kNkIQWq/fZhvclIuF ef3BIUfrYw6OES/3HPwk/T5o7F1PgLnOwWx9N18Jpl2//JkiryPoPsUddCAFtO60a6QY inmDAh5buPidX0UM0raYltxR666imcjO5nK6D/7eYQpf0RkzQE8cAyVL6aBs8/GjvOpf auasDHsC6FbUUI5ns+2T+aBq1P91JlvP1AATg3XvzX33admM/494FxbVrbAOTglEghPh OvFQ== X-Gm-Message-State: ACrzQf3P0TtunNvW0XvitwmcPk1s5LzS5vW/chzLptfGcOPEzMu4Yr4H 1Vsi1n2fjRYIKvczFCN5HRG+51RA0u8u8C+U X-Google-Smtp-Source: AMsMyM6DIP3MMT37H1SIWO5piiecapR/KsBVzJjjqEAOhOdzKxoY08tJOIoecKuVRppkTzEYMJTjXQ== X-Received: by 2002:a05:6820:1746:b0:47f:926a:286d with SMTP id bf6-20020a056820174600b0047f926a286dmr279683oob.5.1666978546523; Fri, 28 Oct 2022 10:35:46 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:17c8:6484:1100:1451:7f3f]) by smtp.gmail.com with ESMTPSA id v10-20020a056870b50a00b0012779ba00fesm2434998oap.2.2022.10.28.10.35.45 for <libc-alpha@sourceware.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 10:35:46 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 05/11] intl: Fix clang -Wunused-but-set-variable on plural.c Date: Fri, 28 Oct 2022 14:35:26 -0300 Message-Id: <20221028173532.876027-6-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221028173532.876027-1-adhemerval.zanella@linaro.org> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Initial fixes for clang build support
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Adhemerval Zanella Netto
Oct. 28, 2022, 5:35 p.m. UTC
Clang warns that '__gettextnerrs' set but not used: intl/plural.c:1034:9: error: variable '__gettextnerrs' set but not used [-Werror,-Wunused-but-set-variable] int yynerrs = 0; ^ Since the file is auto-generated, suppress the warning with a compiler flag. --- intl/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >Clang warns that '__gettextnerrs' set but not used: > > intl/plural.c:1034:9: error: variable '__gettextnerrs' set but not used > [-Werror,-Wunused-but-set-variable] > int yynerrs = 0; > ^ > >Since the file is auto-generated, suppress the warning with a compiler >flag. >--- > intl/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/intl/Makefile b/intl/Makefile >index 315c75a18f..1c3b2a2273 100644 >--- a/intl/Makefile >+++ b/intl/Makefile >@@ -154,7 +154,8 @@ $(objpfx)tst-gettext5.out: $(objpfx)tst-gettext.out > $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out > > CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \ >- -D'LOCALE_ALIAS_PATH="$(localedir)"' >+ -D'LOCALE_ALIAS_PATH="$(localedir)"' \ >+ -Wno-unused-but-set-variable > BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output > > $(inst_localedir)/locale.alias: locale.alias $(+force) >-- >2.34.1 > yynerrs is incremented but its value is unused. Clang 15 (https://reviews.llvm.org/D122271) -Wunused-but-set-variable gives a warning while GCC doesn't. -Wunused-but-set-variable is available in GCC 4.6, smaller than the minimum required version 6.2. Reviewed-by: Fangrui Song <maskray@google.com>
On 28/10/22 21:44, Fangrui Song wrote: > On 2022-10-28, Adhemerval Zanella via Libc-alpha wrote: >> Clang warns that '__gettextnerrs' set but not used: >> >> intl/plural.c:1034:9: error: variable '__gettextnerrs' set but not used >> [-Werror,-Wunused-but-set-variable] >> int yynerrs = 0; >> ^ >> >> Since the file is auto-generated, suppress the warning with a compiler >> flag. >> --- >> intl/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/intl/Makefile b/intl/Makefile >> index 315c75a18f..1c3b2a2273 100644 >> --- a/intl/Makefile >> +++ b/intl/Makefile >> @@ -154,7 +154,8 @@ $(objpfx)tst-gettext5.out: $(objpfx)tst-gettext.out >> $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out >> >> CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \ >> - -D'LOCALE_ALIAS_PATH="$(localedir)"' >> + -D'LOCALE_ALIAS_PATH="$(localedir)"' \ >> + -Wno-unused-but-set-variable >> BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output >> >> $(inst_localedir)/locale.alias: locale.alias $(+force) >> -- >> 2.34.1 >> > > yynerrs is incremented but its value is unused. > Clang 15 (https://reviews.llvm.org/D122271) -Wunused-but-set-variable > gives a warning while GCC doesn't. > -Wunused-but-set-variable is available in GCC 4.6, smaller than the minimum required version 6.2. I will add this on commit message. > > Reviewed-by: Fangrui Song <maskray@google.com> Thanks.
diff --git a/intl/Makefile b/intl/Makefile index 315c75a18f..1c3b2a2273 100644 --- a/intl/Makefile +++ b/intl/Makefile @@ -154,7 +154,8 @@ $(objpfx)tst-gettext5.out: $(objpfx)tst-gettext.out $(objpfx)tst-gettext6.out: $(objpfx)tst-gettext.out CPPFLAGS += -D'LOCALEDIR="$(localedir)"' \ - -D'LOCALE_ALIAS_PATH="$(localedir)"' + -D'LOCALE_ALIAS_PATH="$(localedir)"' \ + -Wno-unused-but-set-variable BISONFLAGS = --yacc --no-lines --name-prefix=__gettext --output $(inst_localedir)/locale.alias: locale.alias $(+force)