From patchwork Fri Oct 28 17:35:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 59591 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D7A63865C27 for ; Fri, 28 Oct 2022 17:36:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D7A63865C27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666978570; bh=j9St8UCM0O61/Z66YTadW7yuL4AnWR4YzEquW/lyvMQ=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EvOfjsRE3JEKH8WRgTPi1lychssEKhVcE8RyEsFB3LsRL6DsIQLg+k5MGjjN6r04Y 1h/M8ATOaLsKrReObrC/4yTre5SOjJT0Cct2ES3rBiRox0y5Dyq0WQ1sK9VUQMrAmd GSUF8oTxSZeIK/mMLBpWGZXSYx0SEt9jabGfya4k= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id B7A4F3858CDB for ; Fri, 28 Oct 2022 17:35:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B7A4F3858CDB Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-13bef14ea06so7056956fac.3 for ; Fri, 28 Oct 2022 10:35:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j9St8UCM0O61/Z66YTadW7yuL4AnWR4YzEquW/lyvMQ=; b=bPQFYcVRTSphTUoIyf/R/6cB543hQk+n+xWnNagRfmJZfvN4RYWw+PkhEi2YvgKr2v MMdw6AzjgUsPH9ZP1JP1/RqmdjHb4KwnH/gu7Ir7hNUKV9KVDJjnrDuA5AwLi86oZsoR QctO2cBvAXw2zj5Ng8LySdSEcNcmw82t0CEIN0QLXkbO1VtSXptyQLNLHSNay02vImwt 53pIogHQmCj9dR9qBfAaB0u2AmwfbVZOrIMvl8RfkO5cJw4PxdiCTJxspcdewsx3LnWF laQ8vjJlFeqB+qqjctjXfhi773hzBdEZ79hSWkfcySywmAqDxPI7XUiHLhE89ftRXFjc mN7w== X-Gm-Message-State: ACrzQf2y/pqeu6Mjf5fglb2USp5eofokoeQ4ntYwqZx7CfTQxWYoQLTZ A9nfckHLQDhSmI+4kEmCKG2Da+D+sk0C8Mhl X-Google-Smtp-Source: AMsMyM5/a5f4nh0JUaeEmna5VyE9AucXCn1E16yc20zS+6CrMgb8XWanOWLOHXOoTsf1841DUqZJDA== X-Received: by 2002:a05:6870:b407:b0:131:8535:698b with SMTP id x7-20020a056870b40700b001318535698bmr9633828oap.263.1666978542950; Fri, 28 Oct 2022 10:35:42 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:17c8:6484:1100:1451:7f3f]) by smtp.gmail.com with ESMTPSA id v10-20020a056870b50a00b0012779ba00fesm2434998oap.2.2022.10.28.10.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 10:35:42 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 02/11] Disable __USE_EXTERN_INLINES for clang Date: Fri, 28 Oct 2022 14:35:23 -0300 Message-Id: <20221028173532.876027-3-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221028173532.876027-1-adhemerval.zanella@linaro.org> References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" From: Fangrui Song clang does not allow to redefine attributes after function declaration. Although it work for external usage, its breaks the build for internal symbol that glibc provides as optimization (for instance bsearch with stdlib-bsearch.h or __cmsg_nxthdr). Disable such optimization for clang. --- include/features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/features.h b/include/features.h index 123de9fd47..8d5a7cef5d 100644 --- a/include/features.h +++ b/include/features.h @@ -502,7 +502,7 @@ /* Decide whether we can define 'extern inline' functions in headers. */ #if __GNUC_PREREQ (2, 7) && defined __OPTIMIZE__ \ && !defined __OPTIMIZE_SIZE__ && !defined __NO_INLINE__ \ - && defined __extern_inline + && defined __extern_inline && !defined __clang__ # define __USE_EXTERN_INLINES 1 #endif