diff mbox series

[1/3] nis: Build libnsl with 64 bit time_t

Message ID 20221026190425.2939456-2-adhemerval.zanella@linaro.org
State Committed
Commit 545eefc2f5da61801ba82b7a32ca2589b769ec90
Headers
Series Fixing missing 64 bit time_t usages |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Adhemerval Zanella Oct. 26, 2022, 7:04 p.m. UTC 
  And remove the usage of glibc reserved names.
---
 Makeconfig     |  2 +-
 nis/nis_call.c | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

DJ Delorie Dec. 9, 2022, 4:30 a.m. UTC | #1 
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> writes:
> And remove the usage of glibc reserved names.
> ---
>  Makeconfig     |  2 +-
>  nis/nis_call.c | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)

LGTM
Reviewed-by: DJ Delorie <dj@redhat.com>
DJ Delorie Dec. 9, 2022, 4:31 a.m. UTC | #2 
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> writes:
> And remove the usage of glibc reserved names.

Will you be doing this for stat64 calls too?  Or is that a different
type of problem?
Adhemerval Zanella Dec. 9, 2022, 2:35 p.m. UTC | #3 
On 09/12/22 01:31, DJ Delorie wrote:
> Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> writes:
>> And remove the usage of glibc reserved names.
> 
> Will you be doing this for stat64 calls too?  Or is that a different
> type of problem?
> 

Good question, let me check if there is an issue for largefile names.
diff mbox series

Patch

diff --git a/Makeconfig b/Makeconfig
index 08a869cd11..f3f816ce32 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -884,7 +884,7 @@  endif
 # Use 64 bit time_t support for installed programs
 installed-modules = nonlib nscd ldconfig locale_programs \
 		    iconvprogs libnss_files libnss_compat libnss_db libnss_hesiod \
-		    libutil libpcprofile
+		    libutil libpcprofile libnsl
 +extra-time-flags = $(if $(filter $(installed-modules),\
                            $(in-module)),-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64)
 
diff --git a/nis/nis_call.c b/nis/nis_call.c
index 90187e30b1..5b9dd50151 100644
--- a/nis/nis_call.c
+++ b/nis/nis_call.c
@@ -574,7 +574,7 @@  static struct nis_server_cache
   unsigned int size;
   unsigned int server_used;
   unsigned int current_ep;
-  __time64_t expires;
+  time_t expires;
   char name[];
 } *nis_server_cache[16];
 static time_t nis_cold_start_mtime;
@@ -583,7 +583,7 @@  __libc_lock_define_initialized (static, nis_server_cache_lock)
 static directory_obj *
 nis_server_cache_search (const_nis_name name, int search_parent,
 			 unsigned int *server_used, unsigned int *current_ep,
-			 struct __timespec64 *now)
+			 struct timespec *now)
 {
   directory_obj *ret = NULL;
   int i;
@@ -641,7 +641,7 @@  nis_server_cache_search (const_nis_name name, int search_parent,
 static void
 nis_server_cache_add (const_nis_name name, int search_parent,
 		      directory_obj *dir, unsigned int server_used,
-		      unsigned int current_ep, struct __timespec64 *now)
+		      unsigned int current_ep, struct timespec *now)
 {
   struct nis_server_cache **loc;
   struct nis_server_cache *new;
@@ -707,7 +707,7 @@  __nisfind_server (const_nis_name name, int search_parent,
   nis_error result = NIS_SUCCESS;
   nis_error status;
   directory_obj *obj;
-  struct __timespec64 ts;
+  struct timespec ts;
   unsigned int server_used = ~0;
   unsigned int current_ep = ~0;
 
@@ -717,7 +717,7 @@  __nisfind_server (const_nis_name name, int search_parent,
   if (*dir != NULL)
     return NIS_SUCCESS;
 
-  __clock_gettime64 (CLOCK_REALTIME, &ts);
+  clock_gettime (CLOCK_REALTIME, &ts);
 
   if ((flags & NO_CACHE) == 0)
     *dir = nis_server_cache_search (name, search_parent, &server_used,