From patchwork Fri Sep 30 19:26:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 58236 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF0053851AB8 for ; Fri, 30 Sep 2022 19:28:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF0053851AB8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664566136; bh=cZWvAEZ3stjf4BdTZAVYsQHZ009wFuUBe4zrmq0i4r8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=te6UN6rxrXuYCeB507F0GZPEFxNZJfzP/v/RuzbU6gZR2pKoJ7g9z9Qr1SZOFkd3M d3S9wAPjvFGJX3+00k/Ei8d5Gml/7W3/oi/AgUSBYg/h3/t1jbCTZGPPVnXzIomYD/ XhbaBzR1rbrHAW6Zork/WgDj69N94JZB6Qay9JLs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by sourceware.org (Postfix) with ESMTPS id 4583F3854169 for ; Fri, 30 Sep 2022 19:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4583F3854169 Received: by mail-vs1-xe2f.google.com with SMTP id d187so5814021vsd.6 for ; Fri, 30 Sep 2022 12:26:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=cZWvAEZ3stjf4BdTZAVYsQHZ009wFuUBe4zrmq0i4r8=; b=V6SZ/nX79HPRhOet9LU44119P1DRPug6WYRDYlVXMKAZsgJAIiPZT4FGSOuxmIkOt/ U7srUD8SupLZxfuHL3w34p2ppXCrJhPe3PckMaqoMPWEyxu5Ijr8b2WAH1y9Lf11h8ej g4v9FPcFzqINwgzBSGUx6g6kZDFi1mtxPV8t3stJlUZ3+BFwlhyxu9qUQOscq23322E1 KwQRFe14rVzqCtwmIthUuXPPNVZtoQOTlEDA5Mvr3T2fixb3R33D0UxN4lE5usnhn1YA 9qqxpTtyaL0ce2JlH3kkJccahY31cTdo8mee7cj4okxFL8WHWbx15OUysy3k+ewqgleG HS5Q== X-Gm-Message-State: ACrzQf1PuJU7WJPwJQAl/0icwc/VWMi3io130GKAscrG9YKIpexl20Lu F2ARlg4RYp3f6OPzDhH4BNwzEdYB0Wqk34Dn X-Google-Smtp-Source: AMsMyM53j9Ewku8OSVbFB2mJhlag5LdjemBCfi8Q918UeXrmi6h/k2Y7cKu01ilSyHQLyTk0bCiCIw== X-Received: by 2002:a67:e0d2:0:b0:398:93a:ded3 with SMTP id m18-20020a67e0d2000000b00398093aded3mr5425895vsl.68.1664565989296; Fri, 30 Sep 2022 12:26:29 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:cce5:8b83:d63b:2954]) by smtp.gmail.com with ESMTPSA id h197-20020a1f21ce000000b0039ecbaa55d8sm2381545vkh.44.2022.09.30.12.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 12:26:28 -0700 (PDT) To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH v2 7/9] arm: Add the clone3 wrapper Date: Fri, 30 Sep 2022 16:26:11 -0300 Message-Id: <20220930192613.3491147-8-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" It follows the internal signature: extern int clone3 (struct clone_args *__cl_args, size_t __size, int (*__func) (void *__arg), void *__arg); And x86_64 semantics to return EINVAL if either cl_args or func is NULL. The stack is 16-byte aligned prior executing func. Checked on arm-linux-gnueabihf. --- sysdeps/unix/sysv/linux/arm/clone3.S | 80 ++++++++++++++++++++++++++++ sysdeps/unix/sysv/linux/arm/sysdep.h | 1 + 2 files changed, 81 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/arm/clone3.S diff --git a/sysdeps/unix/sysv/linux/arm/clone3.S b/sysdeps/unix/sysv/linux/arm/clone3.S new file mode 100644 index 0000000000..f6b274cf51 --- /dev/null +++ b/sysdeps/unix/sysv/linux/arm/clone3.S @@ -0,0 +1,80 @@ +/* The clone3 syscall wrapper. Linux/arm version. + Copyright (C) 2022 Free Software Foundation, Inc. + + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#define _ERRNO_H 1 +#include + +/* The userland implementation is: + int clone3 (struct clone_args *cl_args, size_t size, + int (*func)(void *arg), void *arg); + + the kernel entry is: + int clone3 (struct clone_args *cl_args, size_t size); + + The parameters are passed in registers from userland: + r0: cl_args + r1: size + r2: func + r3: arg */ + + .text +ENTRY(__clone3) + /* Sanity check args. */ + cmp r0, #0 + ite ne + cmpne r1, #0 + moveq r0, #-EINVAL + beq PLTJMP(syscall_error) + + /* Do the syscall, the kernel expects: + r7: system call number: + r0: cl_args + r1: size */ + ldr r7, =SYS_ify(clone3) + swi 0x0 + cfi_endproc + + cmp r0, #0 + beq 1f + + blt PLTJMP(C_SYMBOL_NAME(__syscall_error)) + RETINSTR(, lr) + + cfi_startproc +PSEUDO_END (__clone3) + +1: + .fnstart + .cantunwind + /* Align sp. */ + and sp, sp, #-8 + + mov r0, r3 + mov ip, r2 + BLX (ip) + + /* And we are done, passing the return value through r0. */ + ldr r7, =SYS_ify(exit) + swi 0x0 + + .fnend + +libc_hidden_def (__clone3) +weak_alias (__clone3, clone3) diff --git a/sysdeps/unix/sysv/linux/arm/sysdep.h b/sysdeps/unix/sysv/linux/arm/sysdep.h index 1f270b961e..fcc86189d6 100644 --- a/sysdeps/unix/sysv/linux/arm/sysdep.h +++ b/sysdeps/unix/sysv/linux/arm/sysdep.h @@ -362,6 +362,7 @@ __local_syscall_error: \ #define HAVE_CLOCK_GETTIME_VSYSCALL "__vdso_clock_gettime" #define HAVE_CLOCK_GETTIME64_VSYSCALL "__vdso_clock_gettime64" #define HAVE_GETTIMEOFDAY_VSYSCALL "__vdso_gettimeofday" +#define HAVE_CLONE3_WRAPPER 1 #define LOAD_ARGS_0() #define ASM_ARGS_0