From patchwork Fri Sep 30 19:26:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 58229 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD8FB385C40E for ; Fri, 30 Sep 2022 19:26:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD8FB385C40E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1664566004; bh=0woY+EMgt7ar7mF/5FQNhOpufYgjE/zBTuF4VwR2cfE=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kzMQtEqilFwS4wvBVQaLJIHOT2xD6BsIm7SQZt6PqtvawLHZAcCLFKHT4S6qSlFGq InRD0Y6tAO+vUPm6bkAkxxHM71uW97EvsSDAa9s3HmtqeRt/1JHxf2WuU8tle8+A6U C9IGXN71Nlz6m9HWcBiftwhKyszNod71r86PhJu8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 2A4633858D38 for ; Fri, 30 Sep 2022 19:26:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2A4633858D38 Received: by mail-ua1-x932.google.com with SMTP id p89so2097530uap.12 for ; Fri, 30 Sep 2022 12:26:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date; bh=0woY+EMgt7ar7mF/5FQNhOpufYgjE/zBTuF4VwR2cfE=; b=DPbwXBURT66uWC8tPxbf+yvmvBzGdd5zG+H8aDdASkY2o787GkjG++nixmhbrw7OCX LhCjsHRloC6WJ9mwM9VqbYeheke9caFKOJEUEvr118Ts+7Ukl8joIFjp3zH35NGqSd0U jyGsipQIVK6D0aBmssuukZcp/s2xoZFLJ4bWsyTWoom4Np5XFgc0bF9kwjU6Ph3ajxGw 9y6WKeTKldRSUoafpQJcb8UARWeVFN+e+hS5IUrPCKOG/h8DgHO4q9CGN0gzRrqmP0P5 2k1MVgywSsMc3+OAGvK3aTGT/qMUxovdpAw8WunOgfRvkxeo5LhG1ChZPJkGgWISM9Iu N4Fw== X-Gm-Message-State: ACrzQf2FncOd48YA/EjsZSC8pBis1mE/vWuNMQsTlvDzmJW3rEZ0mvaV Bx9uv7GWy1FhwYfRYbrlOzKF8QkgSYfSVy+0 X-Google-Smtp-Source: AMsMyM7eKLCHjv22VnDYTABfAGOKKBPM7WEVuc9Q5bEOmxqCqOIosBUZl7FQal47LqeWB9/O+ZjeoA== X-Received: by 2002:ab0:b91:0:b0:3bf:2c1b:9788 with SMTP id c17-20020ab00b91000000b003bf2c1b9788mr6002026uak.28.1664565979332; Fri, 30 Sep 2022 12:26:19 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:3736:cce5:8b83:d63b:2954]) by smtp.gmail.com with ESMTPSA id h197-20020a1f21ce000000b0039ecbaa55d8sm2381545vkh.44.2022.09.30.12.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 12:26:18 -0700 (PDT) To: libc-alpha@sourceware.org, Christian Brauner Subject: [PATCH v2 1/9] linux: Do not reset signal handler in posix_spawn if it is already SIG_DFL Date: Fri, 30 Sep 2022 16:26:05 -0300 Message-Id: <20220930192613.3491147-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> References: <20220930192613.3491147-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" There is no need to issue another sigaction is the disposition is already SIG_DFL. Checked on x86_64-linux-gnu. --- sysdeps/unix/sysv/linux/spawni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c index ee843a2247..65ee03c804 100644 --- a/sysdeps/unix/sysv/linux/spawni.c +++ b/sysdeps/unix/sysv/linux/spawni.c @@ -129,7 +129,7 @@ __spawni_child (void *arguments) else { __libc_sigaction (sig, 0, &sa); - if (sa.sa_handler == SIG_IGN) + if (sa.sa_handler == SIG_IGN || sa.sa_handler == SIG_DFL) continue; sa.sa_handler = SIG_DFL; }