[v3,6/8] Add NEWS entry for legacy hwcaps removal

Message ID 20220927200847.429d47a28c2f3f108aa3c080@otheo.eu
State Committed
Headers
Series Remove legacy hwcaps support |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Javier Pello Sept. 27, 2022, 6:08 p.m. UTC
  Add a NEWS entry noting the removal of the legacy hwcaps search
mechanism for shared objects.

Signed-off-by: Javier Pello <devel@otheo.eu>
---
 NEWS | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Adhemerval Zanella Netto Oct. 3, 2022, 3:44 p.m. UTC | #1
On 27/09/22 15:08, Javier Pello wrote:
> Add a NEWS entry noting the removal of the legacy hwcaps search
> mechanism for shared objects.
> 
> Signed-off-by: Javier Pello <devel@otheo.eu>
> ---
>  NEWS | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/NEWS b/NEWS
> index ef274d1a..dbb48914 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -13,7 +13,10 @@ Major new features:
>  
>  Deprecated and removed features, and other changes affecting compatibility:
>  
> -  [Add deprecations, removals and changes affecting compatibility here]
> +* glibc no longer loads shared objects from the "tls" subdirectories on the
> +  library search path or the subdirectory that corresponds to the AT_PLATFORM
> +  system name, or employs the legacy AT_HWCAP search mechanism, which was
> +  deprecated in version 2.33.

I think NEWS entry usually reference to glibc with an article ('The glibc').
The rest sounds ok, although I am not a native english speaker.

>  
>  Changes to build and runtime requirements:
>
  
Andreas Schwab Oct. 3, 2022, 7:29 p.m. UTC | #2
On Okt 03 2022, Adhemerval Zanella Netto via Libc-alpha wrote:

> I think NEWS entry usually reference to glibc with an article ('The glibc').

glibc is a proper name, and proper names don't come with articles.  You
can write "the GNU C library", but not "the glibc".
  
Adhemerval Zanella Netto Oct. 3, 2022, 7:49 p.m. UTC | #3
On 03/10/22 16:29, Andreas Schwab wrote:
> On Okt 03 2022, Adhemerval Zanella Netto via Libc-alpha wrote:
> 
>> I think NEWS entry usually reference to glibc with an article ('The glibc').
> 
> glibc is a proper name, and proper names don't come with articles.  You
> can write "the GNU C library", but not "the glibc".
> 

Which would be the best option for the NEWS entry, just 'glibc' or a
more specific 'The GNU C library'?  I don't have a strong opinion here.
  
Florian Weimer Oct. 3, 2022, 7:59 p.m. UTC | #4
* Adhemerval Zanella Netto via Libc-alpha:

> On 03/10/22 16:29, Andreas Schwab wrote:
>> On Okt 03 2022, Adhemerval Zanella Netto via Libc-alpha wrote:
>> 
>>> I think NEWS entry usually reference to glibc with an article ('The glibc').
>> 
>> glibc is a proper name, and proper names don't come with articles.  You
>> can write "the GNU C library", but not "the glibc".
>> 
>
> Which would be the best option for the NEWS entry, just 'glibc' or a
> more specific 'The GNU C library'?  I don't have a strong opinion here.

“The GNU C library” at the start of a sentence, otherwise glibc is
also okay.  In this case, you could use “The dynamic linker” or “The
glibc dynamic linker”.
  
Adhemerval Zanella Netto Oct. 4, 2022, 6 p.m. UTC | #5
On 03/10/22 16:59, Florian Weimer wrote:
> * Adhemerval Zanella Netto via Libc-alpha:
> 
>> On 03/10/22 16:29, Andreas Schwab wrote:
>>> On Okt 03 2022, Adhemerval Zanella Netto via Libc-alpha wrote:
>>>
>>>> I think NEWS entry usually reference to glibc with an article ('The glibc').
>>>
>>> glibc is a proper name, and proper names don't come with articles.  You
>>> can write "the GNU C library", but not "the glibc".
>>>
>>
>> Which would be the best option for the NEWS entry, just 'glibc' or a
>> more specific 'The GNU C library'?  I don't have a strong opinion here.
> 
> “The GNU C library” at the start of a sentence, otherwise glibc is
> also okay.  In this case, you could use “The dynamic linker” or “The
> glibc dynamic linker”.

Javier, are you ok with:

  The dynamic linker no longer loads shared objects from the "tls" 
  subdirectories on the library search path or the subdirectory 
  that corresponds to the AT_PLATFORM system name, or employs the 
  legacy AT_HWCAP search mechanism, which was deprecated in version 
  2.33.

If so I can wrap-up the patches and push upstream for you.
  
Javier Pello Oct. 5, 2022, 6:12 p.m. UTC | #6
On Tue, 4 Oct 2022 15:00:33 -0300 Adhemerval Zanella Netto wrote:

> On 03/10/22 16:59, Florian Weimer wrote:
> > * Adhemerval Zanella Netto via Libc-alpha:
> > 
> >> On 03/10/22 16:29, Andreas Schwab wrote:
> >>> On Okt 03 2022, Adhemerval Zanella Netto via Libc-alpha wrote:
> >>>
> >>>> I think NEWS entry usually reference to glibc with an article ('The glibc').
> >>>
> >>> glibc is a proper name, and proper names don't come with articles.  You
> >>> can write "the GNU C library", but not "the glibc".
> >>>
> >>
> >> Which would be the best option for the NEWS entry, just 'glibc' or a
> >> more specific 'The GNU C library'?  I don't have a strong opinion here.
> > 
> > “The GNU C library” at the start of a sentence, otherwise glibc is
> > also okay.  In this case, you could use “The dynamic linker” or “The
> > glibc dynamic linker”.
> 
> Javier, are you ok with:
> 
>   The dynamic linker no longer loads shared objects from the "tls" 
>   subdirectories on the library search path or the subdirectory 
>   that corresponds to the AT_PLATFORM system name, or employs the 
>   legacy AT_HWCAP search mechanism, which was deprecated in version 
>   2.33.

Sure, I am fine with whatever you think is best.

> If so I can wrap-up the patches and push upstream for you.

Thank you.

Regards,
Javier
  
Adhemerval Zanella Netto Oct. 6, 2022, 11:03 a.m. UTC | #7
On 05/10/22 15:12, Javier Pello wrote:
> On Tue, 4 Oct 2022 15:00:33 -0300 Adhemerval Zanella Netto wrote:
> 
>> On 03/10/22 16:59, Florian Weimer wrote:
>>> * Adhemerval Zanella Netto via Libc-alpha:
>>>
>>>> On 03/10/22 16:29, Andreas Schwab wrote:
>>>>> On Okt 03 2022, Adhemerval Zanella Netto via Libc-alpha wrote:
>>>>>
>>>>>> I think NEWS entry usually reference to glibc with an article ('The glibc').
>>>>>
>>>>> glibc is a proper name, and proper names don't come with articles.  You
>>>>> can write "the GNU C library", but not "the glibc".
>>>>>
>>>>
>>>> Which would be the best option for the NEWS entry, just 'glibc' or a
>>>> more specific 'The GNU C library'?  I don't have a strong opinion here.
>>>
>>> “The GNU C library” at the start of a sentence, otherwise glibc is
>>> also okay.  In this case, you could use “The dynamic linker” or “The
>>> glibc dynamic linker”.
>>
>> Javier, are you ok with:
>>
>>   The dynamic linker no longer loads shared objects from the "tls" 
>>   subdirectories on the library search path or the subdirectory 
>>   that corresponds to the AT_PLATFORM system name, or employs the 
>>   legacy AT_HWCAP search mechanism, which was deprecated in version 
>>   2.33.
> 
> Sure, I am fine with whatever you think is best.
> 
>> If so I can wrap-up the patches and push upstream for you.
> 
> Thank you.

Done.
  

Patch

diff --git a/NEWS b/NEWS
index ef274d1a..dbb48914 100644
--- a/NEWS
+++ b/NEWS
@@ -13,7 +13,10 @@  Major new features:
 
 Deprecated and removed features, and other changes affecting compatibility:
 
-  [Add deprecations, removals and changes affecting compatibility here]
+* glibc no longer loads shared objects from the "tls" subdirectories on the
+  library search path or the subdirectory that corresponds to the AT_PLATFORM
+  system name, or employs the legacy AT_HWCAP search mechanism, which was
+  deprecated in version 2.33.
 
 Changes to build and runtime requirements: