From patchwork Fri Jul 22 21:35:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Cristian_Rodr=C3=ADguez?= X-Patchwork-Id: 56275 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC4443858015 for ; Fri, 22 Jul 2022 21:35:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC4443858015 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1658525728; bh=3evcrc7w9TeEeswu/hSQ8l4kugYQxqSnMf60EgfJTHk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=VSWKW6JNnMtSy+z45078eD0y6s50GfFpxYIzGySH0kikamFg1ldHlpc/lUBtOU5JP wNSnZ6iM1C3LNsVjKzVszDgPGfJjyTXVR0CGSYTP91EBAbNmDEbBkJFQHHqqH0C2iU GB8tBGrAbmZ+TN7LZOCkCF6c+PU+PgMoIexv6wC8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by sourceware.org (Postfix) with ESMTPS id AA1C0385828D for ; Fri, 22 Jul 2022 21:35:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA1C0385828D Received: by mail-oi1-f171.google.com with SMTP id i126so6944807oih.4 for ; Fri, 22 Jul 2022 14:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3evcrc7w9TeEeswu/hSQ8l4kugYQxqSnMf60EgfJTHk=; b=WnFvQjiFDM5m6RzIvjyrGB7PFb9jF+GO+tnhGUw7W4Ht7KblNE3agaHLOkq2LokxT/ PBN836H5Jnd9OGRI5jeyd8AxXN0TERZnsBgVglYDgbTfgHseAFq1stvec8vAsZ931fXc Uf6r9JMMU0QYa7ho8BGpaa3FmmAyEIhmrsEzOGFklQgMR84Eqj3+121Zyzb4hmJuwFht bUWGjgW6GFe41qrxaMViuPu7cDZzKyOJD1woFapojgog2v5FsOkkxYlvtExUpA3GhyaF V3WBm13I17p0Qjts1jtastLiusggrYbEo4mQ72+KwoVEPgM+mq9tIpaG7+lNIdfct32z orBA== X-Gm-Message-State: AJIora+gJq2DXu1dbese4r9OTyB348ppCSsbVt6Xg1JtRal4eOXhHk5o FYt6lhBZYEIfqdhKdS/02gkx41ImPM4= X-Google-Smtp-Source: AGRyM1s/sWiIM9nnl775W2An6w2CpGAXLvBIjHK6UxI52ha+brFFSM6KbiMeTrf+vFzHVA364/GK7g== X-Received: by 2002:a05:6808:10d4:b0:33a:baf0:338c with SMTP id s20-20020a05680810d400b0033abaf0338cmr795671ois.4.1658525705643; Fri, 22 Jul 2022 14:35:05 -0700 (PDT) Received: from tumbleweedvm.. ([181.160.1.56]) by smtp.gmail.com with ESMTPSA id s6-20020a0568080b0600b0033a6939436bsm2217983oij.9.2022.07.22.14.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 14:35:05 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] [V2] resolv: use arc4random_uniform in the generation of random ids Date: Fri, 22 Jul 2022 21:35:01 +0000 Message-Id: <20220722213501.32506-1-crrodriguez@opensuse.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Cristian_Rodr=C3=ADguez_via_Libc-alpha?= From: =?utf-8?q?Cristian_Rodr=C3=ADguez?= Reply-To: =?utf-8?q?Cristian_Rodr=C3=ADguez?= Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" In the context of DNS it is important to have highest possible quality ids. v2: fix off by one calculation of upper limit, suggested by Florian. Signed-off-by: Cristian Rodríguez --- resolv/res_mkquery.c | 3 +-- resolv/res_randomid.c | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/resolv/res_mkquery.c b/resolv/res_mkquery.c index 5bc5b41531..066ee2c97e 100644 --- a/resolv/res_mkquery.c +++ b/resolv/res_mkquery.c @@ -93,7 +93,6 @@ #include #include #include -#include int __res_context_mkquery (struct resolv_context *ctx, int op, const char *dname, @@ -116,7 +115,7 @@ __res_context_mkquery (struct resolv_context *ctx, int op, const char *dname, /* We randomize the IDs every time. The old code just incremented by one after the initial randomization which still predictable if the application does multiple requests. */ - hp->id = random_bits (); + hp->id = res_randomid (); hp->opcode = op; if (ctx->resp->options & RES_TRUSTAD) hp->ad = 1; diff --git a/resolv/res_randomid.c b/resolv/res_randomid.c index fb1fa17539..b6211686c0 100644 --- a/resolv/res_randomid.c +++ b/resolv/res_randomid.c @@ -84,10 +84,10 @@ #include #include -#include +#include unsigned int res_randomid (void) { - return 0xffff & random_bits (); + return arc4random_uniform (UINT16_MAX + 1); } libc_hidden_def (__res_randomid)