diff mbox series

i386: Remove -Wa,-mtune=i686

Message ID 20220712000340.2573708-1-maskray@google.com
State Committed
Commit c5bec9d491c5d066dd238ccafcdec78cd4592e8e
Headers
Series i386: Remove -Wa,-mtune=i686 |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Fangrui Song July 12, 2022, 12:03 a.m. UTC 
  gas -mtune= may change NOP generating patterns but -mtune=i686 has no
difference from the default by inspecting .o and .os files.

Note: Clang doesn't support -Wa,-mtune=i686.
---
 sysdeps/i386/i686/Makefile | 10 ----------
 1 file changed, 10 deletions(-)

Comments

H.J. Lu July 12, 2022, 2:42 p.m. UTC | #1 
On Mon, Jul 11, 2022 at 5:03 PM Fangrui Song <maskray@google.com> wrote:
>
> gas -mtune= may change NOP generating patterns but -mtune=i686 has no
> difference from the default by inspecting .o and .os files.
>
> Note: Clang doesn't support -Wa,-mtune=i686.
> ---
>  sysdeps/i386/i686/Makefile | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/sysdeps/i386/i686/Makefile b/sysdeps/i386/i686/Makefile
> index 311042787b..6b5fc8a59c 100644
> --- a/sysdeps/i386/i686/Makefile
> +++ b/sysdeps/i386/i686/Makefile
> @@ -1,12 +1,2 @@
>  # So that we can test __m128's alignment
>  stack-align-test-flags += -msse
> -
> -CFLAGS-.o += -Wa,-mtune=i686
> -CFLAGS-.os += -Wa,-mtune=i686
> -CFLAGS-.op += -Wa,-mtune=i686
> -CFLAGS-.oS += -Wa,-mtune=i686
> -
> -ASFLAGS-.o += -Wa,-mtune=i686
> -ASFLAGS-.os += -Wa,-mtune=i686
> -ASFLAGS-.op += -Wa,-mtune=i686
> -ASFLAGS-.oS += -Wa,-mtune=i686
> --
> 2.37.0.144.g8ac04bfd2-goog
>

LGTM.

Thanks.
diff mbox series

Patch

diff --git a/sysdeps/i386/i686/Makefile b/sysdeps/i386/i686/Makefile
index 311042787b..6b5fc8a59c 100644
--- a/sysdeps/i386/i686/Makefile
+++ b/sysdeps/i386/i686/Makefile
@@ -1,12 +1,2 @@ 
 # So that we can test __m128's alignment
 stack-align-test-flags += -msse
-
-CFLAGS-.o += -Wa,-mtune=i686
-CFLAGS-.os += -Wa,-mtune=i686
-CFLAGS-.op += -Wa,-mtune=i686
-CFLAGS-.oS += -Wa,-mtune=i686
-
-ASFLAGS-.o += -Wa,-mtune=i686
-ASFLAGS-.os += -Wa,-mtune=i686
-ASFLAGS-.op += -Wa,-mtune=i686
-ASFLAGS-.oS += -Wa,-mtune=i686