From patchwork Fri Jun 24 06:36:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 55354 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11DA03854160 for ; Fri, 24 Jun 2022 06:38:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11DA03854160 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656052715; bh=6EnPKop1CBSRz1svpdhhdDPlOYFtjlbHAjK0Hk7EPJs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=my37Wtrz99dmKvKuV1VroDKJltiaQ35Szct6CQx5cdQAVvNg6eR0PWbsp7zzb2Het faCCdSaZuWs9CwkHvE40IzuAC18SW0Ld8auf1/im772E8vGK9ylI29s55ZIWOYcb11 COo5NNWS7IpoHfWwSZ0QpN127nLCoITTXq377ihQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 50A74385AE40 for ; Fri, 24 Jun 2022 06:37:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 50A74385AE40 Received: by mail-pj1-x102a.google.com with SMTP id l2so675550pjf.1 for ; Thu, 23 Jun 2022 23:37:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6EnPKop1CBSRz1svpdhhdDPlOYFtjlbHAjK0Hk7EPJs=; b=Xzkygwb9w0TlF4nRYBFa3YCcm291pszRDasMZnS9bt6P50Jx98WlrPeSt38X5vpC/e 33gv/6Cf3rlA1MekP+M1yGSm1Zr5gS6VKK1W9hHU+EgKpHTrsRwUhNLdRWjUZyABfG6A vF12JjAa5IQmOVJ37dbFByvhmSQX55hKuCeR3kddo0P2ARwDJfRO4CzX6VnLCSYx4WjQ lqA1QuCxfdB2/I9BstOZbb8ioaUR/LBm+Me3n70TfDawijclEB15tWimuqxjcQhWK5gg 9IKg6hPt9NQbdrzIRdgO2oulKiggo9DpU68G9nYbxRsWwkVZONqcG6H+YDBBd+dBsdNy K42g== X-Gm-Message-State: AJIora/CXn+QB0oWG1pv4o2aKy/GwchVQlsRi0S6XQ5RJnL9C3xr4qSc v+aHY48QfgYHukartxg5+31CCGz3WIRgww== X-Google-Smtp-Source: AGRyM1vK7ejiX5TEQ7q/drnVd5R34ovpqjVWEQlpYcStkIXriO1604G3UTPbdK3O44FIO9xq2p3jvQ== X-Received: by 2002:a17:902:ebcb:b0:168:e3ba:4b5a with SMTP id p11-20020a170902ebcb00b00168e3ba4b5amr42718548plg.11.1656052674124; Thu, 23 Jun 2022 23:37:54 -0700 (PDT) Received: from noah-tgl.. (c-73-231-94-136.hsd1.ca.comcast.net. [73.231.94.136]) by smtp.gmail.com with ESMTPSA id 71-20020a63034a000000b0040d2d9f15e0sm756682pgd.20.2022.06.23.23.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 23:37:53 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v1 1/7] x86: Align entry for memrchr to 64-bytes. Date: Thu, 23 Jun 2022 23:36:48 -0700 Message-Id: <20220624063653.2126416-1-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The function was tuned around 64-byte entry alignment and performs better for all sizes with it. As well different code boths where explicitly written to touch the minimum number of cache line i.e sizes <= 32 touch only the entry cache line. --- Tested with: for march in "--disable-multi-arch" ""; do for ISA in "-march=x86-64-v4" "-march=x86-64-v3" "" "-march=x86-64-v2"; do echo "START: ${ISA} - $march"; rm -rf glibc-dev/build; mkdir -p glibc-dev/build/glibc/; (cd glibc-dev/build/glibc/; unset LD_LIBRARY_PATH; glibc-dev/src/glibc/configure --prefix=/usr CC="gcc ${ISA}" $march; make -j7 --silent; make -r -C glibc-dev/src/glibc/string/ objdir=`pwd` check; make -r -C glibc-dev/src/glibc/wcsmbs/ objdir=`pwd` check;); echo "DONE: ${ISA} - $march"; objdump -d build/glibc/string/memchr.o; objdump -d build/glibc/string/rawmemchr.o; objdump -d build/glibc/wcsmbs/wmemchr.o; cat build/glibc/string/test-memchr.out; cat build/glibc/string/test-memchr.test-result; cat build/glibc/string/test-rawmemchr.out; cat build/glibc/string/test-rawmemchr.test-result; cat build/glibc/wcsmbs/test-wmemchr.out; cat build/glibc/wcsmbs/test-wmemchr.test-result; done; done for march in "" "--disable-multi-arch"; do rm -rf build; mkdir -p build/glibc; (cd glibc-dev/build/glibc/; unset LD_LIBRARY_PATH; glibc-dev/src/glibc/configure CC="gcc -m32" CXX="g++ -m32" --prefix=/usr --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu $march; make -j7 --silent;) done (cd glibc-dev/build/glibc/; unset LD_LIBRARY_PATH; glibc-dev/src/glibc/configure --prefix=/usr; make -j7 --silent; make -j7 check --silent); 5155 PASS 19 UNSUPPORTED 18 XFAIL 4 XPASS sysdeps/x86_64/multiarch/memrchr-avx2.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/x86_64/multiarch/memrchr-avx2.S b/sysdeps/x86_64/multiarch/memrchr-avx2.S index 9c83c76d3c..f300d7daf4 100644 --- a/sysdeps/x86_64/multiarch/memrchr-avx2.S +++ b/sysdeps/x86_64/multiarch/memrchr-avx2.S @@ -35,7 +35,7 @@ # define VEC_SIZE 32 # define PAGE_SIZE 4096 .section SECTION(.text), "ax", @progbits -ENTRY(MEMRCHR) +ENTRY_P2ALIGN(MEMRCHR, 6) # ifdef __ILP32__ /* Clear upper bits. */ and %RDX_LP, %RDX_LP