From patchwork Thu May 26 16:49:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 54418 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77AC93836675 for ; Thu, 26 May 2022 16:57:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77AC93836675 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1653584220; bh=2eXxHf8KN28baSKYoD8TjVXeq+l+S9f9VDSGbtdcRgc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=TJhurCWjR7MIS4aehN3GO+OzexMLS/OfoDT+dEje4znJNbL0GvU9Tkld8LsyEGBI7 GXBfFkuxHHFq6vDzXJ8ZURPg8egepjdLX8+Wx5RHZvM7KDqSEgkxTnIWTJdIgF9rrq zlQCM1xLGawpj6gWYZqW2GKrIjV1evILO5eNzyjs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id 115E838376FD for ; Thu, 26 May 2022 16:50:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 115E838376FD Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-f2c8c0d5bdso2859533fac.4 for ; Thu, 26 May 2022 09:50:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2eXxHf8KN28baSKYoD8TjVXeq+l+S9f9VDSGbtdcRgc=; b=Dom3sSReQbPG+OEWCqdHgQ3qSYfj+CQvPhc80C+ETM2pao+pofec+6Y+StGKL/dskw Axfc/PtCjjaq5RgDoTCQ5TP/SMMcNqOXC148vVViuvb+yPXbXYLk1+aJNwXn6qJ69uhA gWpNRvVFCfRtKUFDv0OFgUlKST7sqBAsET2dh1W06plcBYhgGLiXAKBJ8lpf/6dpalCe E88AiZTNQZM+E3yXVIWSm13HW1+8CqONKgXT47/3P1vvy6toI2I7y7FGmsdzSAHLt/YJ HcBlTc/q5Z9xoZtvNv/ub/jMQyaRvQBzD7R1tgpdC591KzyAJBOUdvhbrYpHeTlugdpY /9Zw== X-Gm-Message-State: AOAM530nwsqpksSwR7DYqxCvfnFtAjaxiyEbNbZbNkRNU21tFNQSppgG wRt5glo0XLMhQY1NwnJAF5m6DBUhMy/X9g== X-Google-Smtp-Source: ABdhPJyXBGPOCJ3sJ56nQvQ/gv9lrM4H4/cGxQUWcWXyJolnaDZui5QADkJwtY5Y7E19W9YvirypBg== X-Received: by 2002:a05:6870:58a4:b0:f2:2720:884d with SMTP id be36-20020a05687058a400b000f22720884dmr1793301oab.13.1653583821171; Thu, 26 May 2022 09:50:21 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:9f85:b1e1:5370:63bd:a2ac]) by smtp.gmail.com with ESMTPSA id y26-20020a9d461a000000b0060603221255sm802521ote.37.2022.05.26.09.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:50:20 -0700 (PDT) To: libc-alpha@sourceware.org, Szabolcs Nagy Subject: [PATCH 09/17] microblaze: Remove _dl_skip_args usage Date: Thu, 26 May 2022 13:49:55 -0300 Message-Id: <20220526165003.705355-10-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220526165003.705355-1-adhemerval.zanella@linaro.org> References: <20220526165003.705355-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Since ad43cac44a the generic code already shuffles the argv/envp/auxv on the stack to remove the ld.so own arguments and thus _dl_skip_args is always 0. So there is no need to adjust the argc or argv. Checked with qemu-user that arguments are correctly passed on both constructors and main program. --- sysdeps/microblaze/dl-machine.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sysdeps/microblaze/dl-machine.h b/sysdeps/microblaze/dl-machine.h index fd996d6ff1..e6e4e13fa2 100644 --- a/sysdeps/microblaze/dl-machine.h +++ b/sysdeps/microblaze/dl-machine.h @@ -117,12 +117,7 @@ _start:\n\ _dl_start_user:\n\ mfs r20,rpc\n\ addik r20,r20,_GLOBAL_OFFSET_TABLE_+8\n\ - lwi r4,r20,_dl_skip_args@GOTOFF\n\ lwi r5,r1,24\n\ - rsubk r5,r4,r5\n\ - addk r4,r4,r4\n\ - addk r4,r4,r4\n\ - addk r1,r1,r4\n\ swi r5,r1,24\n\ swi r3,r1,20\n\ addk r6,r5,r0\n\