From patchwork Wed Mar 30 05:07:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 52465 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F372F385AC22 for ; Wed, 30 Mar 2022 05:07:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F372F385AC22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648616878; bh=x4FWaRRqt0MJUP/usp/y9xIh4RJtPJ7UQbxMu0BFgrM=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mnFL4mf11ERQpAkygCIj7wrvcfIWx/VMv272A6wqKPF3UJzWUWTbqsEeTYk/krvTP BUUggODcHqiPq+r4smJczJrFJ0oxLv1nq7QVqlaSx9MRR9wmLG0MCgDQLz1dDgl+Dk 2vbsSYsm1NFYvVjqjSUsylg3OVQ75J43zfrQiMTE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id 66A3B3858C50 for ; Wed, 30 Mar 2022 05:07:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66A3B3858C50 Received: by mail-yb1-xb4a.google.com with SMTP id a12-20020a25938c000000b0063467614126so14887822ybm.13 for ; Tue, 29 Mar 2022 22:07:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=x4FWaRRqt0MJUP/usp/y9xIh4RJtPJ7UQbxMu0BFgrM=; b=ewm2fZUin21c5hqxq928baI5wPfbLb5MxpLA90bnA7/8fDj5WsJQUXCyRfFogL1nIN 74TnIhR7GN7VqG/z63xvX8WaffwBThI1c4F14uf8HDl2nONUEzcf+0EhjU1MNKOGdLuO ggnPmLXEORN3m+KSBFwkb0ZvShBNm0TZk6Wc57z05Vv6diTPdiJHe2+lwkjT0An6ZGaW 9g+T1gGRYq2qFXxh+mKlyLQAXLd0Dv5+gied9dY3FV8qRVGuqFk/SlwIJWsNDYEYE7B3 jbHPBoxZQSpd4WrL4TC3Cpu0h4NQoBAqOWLhQvUTxF9WSHqgv9UhampUBwxzXYXCz9P3 nQgA== X-Gm-Message-State: AOAM5320VgR55oNmQ8/GRIzPnsEzYMvphrC9Di+7Zh3oAlHfn1D/kZhH f9wokbCd4YDPn1bG84OizV4vbki2InfbQucuAymhMhKe0AMnziigjJLxT366tSdtBqNJBNIfOov /GSWBKHjulmPdfVqP2+nAfAXHWasiuSP2zoVU/6TkJ9mAD5fHu1YO3BJMzp1USn7i55EK X-Google-Smtp-Source: ABdhPJzrZJostPsS5d1W0AwCkAFp20jqHCvWIjHoJQHzTvgBch4Ch0rD5RWKzJSIwll9YJ8YYG5JNx9frKNL X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:925f:e947:f685:7815]) (user=maskray job=sendgmr) by 2002:a5b:f8d:0:b0:628:620c:a45f with SMTP id q13-20020a5b0f8d000000b00628620ca45fmr29380192ybh.17.1648616852764; Tue, 29 Mar 2022 22:07:32 -0700 (PDT) Date: Tue, 29 Mar 2022 22:07:29 -0700 Message-Id: <20220330050729.2176630-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH] Remove fno-unit-at-a-time make variable To: libc-alpha@sourceware.org, Adhemerval Zanella X-Spam-Status: No, score=-19.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Libc-alpha From: Fangrui Song Reply-To: Fangrui Song Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" 795985e4e751 in 2003 added -fno-unit-at-a-time to errlist.c and siglist.c to "avoid reordering assembler output". -fno-toplevel-reorder is a rough replacement for this legacy option (https://sourceware.org/pipermail/gcc-patches/2006-January/186801.html). The reordering requirement does not seem to be needed any longer. --- config.make.in | 1 - configure | 32 -------------------------------- configure.ac | 19 ------------------- stdio-common/Makefile | 2 -- 4 files changed, 54 deletions(-) diff --git a/config.make.in b/config.make.in index 6d43e691f7..ecde84a7da 100644 --- a/config.make.in +++ b/config.make.in @@ -69,7 +69,6 @@ have-selinux = @have_selinux@ have-libaudit = @have_libaudit@ have-libcap = @have_libcap@ have-cc-with-libunwind = @libc_cv_cc_with_libunwind@ -fno-unit-at-a-time = @fno_unit_at_a_time@ bind-now = @bindnow@ have-hash-style = @libc_cv_hashstyle@ use-default-link = @use_default_link@ diff --git a/configure b/configure index 2a3cb49b0b..f836874a58 100755 --- a/configure +++ b/configure @@ -620,7 +620,6 @@ libc_cv_cc_loop_to_function libc_cv_cc_submachine libc_cv_cc_nofma libc_cv_mtls_dialect_gnu2 -fno_unit_at_a_time libc_cv_has_glob_dat libc_cv_hashstyle libc_cv_fpie @@ -6319,37 +6318,6 @@ fi $as_echo "$libc_cv_has_glob_dat" >&6; } -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for -fno-toplevel-reorder -fno-section-anchors" >&5 -$as_echo_n "checking for -fno-toplevel-reorder -fno-section-anchors... " >&6; } -if ${libc_cv_fno_toplevel_reorder+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat > conftest.c <&5 - (eval $ac_try) 2>&5 - ac_status=$? - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 - test $ac_status = 0; }; } -then - libc_cv_fno_toplevel_reorder=yes -else - libc_cv_fno_toplevel_reorder=no -fi -rm -f conftest* -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_fno_toplevel_reorder" >&5 -$as_echo "$libc_cv_fno_toplevel_reorder" >&6; } -if test $libc_cv_fno_toplevel_reorder = yes; then - fno_unit_at_a_time="-fno-toplevel-reorder -fno-section-anchors" -else - fno_unit_at_a_time=-fno-unit-at-a-time -fi - - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -mtls-dialect=gnu2" >&5 $as_echo_n "checking for -mtls-dialect=gnu2... " >&6; } if ${libc_cv_mtls_dialect_gnu2+:} false; then : diff --git a/configure.ac b/configure.ac index fa7d3c025b..ec1db36d46 100644 --- a/configure.ac +++ b/configure.ac @@ -1478,25 +1478,6 @@ fi rm -f conftest*]) AC_SUBST(libc_cv_has_glob_dat) -AC_CACHE_CHECK(for -fno-toplevel-reorder -fno-section-anchors, libc_cv_fno_toplevel_reorder, [dnl -cat > conftest.c <&AS_MESSAGE_LOG_FD]) -then - libc_cv_fno_toplevel_reorder=yes -else - libc_cv_fno_toplevel_reorder=no -fi -rm -f conftest*]) -if test $libc_cv_fno_toplevel_reorder = yes; then - fno_unit_at_a_time="-fno-toplevel-reorder -fno-section-anchors" -else - fno_unit_at_a_time=-fno-unit-at-a-time -fi -AC_SUBST(fno_unit_at_a_time) - AC_CACHE_CHECK([for -mtls-dialect=gnu2], libc_cv_mtls_dialect_gnu2, [dnl cat > conftest.c <