From patchwork Wed Mar 23 21:57:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 52279 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DE47388883F for ; Wed, 23 Mar 2022 22:06:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DE47388883F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648073199; bh=/xXMCs40j/4UtA3ybXLKKcPg0goUStgzesipQ/XP8xM=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DKk1IupqAt62oHI27eV/PKyomtkvNoc3DgTjT3DQMgJPkDAKtVCj5/JkkhW5sk9aS 01JFEKoWePNxo4hxgUlKVW973jHbsgNRkNPxLPkUH3oVxDUXU7QXGi3GNmjnvMLi4p 5PKaRAo5FHsJoSuFItL+is82JI5BLbX9BGms7/DM= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 184383888838 for ; Wed, 23 Mar 2022 22:01:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 184383888838 Received: by mail-io1-xd2f.google.com with SMTP id d62so3373670iog.13 for ; Wed, 23 Mar 2022 15:01:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/xXMCs40j/4UtA3ybXLKKcPg0goUStgzesipQ/XP8xM=; b=63jm0vdFQPZ7NLu4x56tE8/EY8VIu4ja/+ZyhYQZPuGJqIvBFUmooDpq/giDx6InTi +8QJN9WXXgSIeF8sK/WelWPyXcf2I6SqRvCtixu1KeFglkRxm2fGc7booJUQO/yj6GRI 4zSGMLbSM2On2Vov+9077OABGQC4qUNK7lgu/xF1YJFszBhHEnFrCoteStnGpNdQ/XYl XwMSocS6ibZqLjEimOWE1O7W8IXUbrmAEmmbyHGXoaGvwAtbp7X0NFLN6MxtD+Y6iKvV erPOVHePOX9/cH/ED2rkrdw/YQzwVf8CogTUTulmDY3HM7YTVLHYTlbCb1ebH+halxok 8vXg== X-Gm-Message-State: AOAM530dLuROvrTgxdvkgxKbatB0iz3vOUcjPvGOCUmFY7iPTAkpcgWA 3rSVp+Rjz3BZ2yEWdPXhXfDIJFSttRc= X-Google-Smtp-Source: ABdhPJz+lgXKAOe8WGKI6k/aE5TabvStF0ahbaewQ3u+SAonwCuXkykgQBsSE3N8E+3vr97L0ultHw== X-Received: by 2002:a05:6602:22da:b0:645:ec83:6393 with SMTP id e26-20020a05660222da00b00645ec836393mr1132894ioe.165.1648072866267; Wed, 23 Mar 2022 15:01:06 -0700 (PDT) Received: from localhost.localdomain (node-17-161.flex.volo.net. [76.191.17.161]) by smtp.googlemail.com with ESMTPSA id c22-20020a5ea816000000b00649d360663asm529227ioa.40.2022.03.23.15.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 15:01:05 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v1 12/23] x86: Fix fallback for wcsncmp_avx2 in strcmp-avx2.S [BZ #28896] Date: Wed, 23 Mar 2022 16:57:30 -0500 Message-Id: <20220323215734.3927131-12-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220323215734.3927131-1-goldstein.w.n@gmail.com> References: <20220323215734.3927131-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Overflow case for __wcsncmp_avx2_rtm should be __wcscmp_avx2_rtm not __wcscmp_avx2. All string/memory tests pass. --- sysdeps/x86_64/multiarch/strcmp-avx2.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/x86_64/multiarch/strcmp-avx2.S b/sysdeps/x86_64/multiarch/strcmp-avx2.S index 52ff5ad724..86a86b68e3 100644 --- a/sysdeps/x86_64/multiarch/strcmp-avx2.S +++ b/sysdeps/x86_64/multiarch/strcmp-avx2.S @@ -122,7 +122,7 @@ ENTRY(STRCMP) are cases where length is large enough that it can never be a bound on valid memory so just use wcscmp. */ shrq $56, %rcx - jnz __wcscmp_avx2 + jnz OVERFLOW_STRCMP leaq (, %rdx, 4), %rdx # endif