From patchwork Wed Mar 23 18:32:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 52262 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B20F3888838 for ; Wed, 23 Mar 2022 18:33:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B20F3888838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648060402; bh=2yFkg2KG7P4N18r2qFY4ua5U6mFch8SbIxfZJVwT/rw=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=rJQoG+8HtZEKRD0CC73Jyt5UqYwEE1hnpSAkFobQRyEQWS6u5gBmmkbWmV//kfTUj ZF9xbFQhBCeXGkRUSCztYI5wMtjrkzHFtEiQyUHlKWaIyRBbJpYlLvOgAsrSNOr6na lldorsp3DVTTiws1Itl9yG2WIRK4+Be1Nsup9F4s= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 0E24F3853804 for ; Wed, 23 Mar 2022 18:33:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E24F3853804 Received: by mail-ot1-x331.google.com with SMTP id n19-20020a9d7113000000b005cd9cff76c3so1675134otj.1 for ; Wed, 23 Mar 2022 11:33:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=2yFkg2KG7P4N18r2qFY4ua5U6mFch8SbIxfZJVwT/rw=; b=hapNPiQQ2VttG0GszLMQA2qooXt0ZYDtD1i8bdAnzCuYYxe6U8uYrU7dYnTYrT7Ml8 z6gy4EXzplXU/UksGmKEALsQVMSNbSNh+hoZITqLnQCpp1vrfO8L/bOkVwRdsdj/wbGJ DYcW0iX0cz0q1HbaeHqYATxoaa+DaHwSZHAcG/aJcS67qIi9x8LiHAxrMlimsAmeZQLf j/gzlf7aM86sd+Vrjq8Tl7+yCDqB05YdFnnRMbeEo5aEa8zKvTPpvBDOFJjuhyLG8rzc D0Otwro7C/Lrw7VHZpsOSKB3V9ec2ZwJrKjuB4xgrq9VPG/GA4q66w6jRZHINVdp53+a KH7Q== X-Gm-Message-State: AOAM531qJUeXynp3o/QYTKhoDdzWtO2/sjC7Fw5tn14m8i/MUBk+Qq9w 7WAIs4C6iMvP8o+NGN0tbTlIhch/dWUqIg== X-Google-Smtp-Source: ABdhPJwVEb4N8TVlTtJqtmCy/VozSX3JbDpJtt0wy1pUny/KVp4ZkU5VJKssNNVhRi6I9UTmUNE/0w== X-Received: by 2002:a9d:71cc:0:b0:5b2:26d5:951e with SMTP id z12-20020a9d71cc000000b005b226d5951emr583159otj.345.1648060379976; Wed, 23 Mar 2022 11:32:59 -0700 (PDT) Received: from birita.. ([2804:431:c7ca:2d55:7794:d006:fba1:8b8f]) by smtp.gmail.com with ESMTPSA id v8-20020a05683018c800b005cb39fc3e15sm312845ote.13.2022.03.23.11.32.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 11:32:59 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [COMMITTED] support: Fix support_process_state_wait path size calculation Date: Wed, 23 Mar 2022 15:32:56 -0300 Message-Id: <20220323183256.756750-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Use INT_STRLEN_BOUND to proper get the maximum pid_t size. Also fix the wrong calculation (the 3 should multiply the sizeof (pid_t)). Checked on x86_64-linux-gnu. --- support/support_process_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/support/support_process_state.c b/support/support_process_state.c index 0dc608b468..ca86dc11e6 100644 --- a/support/support_process_state.c +++ b/support/support_process_state.c @@ -21,6 +21,7 @@ #include #include +#include #include #include @@ -49,7 +50,7 @@ support_process_state_wait (pid_t pid, enum support_process_state state) { support_process_state_parked, 'P' }, }; - char spath[sizeof ("/proc/" + 3) * sizeof (pid_t) + sizeof ("/status") + 1]; + char spath[sizeof ("/proc/") + INT_STRLEN_BOUND (pid_t) + sizeof ("/status") + 1]; snprintf (spath, sizeof (spath), "/proc/%i/status", pid); FILE *fstatus = xfopen (spath, "r");