From patchwork Fri Feb 25 12:35:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 51396 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A05B23857C5D for ; Fri, 25 Feb 2022 12:37:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A05B23857C5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1645792666; bh=jBXgVh6kM7V4ytu8dlrK41asw8gYrrzCoa+W5NnVvUw=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=A8HUGF7mymS+YJSqx6EaWRN5/T/tmFVtqikPnoyjkfH5jlCaNawjvr4IbOtRAr1iD ye/+E5/uYD7hCEqJ7MGbCABAJTzudQIEM7duwjChMrtx5C44eB3TfUY8I25uwBs6qP LjD39muRcYAcBa+UD9YPANWtXJHg5/RbQMjXbwHQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 615263857C4D for ; Fri, 25 Feb 2022 12:36:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 615263857C4D Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-guX80Mp_POmm4MbDGVWaxQ-1; Fri, 25 Feb 2022 07:36:01 -0500 X-MC-Unique: guX80Mp_POmm4MbDGVWaxQ-1 Received: by mail-il1-f200.google.com with SMTP id i17-20020a925411000000b002bf4c9c4142so3421611ilb.6 for ; Fri, 25 Feb 2022 04:36:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jBXgVh6kM7V4ytu8dlrK41asw8gYrrzCoa+W5NnVvUw=; b=xQAcn2IfKkqajabacw8fSqhAwwFbTQWd9XitHvaZzQLzYoiFlxHS7Yn1Jc5E+UHCs3 j7D25iD6ERoj8kVxEGMfUh2cs3wtR1/p9dUZWkFEXoR84+X2fcqrAQ5ASznEg/P4V05w tAdl4MD9PGI+ZtcLP5TbH7Y6S3vnyiRVWQsk11sn6eJsvzuSfIUGxgEMlr1UMK7moD6z jnbciF3+9tkCUsZXfpHAHKlgln8MSrBERI7lzITk6y8qQL/6kO50cHxHIhIV99bMJ7jp 76XAf8x9ZxbH/VTDf9oH42gp8zB5Mp/DoCU6H73BxZSMJC5jxJkde88EkVQieFYMRXTE eZdw== X-Gm-Message-State: AOAM531hhhQmbWLh2726A8U1QtGb4mr4xgXIEBLvz/ho8DlR+hioGMjf tGLyNDQz4GKQCdeforOYL1OpXWbksVF7O+FheYPpDIXgWi+1fRem5AKuLwDTuu2Utynm6ant0HZ eg4XKdsW08k4XG9wGdwz6t0LNOFszXwXvJdwNfvw4gchReYVrzEL9saFo8J92jnG2Z1FLSQ== X-Received: by 2002:a6b:f215:0:b0:640:7bfd:d9f3 with SMTP id q21-20020a6bf215000000b006407bfdd9f3mr5297221ioh.205.1645792560363; Fri, 25 Feb 2022 04:36:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGx9UOa7m8dyiOYW6qXIDWJYHxliMENQsZgd/wCYoGttAODp9TJ7MyK+sll0CIbxrCeCP+hw== X-Received: by 2002:a6b:f215:0:b0:640:7bfd:d9f3 with SMTP id q21-20020a6bf215000000b006407bfdd9f3mr5297207ioh.205.1645792560147; Fri, 25 Feb 2022 04:36:00 -0800 (PST) Received: from athas.redhat.com (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id a2-20020a056e02120200b002c21a18437csm1535994ilq.40.2022.02.25.04.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 04:35:59 -0800 (PST) To: libc-alpha@sourceware.org Subject: [COMMITTED v3 2/2] localedata: Do not generate output if warnings were present. Date: Fri, 25 Feb 2022 07:35:54 -0500 Message-Id: <20220225123554.964847-3-carlos@redhat.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225123554.964847-1-carlos@redhat.com> References: <20220225123554.964847-1-carlos@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Carlos O'Donell via Libc-alpha From: Carlos O'Donell Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" With LC_MONETARY parsing fixed we can now generate locales without forcing output with '-c'. Removing '-c' from localedef invocation is the equivalent of using -Werror for localedef. The glibc locale sources should always be clean and free from warnings. We remove '-c' from both test locale generation and the targets used for installing locales e.g. install-locale-archive, and install-locale-files. Tested on x86_64 and i686 without regressions. Tested with install-locale-archive target. Tested with install-locale-files target. Reviewed-by: DJ Delorie --- localedata/Makefile | 4 ++-- localedata/gen-locale.sh | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/localedata/Makefile b/localedata/Makefile index 9ae2e5c161..7741ac3b5e 100644 --- a/localedata/Makefile +++ b/localedata/Makefile @@ -468,11 +468,11 @@ define build-one-locale endef $(INSTALL-SUPPORTED-LOCALE-ARCHIVE): install-locales-dir - @flags="-c"; \ + @flags=""; \ $(build-one-locale) $(INSTALL-SUPPORTED-LOCALE-FILES): install-locales-dir - @flags="-c --no-archive --no-hard-links"; \ + @flags="--no-archive --no-hard-links"; \ $(build-one-locale) tst-setlocale-ENV = LC_ALL=ja_JP.EUC-JP diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh index 7fce35f212..8053c816a6 100644 --- a/localedata/gen-locale.sh +++ b/localedata/gen-locale.sh @@ -54,8 +54,14 @@ modifier=`echo $locfile|sed 's|[^.]*[.]\([^@ ]*\)\(@[^ ]*\)\?/LC_CTYPE|\2|'` echo "Generating locale $locale.$charmap: this might take a while..." -# Run quietly and force output. -flags="--quiet -c" +# Do not force output with '-c', all locales should compile without +# warning or errors. There is likewise no need to run quietly with +# '--quiet' since all locales should compile without additional +# diagnostics. If there are messages printed then we want to see +# them, fix them, and the associated error or warning. During +# development it may be beneficialy to put '--quiet -c' here to allow +# you to develop in-progress locales. +flags="" # For SJIS the charmap is SHIFT_JIS. We just want the locale to have # a slightly nicer name instead of using "*.SHIFT_SJIS", but that