From patchwork Sat Feb 5 02:57:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 50823 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFD2C3858423 for ; Sat, 5 Feb 2022 02:58:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFD2C3858423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644029933; bh=m7By2KlYsboZYJsMy0wHQlOMxqHrVysJXqjc6dW7DRM=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mNAwWqC32MjB7vgEDQB/zYmzhN1ogYESbfYlH3Ix5Cew2vzmyfCtBax52IrrB2GO4 J40ulNdzCseBhxDp4lGZUyWXtKWW640ndNw94qOLGImGDvaXnynoXhr8i31m/z2Rp3 rtFQ0tHn9+lEgxywd7CH/4KFHNF34lmr+gIjf+8s= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F32A73858410 for ; Sat, 5 Feb 2022 02:57:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F32A73858410 Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-250-y8ml7-AOP9iKeIO9BTEZKA-1; Fri, 04 Feb 2022 21:57:10 -0500 X-MC-Unique: y8ml7-AOP9iKeIO9BTEZKA-1 Received: by mail-io1-f71.google.com with SMTP id n20-20020a6bed14000000b0060faa0aefd3so5236141iog.20 for ; Fri, 04 Feb 2022 18:57:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m7By2KlYsboZYJsMy0wHQlOMxqHrVysJXqjc6dW7DRM=; b=BirOdRSBhoPjp4XFt03gL34VjyEgyPm/jSdIp9x74tQaUaG5kXUNGZv0COQWPE8ciF 3NnL8kRvmgVyp4dZ/SQ/wUuppslWBdLdBQaQf7E3bx27jB2afPV45JndoWx577IfhRTD CLzSIbK5/XsdZoFY5SAq9nKsEaQyDC99VdG19XpgO5KSrbANc02mD/62tL+f2XarEiA5 wya57E/np9PBSynC3ribkQsYosyPdGLz/F8AUbqGP3BEmjaLbx7fGPVb/OKgJvCK2W+x V1ez/xrnZQvr1o8OBfjpbg3vZ8cjZmCScDh8nkmS1B66R1OuMYs1julGH4CeomE3+gFt BoJg== X-Gm-Message-State: AOAM533/bFZ0C4mehjaKU14AWLHGdBaQVNQxvr0CFe2qKnDpRKHvZ1WX P9SyDrTUNSONrPG+46GGPMWrWVE3Kp/eChkGHThCrEZTxHAyZNZNIydVneXOr0kmBgoWciPmKFc 8fNLu5IiwBI/03irwnJWrY0/GgWFkudYlJNaCZZifi+t3IjAbeOZscfNnZMZpXLSr/qTA3w== X-Received: by 2002:a02:a581:: with SMTP id b1mr1051205jam.36.1644029829760; Fri, 04 Feb 2022 18:57:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHAI3BN5wuhjTlPXEJShXXCtSYZq9FMzO3FAknHPpY2MEtY0FpkGVLtFiHS81dSYL1HtXqzg== X-Received: by 2002:a02:a581:: with SMTP id b1mr1051190jam.36.1644029829529; Fri, 04 Feb 2022 18:57:09 -0800 (PST) Received: from athas.redhat.com (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id g1sm1997577iob.34.2022.02.04.18.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 18:57:08 -0800 (PST) To: libc-alpha@sourceware.org, fweimer@redhat.com Subject: [PATCH 2/2] localedata: Do not generate output if warnings were present. Date: Fri, 4 Feb 2022 21:57:00 -0500 Message-Id: <20220205025700.3728228-3-carlos@redhat.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220205025700.3728228-1-carlos@redhat.com> References: <20220205025700.3728228-1-carlos@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Carlos O'Donell via Libc-alpha From: Carlos O'Donell Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" With LC_MONETARY parsing fixed we can now generate locales without forcing output with '-c'. Removing '-c' from localedef invocation is the equivalent of using -Werror for localedef. The glibc locale sources should always be clean and free from warnings. We remove '-c' from both test locale generation and the targets used for installing locales e.g. install-locale-archive, and install-locale-files. Tested on x86_64 and i686 without regressions. Tested with install-locale-archive target. Tested with install-locale-files target. --- localedata/Makefile | 3 +-- localedata/gen-locale.sh | 10 ++++++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/localedata/Makefile b/localedata/Makefile index 9ae2e5c161..45acfde237 100644 --- a/localedata/Makefile +++ b/localedata/Makefile @@ -468,11 +468,10 @@ define build-one-locale endef $(INSTALL-SUPPORTED-LOCALE-ARCHIVE): install-locales-dir - @flags="-c"; \ $(build-one-locale) $(INSTALL-SUPPORTED-LOCALE-FILES): install-locales-dir - @flags="-c --no-archive --no-hard-links"; \ + @flags="--no-archive --no-hard-links"; \ $(build-one-locale) tst-setlocale-ENV = LC_ALL=ja_JP.EUC-JP diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh index 7fce35f212..8053c816a6 100644 --- a/localedata/gen-locale.sh +++ b/localedata/gen-locale.sh @@ -54,8 +54,14 @@ modifier=`echo $locfile|sed 's|[^.]*[.]\([^@ ]*\)\(@[^ ]*\)\?/LC_CTYPE|\2|'` echo "Generating locale $locale.$charmap: this might take a while..." -# Run quietly and force output. -flags="--quiet -c" +# Do not force output with '-c', all locales should compile without +# warning or errors. There is likewise no need to run quietly with +# '--quiet' since all locales should compile without additional +# diagnostics. If there are messages printed then we want to see +# them, fix them, and the associated error or warning. During +# development it may be beneficialy to put '--quiet -c' here to allow +# you to develop in-progress locales. +flags="" # For SJIS the charmap is SHIFT_JIS. We just want the locale to have # a slightly nicer name instead of using "*.SHIFT_SJIS", but that