From patchwork Sat Jan 8 07:00:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 49751 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DCA683857832 for ; Sat, 8 Jan 2022 07:00:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCA683857832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641625236; bh=y020AvJF/WfRFXPKCKOrUevA4C8h5BrVdq83crajsjs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=OF4SoULEG7NFDsAX5PYrU6AGA12nzyQCFVqgDAuKuj4YCGpWsUEQv1xD9ZFyfeOlH fbHBxx5VAWqV0oTxb6JWYhpesoVH4Z2A2VtuSKsQD5GkPsgRalOzRroowpGrET0xbb k9FyF9iK3qHnpLESUCrexTL75zXFMNMyjsna1LZg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 3FFF83858421 for ; Sat, 8 Jan 2022 07:00:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FFF83858421 Received: by mail-pj1-x1029.google.com with SMTP id oa15so6265842pjb.4 for ; Fri, 07 Jan 2022 23:00:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y020AvJF/WfRFXPKCKOrUevA4C8h5BrVdq83crajsjs=; b=XH7SKF2l+NrHeTV6ctwPZ+dnr5+sFccN6YRBGqdgh+iQA/7iEF5Ivsq3lEQ7QyLv7c Yy6zCCEDPEKk3k5CLV811SZx5WmdWjOIiEUMrEHJXRyXT9KfHtLCFuvxCCX8MG7L59BO read2FDi09cEcEHCVK3lC5qoMRzHelBcA8ubryvahx+wudIYbNboQK6Ytj5gKc7q5+rR Ojj9SrmyNGxieHN9ySazvlnwGd1UDs0dLbXV9T3cAP2/qQ9+dAeAWk53PUEZ7t06IzwZ muSJgl8nMPDr8cCHfRBpRIGpFXXUxVII/UnWJwaRuKjV+PZ5jjvBmAnz+DvQpKkkc1ai VK5Q== X-Gm-Message-State: AOAM532d6Y1lGI/jfSezKKQY8OiVH3sIwFT+FeXfyDJPZOXpmLbmpB6N ibxWcaGRpQC/bVyNNNt116w9d4HcmOc= X-Google-Smtp-Source: ABdhPJzOvoagMlUhBm2TM1dqenouC8SbctiXPSgO1VjtOezWh5q3bjW8V9m13E1ERMD0gYDxiS+Nww== X-Received: by 2002:a17:90a:8b18:: with SMTP id y24mr19188654pjn.26.1641625214026; Fri, 07 Jan 2022 23:00:14 -0800 (PST) Received: from localhost ([2409:10:24a0:4700:e8ad:216a:2a9d:6d0c]) by smtp.gmail.com with ESMTPSA id j1sm963237pfc.49.2022.01.07.23.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 23:00:13 -0800 (PST) To: GLIBC patches Subject: [RFC PATCH] elf: Fix link error missing Unwind_Backtrace symbol Date: Sat, 8 Jan 2022 16:00:09 +0900 Message-Id: <20220108070009.3104695-1-shorne@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Stafford Horne via Libc-alpha From: Stafford Horne Reply-To: Stafford Horne Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" --- For some reason build many is failing with missing Unwind_Backtrace symbol when linking tst-unwind-ctor-lib.so. or1k-glibc-linux-gnu-gcc -shared -static-libgcc -Wl,-dynamic-linker=/lib/ld-linux-or1k.so.1 -Wl,-z,defs -B/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/csu/ -Wl,-z,combreloc -Wl,-z,relro -Wl,--hash-style=both -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/math -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/elf -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/dlfcn -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/nss -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/nis -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/rt -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/resolv -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/mathvec -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/crypt -L/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/nptl -Wl,-rpath-link=/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/math:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/elf:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/dlfcn:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/nss:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/nis:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/rt:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/resolv:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/mathvec:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/support:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/crypt:/home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/nptl -o /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/elf/tst-unwind-ctor-lib.so -T /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/shlib.lds /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/csu/abi-note.o /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/elf/tst-unwind-ctor-lib.os -Wl,--start-group /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/libc.so /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/libc_nonshared.a -Wl,--as-needed /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/elf/ld.so -Wl,--no-as-needed -Wl,--end-group /home/shorne/work/gnu-toolchain/build-many/install/compilers/or1k-linux-gnu/lib/gcc/or1k-glibc-linux-gnu/12.0.0/../../../../or1k-glibc-linux-gnu/bin/ld: /home/shorne/work/gnu-toolchain/build-many/build/glibcs/or1k-linux-gnu-soft/glibc/elf/tst-unwind-ctor-lib.os: in function `do_unwind': /home/shorne/work/gnu-toolchain/glibc/elf/tst-unwind-ctor-lib.c:36: undefined reference to `_Unwind_Backtrace' Adding the -lgcc_s fixes this. I am not sure why this is just showing up now, I just re-bootstrapped my build-many compilers and this error started showing up. I notice its not happending on the test results mailing list. Perhaps someone has an idea? This patch fixes it and the check phase passes. elf/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/elf/Makefile b/elf/Makefile index b86d116be9..5bf9a3eb64 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -2011,6 +2011,7 @@ $(objpfx)tst-big-note: $(objpfx)tst-big-note-lib.so $(objpfx)tst-big-note-lib.so: $(objpfx)tst-big-note-lib.o $(LINK.o) -shared -o $@ $(LDFLAGS.so) $< +LDLIBS-tst-unwind-ctor-lib.so = -lgcc_s $(objpfx)tst-unwind-ctor: $(objpfx)tst-unwind-ctor-lib.so CFLAGS-tst-unwind-main.c += -funwind-tables -DUSE_PTHREADS=0