From patchwork Wed Dec 8 15:24:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 48637 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC5DC3858C60 for ; Wed, 8 Dec 2021 15:27:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC5DC3858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638977275; bh=bDFhvLa+wUUblcOVxOSf7fjhaL6CLJNyjsFtrGR3tvA=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=AumLsd9LJY031oeHnXTczebiKki7nIjidq+28owxoBcaHygNLxw7G5BLKh3ZJ1xg4 IWEFNulOW48RcZRl9nO9b3w0/nZ7Vf1zXDzY3aD7EC8wByYUf+OVaHx1ezK8j+woiM oyZuVWljvJAFRdcmLzzE7HAPUIyKrZqve0fWKinw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 354083858408 for ; Wed, 8 Dec 2021 15:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 354083858408 Received: by mail-pg1-x534.google.com with SMTP id 137so2355928pgg.3 for ; Wed, 08 Dec 2021 07:25:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bDFhvLa+wUUblcOVxOSf7fjhaL6CLJNyjsFtrGR3tvA=; b=IDfMYjNmzbkukXOvo5pKGGdkKCQkDwjwlvTjEvyAdbV+tak4xynWAdVj6JYn5/5TN9 skKtAE/IKgloAeq3cn6muoNYinOgseBw2rJ5Gkq9INJFx+55NN0fzfY0HYFh2ZlPkwfm JO+pvIS1n1JX5UL9yYOYdXyi/Vfk5aG45PpXbl1G/uWyMvtJHY8B4QUhvD0wJHbCP/w9 AzqpjYvu/3LcgaHigVmVWq/jGje3Phd2qj8b2zfn+pnH6hW4qcmJnczlht3CbNWsrPBI wUz6BGSCFCua/1LFNj2RqaCeU+A/JSAOMjZpI8DpOa2x12L/AucEACZRKqFsf9C2xRsI Gz2w== X-Gm-Message-State: AOAM530+dCo+4ru4smtTGgwXM6ST3idLJQ3l2LFM/q5karKqGqSTtvIw +ZCpq8P/6XWtpQvMOx8dVW3dzczFaC4= X-Google-Smtp-Source: ABdhPJz/qSdZ58ZDa+Xsy+6QuEaSmo2XAs4adV5ajNRcYvZv3LCF/lP1X2lEsCU4lvudNoE+PH95mg== X-Received: by 2002:a63:1018:: with SMTP id f24mr16914627pgl.20.1638977103194; Wed, 08 Dec 2021 07:25:03 -0800 (PST) Received: from gnu-cfl-2.localdomain ([172.58.35.133]) by smtp.gmail.com with ESMTPSA id r16sm3008181pgk.45.2021.12.08.07.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 07:25:02 -0800 (PST) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id A73781A0912; Wed, 8 Dec 2021 07:25:01 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH v3 1/3] Add and use link-test-modules-rpath-link [BZ #28455] Date: Wed, 8 Dec 2021 07:24:59 -0800 Message-Id: <20211208152501.1483087-2-hjl.tools@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211208152501.1483087-1-hjl.tools@gmail.com> References: <20211208152501.1483087-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3029.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" DT_RUNPATH is only used to find the immediate dependencies of the executable or shared object containing the DT_RUNPATH entry: 1. Define link-test-modules-rpath-link if $(build-hardcoded-path-in-tests) is yes. 2. Use $(link-test-modules-rpath-link) in build-module-helper so that test modules can dlopen modules with DT_RUNPATH. 3. Add a test to show why link-test-modules-rpath-link is needed. This partially fixes BZ #28455. --- Makeconfig | 2 ++ Makerules | 1 + elf/Makefile | 7 +++++++ elf/tst-global2.c | 32 ++++++++++++++++++++++++++++++++ elf/tst-globalmod2.c | 41 +++++++++++++++++++++++++++++++++++++++++ 5 files changed, 83 insertions(+) create mode 100644 elf/tst-global2.c create mode 100644 elf/tst-globalmod2.c diff --git a/Makeconfig b/Makeconfig index 3fa2f13003..2e2b6dbdf9 100644 --- a/Makeconfig +++ b/Makeconfig @@ -569,8 +569,10 @@ link-libc-rpath-link = -Wl,-rpath-link=$(rpath-link) # build-hardcoded-path-in-tests. ifeq (yes,$(build-hardcoded-path-in-tests)) link-libc-tests-rpath-link = $(link-libc-rpath) +link-test-modules-rpath-link = $(link-libc-rpath) else link-libc-tests-rpath-link = $(link-libc-rpath-link) +link-test-modules-rpath-link = endif # build-hardcoded-path-in-tests link-libc-between-gnulib = $(common-objpfx)libc.so$(libc.so-version) \ diff --git a/Makerules b/Makerules index 8db0ca1296..7afba30039 100644 --- a/Makerules +++ b/Makerules @@ -591,6 +591,7 @@ $(LINK.o) -shared -static-libgcc $(sysdep-LDFLAGS) $(rtld-LDFLAGS) \ $(if $($(@F)-no-z-defs)$(no-z-defs),,-Wl,-z,defs) \ -B$(csu-objpfx) $(load-map-file) \ $(LDFLAGS.so) $(LDFLAGS-$(@F:%.so=%).so) \ + $(link-test-modules-rpath-link) \ -L$(subst :, -L,$(rpath-link)) -Wl,-rpath-link=$(rpath-link) endef diff --git a/elf/Makefile b/elf/Makefile index ef36008673..4b5bdcb08e 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -232,6 +232,7 @@ tests += restest1 preloadtest loadfail multiload origtest resolvfail \ tst-dl-is_dso tst-ro-dynamic \ tst-audit18 \ tst-rtld-run-static \ + tst-global2 \ # reldep9 tests-internal += loadtest unload unload2 circleload1 \ neededtest neededtest2 neededtest3 neededtest4 \ @@ -374,6 +375,7 @@ modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \ tst-dlmopen-gethostbyname-mod tst-ro-dynamic-mod \ tst-auditmod18 \ tst-audit18mod \ + tst-globalmod2 \ # Most modules build with _ISOMAC defined, but those filtered out # depend on internal headers. @@ -1310,6 +1312,11 @@ tst-audit8-ENV = LD_AUDIT=$(objpfx)tst-auditmod1.so $(objpfx)tst-global1.out: $(objpfx)testobj6.so $(objpfx)testobj2.so +$(objpfx)tst-global2: $(objpfx)tst-globalmod2.so +$(objpfx)tst-global2.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so +LDFLAGS-tst-global2 = -Wl,--enable-new-dtags +LDFLAGS-tst-globalmod2.so = -Wl,--enable-new-dtags + $(objpfx)order2.out: $(objpfx)order2mod1.so $(objpfx)order2mod2.so $(objpfx)order2-cmp.out: $(objpfx)order2.out (echo "12345" | cmp $< -) > $@; \ diff --git a/elf/tst-global2.c b/elf/tst-global2.c new file mode 100644 index 0000000000..e929f526f4 --- /dev/null +++ b/elf/tst-global2.c @@ -0,0 +1,32 @@ +/* Test BZ #28455. + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* In glibc configured with --enable-hardcoded-path-in-tests, a test + program built with -Wl,--enable-new-dtags, which adds DT_RUNPATH, + instead of DT_RPATH, can call a function in a shared library, which + dlopens another shared library. */ + +extern int test (void); + +static int +do_test (void) +{ + return test (); +} + +#include diff --git a/elf/tst-globalmod2.c b/elf/tst-globalmod2.c new file mode 100644 index 0000000000..6fd70a72a8 --- /dev/null +++ b/elf/tst-globalmod2.c @@ -0,0 +1,41 @@ +/* Test BZ #28455. + Copyright (C) 2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* In glibc configured with --enable-hardcoded-path-in-tests, a test + program built with -Wl,--enable-new-dtags, which adds DT_RUNPATH, + instead of DT_RPATH, can call a function in a shared library, which + dlopens another shared library. */ + +#include +#include +#include + +extern int test (void); + +int +test (void) +{ + (void) dlopen ("reldepmod4.so", RTLD_LAZY | RTLD_GLOBAL); + if (dlsym (RTLD_DEFAULT, "call_me") != NULL) + { + puts ("found \"call_me\""); + return EXIT_SUCCESS; + } + puts ("didn't find \"call_me\""); + return EXIT_FAILURE; +}