[v3] elf: add definition for ELF_NOTE_FDO and NT_FDO_PACKAGING_METADATA note

Message ID 20211126205856.34805-1-luca.boccassi@gmail.com
State Committed
Commit 0656b649c56ea51cceb86e94842d89946cee919b
Headers
Series [v3] elf: add definition for ELF_NOTE_FDO and NT_FDO_PACKAGING_METADATA note |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

  From: Luca Boccassi <bluca@debian.org>

As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
this note will be used starting from Fedora 36.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v2: as suggested by Mark, indent comment and add NT_ suffix
v3: as requested by Florian, add ELF_NOTE_FDO definition

 elf/elf.h | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Florian Weimer Nov. 29, 2021, 8:35 p.m. UTC | #1
* luca boccassi:

> From: Luca Boccassi <bluca@debian.org>
>
> As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
> this note will be used starting from Fedora 36.
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> v2: as suggested by Mark, indent comment and add NT_ suffix
> v3: as requested by Florian, add ELF_NOTE_FDO definition
>
>  elf/elf.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 50f87baceb..baa6c6693e 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1259,6 +1259,8 @@ typedef struct
>  /* Note entries for GNU systems have this name.  */
>  #define ELF_NOTE_GNU		"GNU"
>  
> +/* Note entries for freedesktop.org have this name.  */
> +#define ELF_NOTE_FDO		"FDO"
>  
>  /* Defined types of notes for Solaris.  */
>  
> @@ -1302,6 +1304,10 @@ typedef struct
>  /* Program property.  */
>  #define NT_GNU_PROPERTY_TYPE_0 5
>  
> +/* Packaging metadata as defined on
> +   https://systemd.io/COREDUMP_PACKAGE_METADATA/ */
> +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e
> +
>  /* Note section name of program property.   */
>  #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"

I'm going to apply this later this week if no one objects.
(Note that the format of the note payload is very much unlike everything
else we do in the ELF space; see the URL.)

Thanks,
Florian
  
Florian Weimer Dec. 2, 2021, 10:02 p.m. UTC | #2
* luca boccassi:

> From: Luca Boccassi <bluca@debian.org>
>
> As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
> this note will be used starting from Fedora 36.
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>

Thanks, now pushed.

Florian
  

Patch

diff --git a/elf/elf.h b/elf/elf.h
index 50f87baceb..baa6c6693e 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -1259,6 +1259,8 @@  typedef struct
 /* Note entries for GNU systems have this name.  */
 #define ELF_NOTE_GNU		"GNU"
 
+/* Note entries for freedesktop.org have this name.  */
+#define ELF_NOTE_FDO		"FDO"
 
 /* Defined types of notes for Solaris.  */
 
@@ -1302,6 +1304,10 @@  typedef struct
 /* Program property.  */
 #define NT_GNU_PROPERTY_TYPE_0 5
 
+/* Packaging metadata as defined on
+   https://systemd.io/COREDUMP_PACKAGE_METADATA/ */
+#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e
+
 /* Note section name of program property.   */
 #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"