Message ID | 20211126170127.1075409-1-luca.boccassi@gmail.com |
---|---|
State | Superseded |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 38EE43857C4E for <patchwork@sourceware.org>; Fri, 26 Nov 2021 17:01:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 38EE43857C4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637946115; bh=KFLicBL54t0Bfbxkq4e1D6vsvsStOxvJ0Ek5ViUPvwk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lUQRLqitfGXoR5NkhKVLkgvC3jMJSnsVYJVUVUkjudrkNTWHdBl82Dp20azi+7B+N vWKBUkT1PbuW4QKZFeFrSBbQ1MD5gSH1DNEMlwrbcXkPQd28lZ1nIwKDPUvPsesLMg 6GTjf9kA0KSwpCyoueNlnJ+xCpDHErYm5hkD+sJw= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id DA4B73858D39 for <libc-alpha@sourceware.org>; Fri, 26 Nov 2021 17:01:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA4B73858D39 Received: by mail-wr1-x429.google.com with SMTP id l16so19963319wrp.11 for <libc-alpha@sourceware.org>; Fri, 26 Nov 2021 09:01:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KFLicBL54t0Bfbxkq4e1D6vsvsStOxvJ0Ek5ViUPvwk=; b=5ydXffesCFbfXBop0+v5LEkQy2UypIJ6fXEFrHqRrlpb+WzDFEziXpDtCdxxbRZ9fZ 1X158SsZS4Ie6KpurqtXq3fOWAB74D7ByipYIN7lW/w1G3zlgFKkkMsXZ+lwSsmqY8+q u3gBefStljwTYSy4zRSW4T+dUOnE2wqya4OQnkG3YKa9adyJDtuUWo/17gsGwx06jLgd 7W7byMJ8PtzCHJ44d+xldbVnxBqMahil0V2iCULLBEM34vaD4rEkFi1DB3msoLKmESxD kTVrhfcmCGGD66s+MCSSszF7MXoWklfumYgxh26b+paWoFvLKFQfywqD6aP3t19YcqPk T+iQ== X-Gm-Message-State: AOAM5315IU41KiSsQ7Z4gCG+0nskESPTbRTfTkOL+YHDCEjda0yh6gXN /zozqdsM8mUKy4sjZ3+ffp2zSVKc7MjtpA== X-Google-Smtp-Source: ABdhPJyRA5FYtgezDTRexDSgzsqcWMd7K7kQBxt6VY5RFUlH2GQz/g9pxezaPffCtijEoEGo43nX0g== X-Received: by 2002:a5d:5643:: with SMTP id j3mr15525994wrw.138.1637946091801; Fri, 26 Nov 2021 09:01:31 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id z5sm15074361wmp.26.2021.11.26.09.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 09:01:31 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH v2] elf: add definition for NT_FDO_PACKAGING_METADATA note Date: Fri, 26 Nov 2021 17:01:27 +0000 Message-Id: <20211126170127.1075409-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211121193939.105186-1-luca.boccassi@gmail.com> References: <20211121193939.105186-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: "luca.boccassi--- via Libc-alpha" <libc-alpha@sourceware.org> Reply-To: luca.boccassi@gmail.com Cc: fweimer@redhat.com, mark@klomp.org Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
[v2] elf: add definition for NT_FDO_PACKAGING_METADATA note
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
dj/TryBot-32bit | success | Build for i686 |
Commit Message
develop--- via Libc-alpha
Nov. 26, 2021, 5:01 p.m. UTC
From: Luca Boccassi <bluca@debian.org> As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ this note will be used starting from Fedora 36. Signed-off-by: Luca Boccassi <bluca@debian.org> --- v2: as suggested by Mark, indent comment and add NT_ suffix elf/elf.h | 4 ++++ 1 file changed, 4 insertions(+)
Comments
* luca boccassi: > From: Luca Boccassi <bluca@debian.org> > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > this note will be used starting from Fedora 36. > > Signed-off-by: Luca Boccassi <bluca@debian.org> > --- > v2: as suggested by Mark, indent comment and add NT_ suffix > > elf/elf.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/elf/elf.h b/elf/elf.h > index 50f87baceb..f2b72bd9f5 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -1302,6 +1302,10 @@ typedef struct > /* Program property. */ > #define NT_GNU_PROPERTY_TYPE_0 5 > > +/* Packaging metadata as defined on > + https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e > + > /* Note section name of program property. */ > #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" Would you please add a definition of ELF_NOTE_FDO earlier in the file, similar to ELF_NOTE_GNU? I would like to point out that the format of the note is JSON-encoded, so it's not really how we have done things so far in the GNU ABI. I guess we can add this as a one-off exception. It shouldn't be an example where things are supposed to go in the future. Thanks, Florian
On Fri, 2021-11-26 at 21:27 +0100, Florian Weimer wrote: > * luca boccassi: > > > From: Luca Boccassi <bluca@debian.org> > > > > As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/ > > this note will be used starting from Fedora 36. > > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > --- > > v2: as suggested by Mark, indent comment and add NT_ suffix > > > > elf/elf.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/elf/elf.h b/elf/elf.h > > index 50f87baceb..f2b72bd9f5 100644 > > --- a/elf/elf.h > > +++ b/elf/elf.h > > @@ -1302,6 +1302,10 @@ typedef struct > > /* Program property. */ > > #define NT_GNU_PROPERTY_TYPE_0 5 > > > > +/* Packaging metadata as defined on > > + https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ > > +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e > > + > > /* Note section name of program property. */ > > #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" > > Would you please add a definition of ELF_NOTE_FDO earlier in the > file, > similar to ELF_NOTE_GNU? > > I would like to point out that the format of the note is JSON- > encoded, > so it's not really how we have done things so far in the GNU ABI. I > guess we can add this as a one-off exception. It shouldn't be an > example where things are supposed to go in the future. > > Thanks, > Florian Sent v3 as suggested, thanks.
diff --git a/elf/elf.h b/elf/elf.h index 50f87baceb..f2b72bd9f5 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -1302,6 +1302,10 @@ typedef struct /* Program property. */ #define NT_GNU_PROPERTY_TYPE_0 5 +/* Packaging metadata as defined on + https://systemd.io/COREDUMP_PACKAGE_METADATA/ */ +#define NT_FDO_PACKAGING_METADATA 0xcafe1a7e + /* Note section name of program property. */ #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"