From patchwork Fri Nov 19 15:26:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 47940 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84BB83857C56 for ; Fri, 19 Nov 2021 15:27:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84BB83857C56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637335640; bh=6ywX6PMKr0WxEjqV40piZkFWRFTcMpWEce+KP+76Q5s=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ES0s990RsyIrVKEQ2SI6FeOOW8IXiFjTtcZONsJVeB28pRCrJ3Po4MMpB500d3ruR geLWIfXonHchwpME6Ngm7R3kZKJoXfROBd4ikOLmcQrXNximZa9dLYLipWKqbTQ5do W2C3bV8cfIQKGxU1peWdE+bPnu3D8R2/gOKbd60A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id DBFF1385800C for ; Fri, 19 Nov 2021 15:26:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBFF1385800C Received: by mail-pg1-x532.google.com with SMTP id r23so8892175pgu.13 for ; Fri, 19 Nov 2021 07:26:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6ywX6PMKr0WxEjqV40piZkFWRFTcMpWEce+KP+76Q5s=; b=Ng+tLXSX/RQpYSnk4+flqRD6ifMwjHQlZoZGXNIcKkbJrTEqHpsX1wewg5EdNkxvSH FRBxPNkCkkyKntLcDV741PRXbzRA1RpnaIzESEKdUp48yNBMdgeJ0Y8oWPhFOb/jJp8x Kjwf/FWbO/Sfy+hMccqpOVewFwAp5txuOWewj11TE1UTiZQqNaZxtD/EMX2LAngpKyGN S1RlcAIIWfOPKNAsiO9eMkkmn637T5obfYbHAHOA4E2PlKiQ9i6jF7bRLt56HXyZxGvS YYbjUtCY9zA60e7HWs84bmZibeKoxr1fNO+HEGXQWpYb9+2N+Us3ZO/BguE6/6+FU3Cz UGIQ== X-Gm-Message-State: AOAM5338JnCQjQ0KHRt/m8rqkO2lbcn8ZmDv0z3eJkaVmEOn86Zld85Y DXdhojxkdkb7TnTTfvklpfy4i/UnoRw= X-Google-Smtp-Source: ABdhPJwcqr46wqob+WeJLiF9orBm4f1gDWZXLWBejeot6DlgAVAOE3D6cw+THiwVNqU1wIn1ma2+Sw== X-Received: by 2002:a63:5d63:: with SMTP id o35mr18185813pgm.134.1637335617035; Fri, 19 Nov 2021 07:26:57 -0800 (PST) Received: from gnu-cfl-2.localdomain ([172.58.35.133]) by smtp.gmail.com with ESMTPSA id j16sm84346pfj.16.2021.11.19.07.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 07:26:56 -0800 (PST) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id A34851A0146; Fri, 19 Nov 2021 07:26:55 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH] Add GLIBC_PRIVATE_RELR as proxy for DT_RELR Date: Fri, 19 Nov 2021 07:26:55 -0800 Message-Id: <20211119152655.121201-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3029.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Executables with DT_RELR will crash mysteriously with glibc binaries without DT_RELR support. Bump EI_ABIVERSION won't prevent crash since the Linux kernel loader doesn't check EI_ABIVERSION on executables. Adding a glibc version dependency on the first glibc version with DT_RELR support will prevent backporting DT_RELR support to released glibc branches. Add a GLIBC_PRIVATE_RELR version as a proxy for DT_RELR support in glibc. Linker should add the GLIBC_PRIVATE_RELR version dependency on binaries with DT_RELR. GLIBC_PRIVATE_RELR should be backported together when backporting DT_RELR support. --- io/Versions | 4 +++- scripts/abilist.awk | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/io/Versions b/io/Versions index 4e19540885..629d458324 100644 --- a/io/Versions +++ b/io/Versions @@ -141,7 +141,6 @@ libc { closefrom; } GLIBC_PRIVATE { - __libc_fcntl64; __fcntl_nocancel; __open64_nocancel; __write_nocancel; @@ -151,4 +150,7 @@ libc { __file_change_detection_for_fp; __fstat64; } + GLIBC_PRIVATE_RELR { + __libc_fcntl64; + } } diff --git a/scripts/abilist.awk b/scripts/abilist.awk index 24a34ccbed..620aacb627 100644 --- a/scripts/abilist.awk +++ b/scripts/abilist.awk @@ -55,7 +55,7 @@ $2 == "g" || $2 == "w" && (NF == 7 || NF == 8) { # caused STV_HIDDEN symbols to appear in .dynsym, though that is useless. if (NF > 7 && $7 == ".hidden") next; - if (version == "GLIBC_PRIVATE" && !include_private) next; + if (version ~ /^GLIBC_PRIVATE/ && !include_private) next; desc = ""; if (type == "D" && ($4 == ".tbss" || $4 == ".tdata")) {