From patchwork Wed Oct 20 20:22:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alejandro Colomar X-Patchwork-Id: 46465 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 033F53857C70 for ; Wed, 20 Oct 2021 20:23:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 033F53857C70 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634761390; bh=Blp6IegFw8//t+HXQM+pQnCu/RTVPRKQg8ZRtk3zP6k=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=IYRA5RJOi+aHb5wj8a2JgGnsT/UxpIRQwTjrjitKR1pSVDR0ywV2kULteN45YKHWt ccGEnK+VTco4aj01Em8+6NJA/XSzpeIqGkTCtqxGJ2UtksX3fEJ89B4qnPeqshAVlG /XhLjf1NIh/QovWLDjzodda7D2ZkCeq+H6xfVBD0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 05AB53858D39 for ; Wed, 20 Oct 2021 20:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05AB53858D39 Received: by mail-wr1-x433.google.com with SMTP id u18so732389wrg.5 for ; Wed, 20 Oct 2021 13:22:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Blp6IegFw8//t+HXQM+pQnCu/RTVPRKQg8ZRtk3zP6k=; b=gpkiZH+yziB8nKGooOI2sU/5g7pNqn34aVyIpD8tmTdkN+gQTuYbAN5Xkq5gSgp70e ZSXcHvF3OziVkKoAiIOFZEP9s6MDfXvxUDpYcaQAE9WncKYCEzgQQV8IXcAvjOY9u+mQ IBk6llL/rtS2lFDYzO62QZuFB6bvBJS+lh4uWm2+pJjEZ0EPHmbd9UOI4hvsZIamo2SS 77qXCAOrMINyptIFofmNe8EwSCwmi3CtC39KCyF1m01sM3a3omsB45loE9Kd28kF5cPO tIFSkVQxzxBQ+Iyx+1O2sGDyEfPJboir//W13fCLQQrOzJ7CxOBNAMzO+Ed+ditt77oa 8bQA== X-Gm-Message-State: AOAM532Azemt11ra9iTkZ4rAM3EoOPlmvsJvjSnrYowWtNd04v9fPH6W s9e4wgJQkLG0OyJB1H1xD70= X-Google-Smtp-Source: ABdhPJxlRENGHJqRmqeHEmIzWf2DZjQc7FbL4duV4i+VDwJpVKcLtQjTEi1RKDHjdpiK+02D2zDRKw== X-Received: by 2002:adf:a1d4:: with SMTP id v20mr1809638wrv.168.1634761366959; Wed, 20 Oct 2021 13:22:46 -0700 (PDT) Received: from sqli.sqli.com ([195.53.121.100]) by smtp.googlemail.com with ESMTPSA id n11sm2892949wrw.43.2021.10.20.13.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 13:22:46 -0700 (PDT) To: mtk.manpages@gmail.com Subject: [PATCH 1/2] ctime.3: Use VLA notation for [as]ctime_r() buffer Date: Wed, 20 Oct 2021 22:22:40 +0200 Message-Id: <20211020202241.171180-1-alx.manpages@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alejandro Colomar via Libc-alpha From: Alejandro Colomar Reply-To: Alejandro Colomar Cc: Alejandro Colomar , linux-man@vger.kernel.org, Jens Gustedt , Glibc Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" As N2417 (part of C2x) suggests. This syntax is very informative, and also, if used by library implementers, can improve static analysis. Since it is backwards compatible with pointer syntax, we can do this. Signed-off-by: Alejandro Colomar Cc: Jens Gustedt Cc: Glibc --- man3/ctime.3 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/man3/ctime.3 b/man3/ctime.3 index 0e2068a09..0620741e9 100644 --- a/man3/ctime.3 +++ b/man3/ctime.3 @@ -41,10 +41,12 @@ localtime_r \- transform date and time to broken-down time or ASCII .B #include .PP .BI "char *asctime(const struct tm *" tm ); -.BI "char *asctime_r(const struct tm *restrict " tm ", char *restrict " buf ); +.BI "char *asctime_r(const struct tm *restrict " tm , +.BI " char " buf "[static restrict 26]);" .PP .BI "char *ctime(const time_t *" timep ); -.BI "char *ctime_r(const time_t *restrict " timep ", char *restrict " buf ); +.BI "char *ctime_r(const time_t *restrict " timep , +.BI " char " buf "[static restrict 26]);" .PP .BI "struct tm *gmtime(const time_t *" timep ); .BI "struct tm *gmtime_r(const time_t *restrict " timep ,