From patchwork Fri Oct 8 01:40:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 45982 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3D673857C6F for ; Fri, 8 Oct 2021 01:40:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3D673857C6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633657257; bh=8KIMKtjpy0W7qlT8g9gIlEH8SnLE+ZPLd1NhSRKBHrg=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=n/6oX8m8yF6SklBSD4OpjrkwNmwUYYYeahoyTnUazCnmfqqwxO4a5n3SUaefWMXMC zMvmqIYmCi3R7afmTmUysrWK9gDotlKpI7aqL9BDBStuP6j5pK9Za0EqhyjL5KqlN3 Cv8HNOEHKPk6lk6wXhG5IFix5YX+vSaHjkgJfpyg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id 46124385840E for ; Fri, 8 Oct 2021 01:40:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46124385840E Received: by mail-yb1-xb4a.google.com with SMTP id b5-20020a251b05000000b005b575f23711so10565613ybb.4 for ; Thu, 07 Oct 2021 18:40:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=8KIMKtjpy0W7qlT8g9gIlEH8SnLE+ZPLd1NhSRKBHrg=; b=GlR0QNhVo9bPZBpPYOi76XQukhUEtRUnII4QsHMVe8KXbI0TysIu1kQ1zrbVj/Qf0n izywfFgBjEnn+WgH9mp+pAqS07OTAnqKFC8l23czIxBt4up2TZHByOHUGUR9lmPh7W2e dqnPS5eGpPaJaVfXJb26lrNZlx992BuxTaUPItpLbSrT3miM82y/vLVgWyFVuIm1+bpi s1gXeRFaEoGoXpP99Kkd2c5en3UqBNv+4dOcWAc/Xg7y9ulDG8bhJKzswmrc83tygN30 yMZWYWC5Q3vy670ZFxYvK5V6+yjR3Apfqyk5cNDVKi6tL2HlQjyg2TjdTa+7ZwjFuMlk jUSg== X-Gm-Message-State: AOAM531hu8nxxloSFcD86y+7yK/UBF3fFUwhWCbGNMZZsKR1OS1gWbnW jhBiSoYUW4Qjq7aziyN+NdG29LSM1fEtQS5qHsarDGdy0EmdPSLSQTHs7kTLvrvZ4q+jXa/ws+/ 4Lun69aXDIw6ILGzxGXQSkwP1gvQ8ykK1ihkE3p6JHrVCuCro8oV0sif7UsD4jmMRShtV X-Google-Smtp-Source: ABdhPJzWZYCWInld0W/7Kk3TkTaO01AZNAsg0yzS6AMxU7kJVeFPS39hMzOajfkaNY/LJwOdw/wMrwMOshWi X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:a0d2:1841:5954:1f2e]) (user=maskray job=sendgmr) by 2002:a25:1d0a:: with SMTP id d10mr435574ybd.201.1633657236741; Thu, 07 Oct 2021 18:40:36 -0700 (PDT) Date: Thu, 7 Oct 2021 18:40:14 -0700 Message-Id: <20211008014014.800723-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH] glibcextract.py: Place un-assemblable @@@ in a comment To: libc-alpha@sourceware.org, Joseph Myers X-Spam-Status: No, score=-19.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Libc-alpha From: Fangrui Song Reply-To: Fangrui Song Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Unlike GCC, Clang passes asm statements and verifies they are valid instructions/directives. Place the magic @@@ into a comment to avoid a parse error. --- scripts/glibcextract.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py index 752ff6223b..bf49a5e322 100644 --- a/scripts/glibcextract.py +++ b/scripts/glibcextract.py @@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc): continue name = arg[0] value = arg[1] - out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" ' + out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" ' ': : \"i\" ((long int) (%s)));' % (name, value)) out_lines.append('}')