From patchwork Wed Oct 6 18:05:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 45932 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6873B385800B for ; Wed, 6 Oct 2021 18:07:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6873B385800B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633543626; bh=Nq8F8t6XuErBvP+8yyk9vz08RVxh6mVBoNgtG8Zr4zE=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fiRlhyvVICAWa9BV+nnh7znkmZliNaq7IWE0t445K8Fuu+zo0TAdCeNNTd5LM3vqa ysvMedD+3fcLnAFDV5f9wb7u/qVEuw2c8/FTvMVnAJc4rJUqIqe3l7lKetcu/RWA3Z RXO9gQgjLt8LT3n0RKBnbB6tRJ0rSAc74AwalWog= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 3E0713858408 for ; Wed, 6 Oct 2021 18:06:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E0713858408 Received: by mail-qt1-x82e.google.com with SMTP id x9so3655411qtv.0 for ; Wed, 06 Oct 2021 11:06:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nq8F8t6XuErBvP+8yyk9vz08RVxh6mVBoNgtG8Zr4zE=; b=xk2FGSMv05RGOtGsRU0K7NUE1SZD2NObw3t8t3ZqKxDQKIy4CCuYySlGL3KLF8rY3i /uy0/UdHEFmWY9QQReRMeZWO+S8/nbmJiz2asEmU2yFxcinQyoedYb+1WP+v5LjJU81p 66Q3VUvuszY5odYkvQV33IZ8cCDQV1PyA5NnwQt4z4+FXr3OqHLPsoTNJCFJbCSzvuaD 9S/XC/VKcTa3yT/iphAWRTAgER8Yzok0JsgimpiEwBL803vIdRXhKQ5etXZw3Ae8ThZ7 ElmTMoCKbX0U+5vLsC/Zjv5Z6KDbq7NwG0TfSUXfurr8WsW4ikE2jsvzISST8RtvPoC8 6Ndw== X-Gm-Message-State: AOAM5313Zm+8Jz1TLGJ8/QV6t9uwsWmoLTAHQDqpk202x07SomPIxNRJ i2rMalJJPx7OQoTQhSFnZtQyofxp/xm2pg== X-Google-Smtp-Source: ABdhPJyWjTdB9MrthpnSRSOCzAscIoB2rUAl+qt93DsLo09m+h73Tox6LsFlrcl9WUV4WdclkraeeA== X-Received: by 2002:ac8:5788:: with SMTP id v8mr172093qta.372.1633543564660; Wed, 06 Oct 2021 11:06:04 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:807a:2ebe:4b13:27bd:f11d]) by smtp.gmail.com with ESMTPSA id 18sm14161168qtz.49.2021.10.06.11.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 11:06:04 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 3/9] math: Simplify hypotf implementation Date: Wed, 6 Oct 2021 15:05:51 -0300 Message-Id: <20211006180557.933826-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211006180557.933826-1-adhemerval.zanella@linaro.org> References: <20211006180557.933826-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_ASCII_DIVIDERS, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Use isnan()/isinf() instead of GET_FLOAT_WORD and interger operations. There is also no need to check for 0.0. The file Copyright is also change to use GPL, the implementation was complete change by 7c10fd3515f to use double precision instead of scaling and this change removes all the GET_FLOAT_WORD usage. Checked on x86_64-linux-gnu. --- sysdeps/ieee754/flt-32/e_hypotf.c | 57 +++++++++++++------------------ 1 file changed, 23 insertions(+), 34 deletions(-) diff --git a/sysdeps/ieee754/flt-32/e_hypotf.c b/sysdeps/ieee754/flt-32/e_hypotf.c index e770947dc1..6495a91cd4 100644 --- a/sysdeps/ieee754/flt-32/e_hypotf.c +++ b/sysdeps/ieee754/flt-32/e_hypotf.c @@ -1,46 +1,35 @@ -/* e_hypotf.c -- float version of e_hypot.c. - */ +/* Euclidean distance function. Float/Binary32 version. + Copyright (C) 2012-2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. -/* - * ==================================================== - * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. - * - * Developed at SunPro, a Sun Microsystems, Inc. business. - * Permission to use, copy, modify, and distribute this - * software is freely granted, provided that this notice - * is preserved. - * ==================================================== - */ + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ #include #include #include float -__ieee754_hypotf(float x, float y) +__ieee754_hypotf (float x, float y) { - double d_x, d_y; - int32_t ha, hb; - - GET_FLOAT_WORD(ha,x); - ha &= 0x7fffffff; - GET_FLOAT_WORD(hb,y); - hb &= 0x7fffffff; - if (ha == 0x7f800000 && !issignaling (y)) - return fabsf(x); - else if (hb == 0x7f800000 && !issignaling (x)) - return fabsf(y); - else if (ha > 0x7f800000 || hb > 0x7f800000) - return fabsf(x) * fabsf(y); - else if (ha == 0) - return fabsf(y); - else if (hb == 0) - return fabsf(x); - - d_x = (double) x; - d_y = (double) y; + if ((isinf (x) || isinf (y)) + && !issignaling (x) && !issignaling (y)) + return INFINITY; + if (isnan (x) || isnan (y)) + return x + y; - return (float) sqrt(d_x * d_x + d_y * d_y); + return sqrt ((double) x * (double) x + (double) y * (double) y); } #ifndef __ieee754_hypotf libm_alias_finite (__ieee754_hypotf, __hypotf)