diff mbox series

[1/7] support: Add xmkfifo

Message ID	20211005135631.3209020-2-adhemerval.zanella@linaro.org
State	Superseded
Headers	DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A5812385840B To: libc-alpha@sourceware.org Subject: [PATCH 1/7] support: Add xmkfifo Date: Tue, 5 Oct 2021 10:56:25 -0300 Message-Id: <20211005135631.3209020-2-adhemerval.zanella@linaro.org> In-Reply-To: <20211005135631.3209020-1-adhemerval.zanella@linaro.org> References: <20211005135631.3209020-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list From: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Adhemerval Zanella <adhemerval.zanella@linaro.org> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org>
Series	Use RFC5424 for syslog \| [0/7] Use RFC5424 for syslog [1/7] support: Add xmkfifo [2/7] misc: Add syslog test [3/7] misc: syslog: Fix indentation and style [4/7] misc: syslog: Simplify implementation [5/7] misc: syslog: Use static buffer [6/7] misc: syslog: Move SYSLOG_NAME to USE_MISC (BZ #16355) [7/7] misc: syslog: Use RFC5424

Checks

Context	Check	Description
dj/TryBot-apply_patch	success	Patch applied to master at the time it was sent

Commit Message

Adhemerval Zanella Oct. 5, 2021, 1:56 p.m. UTC

  Wrapper support mkfifo.
---
 support/Makefile  |  1 +
 support/xmkfifo.c | 29 +++++++++++++++++++++++++++++
 support/xunistd.h |  1 +
 3 files changed, 31 insertions(+)
 create mode 100644 support/xmkfifo.c

Comments

Florian Weimer Oct. 5, 2021, 7:10 p.m. UTC | #1

* Adhemerval Zanella via Libc-alpha:

> diff --git a/support/xmkfifo.c b/support/xmkfifo.c
> new file mode 100644
> index 0000000000..d9f3e9fde7
> --- /dev/null
> +++ b/support/xmkfifo.c

> +void
> +xmkfifo (const char *pathname, mode_t mode)
> +{
> +  int r = mkfifo (pathname, mode);
> +  if (r < 0)
> +    FAIL_EXIT1 ("mkfifo (%s, %d): %m", pathname, mode);
> +}

Please use 0%o for the mode, I think it's more customary.

> diff --git a/support/xunistd.h b/support/xunistd.h
> index e4ade65c85..d2f66c7873 100644
> --- a/support/xunistd.h
> +++ b/support/xunistd.h
> @@ -61,6 +61,7 @@ void xsymlink (const char *target, const char *linkpath);
>  void xchdir (const char *path);
>  void xfchmod (int fd, mode_t mode);
>  void xchmod (const char *pathname, mode_t mode);
> +void xmkfifo (const char *pathtname, mode_t mode);

Typo: path[]name

Adhemerval Zanella Oct. 6, 2021, 7:25 p.m. UTC | #2

On 05/10/2021 16:10, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
> 
>> diff --git a/support/xmkfifo.c b/support/xmkfifo.c
>> new file mode 100644
>> index 0000000000..d9f3e9fde7
>> --- /dev/null
>> +++ b/support/xmkfifo.c
> 
>> +void
>> +xmkfifo (const char *pathname, mode_t mode)
>> +{
>> +  int r = mkfifo (pathname, mode);
>> +  if (r < 0)
>> +    FAIL_EXIT1 ("mkfifo (%s, %d): %m", pathname, mode);
>> +}
> 
> Please use 0%o for the mode, I think it's more customary.

Ack.

> 
>> diff --git a/support/xunistd.h b/support/xunistd.h
>> index e4ade65c85..d2f66c7873 100644
>> --- a/support/xunistd.h
>> +++ b/support/xunistd.h
>> @@ -61,6 +61,7 @@ void xsymlink (const char *target, const char *linkpath);
>>  void xchdir (const char *path);
>>  void xfchmod (int fd, mode_t mode);
>>  void xchmod (const char *pathname, mode_t mode);
>> +void xmkfifo (const char *pathtname, mode_t mode);
> 
> Typo: path[]name
> 

Ack.

diff mbox series

Patch

diff --git a/support/Makefile b/support/Makefile
index fd27c8451e..3c59c086db 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -130,6 +130,7 @@  libsupport-routines = \
   xmemstream \
   xmkdir \
   xmkdirp \
+  xmkfifo \
   xmmap \
   xmprotect \
   xmunmap \
diff --git a/support/xmkfifo.c b/support/xmkfifo.c
new file mode 100644
index 0000000000..d9f3e9fde7
--- /dev/null
+++ b/support/xmkfifo.c
@@ -0,0 +1,29 @@ 
+/* mkfifo with error checking.
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <support/check.h>
+#include <support/xunistd.h>
+#include <sys/stat.h>
+
+void
+xmkfifo (const char *pathname, mode_t mode)
+{
+  int r = mkfifo (pathname, mode);
+  if (r < 0)
+    FAIL_EXIT1 ("mkfifo (%s, %d): %m", pathname, mode);
+}
diff --git a/support/xunistd.h b/support/xunistd.h
index e4ade65c85..d2f66c7873 100644
--- a/support/xunistd.h
+++ b/support/xunistd.h
@@ -61,6 +61,7 @@  void xsymlink (const char *target, const char *linkpath);
 void xchdir (const char *path);
 void xfchmod (int fd, mode_t mode);
 void xchmod (const char *pathname, mode_t mode);
+void xmkfifo (const char *pathtname, mode_t mode);
 
 /* Equivalent of "mkdir -p".  */
 void xmkdirp (const char *, mode_t);