diff mbox series

aarch64: Disable A64FX memcpy/memmove BTI unconditionally

Message ID 20210924074959.1156610-1-naohirot@fujitsu.com
State Committed
Commit 381b29616abb82babc8163bdf516c6da87544b35
Headers show
Series aarch64: Disable A64FX memcpy/memmove BTI unconditionally | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Naohiro Tamura Sept. 24, 2021, 7:49 a.m. UTC
This patch disables A64FX memcpy/memmove BTI instruction insertion
unconditionally such as A64FX memset patch [1] for performance.

[1] commit 07b427296b8d59f439144029d9a948f6c1ce0a31
---
 sysdeps/aarch64/multiarch/memcpy_a64fx.S | 3 +++
 1 file changed, 3 insertions(+)

Comments

Szabolcs Nagy Sept. 24, 2021, 8:15 a.m. UTC | #1
The 09/24/2021 07:49, Naohiro Tamura wrote:
> This patch disables A64FX memcpy/memmove BTI instruction insertion
> unconditionally such as A64FX memset patch [1] for performance.
> 
> [1] commit 07b427296b8d59f439144029d9a948f6c1ce0a31

this is ok to commit, i assume you tested that it does
not unfavourably misalign some critical loop. i can
commit this for you if you want.

Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>

> ---
>  sysdeps/aarch64/multiarch/memcpy_a64fx.S | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sysdeps/aarch64/multiarch/memcpy_a64fx.S b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
> index 65528405bb12..ae7464e09f42 100644
> --- a/sysdeps/aarch64/multiarch/memcpy_a64fx.S
> +++ b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
> @@ -19,6 +19,9 @@
>  
>  #include <sysdep.h>
>  
> +#undef BTI_C
> +#define BTI_C
> +
>  /* Assumptions:
>   *
>   * ARMv8.2-a, AArch64, unaligned accesses, sve
> -- 
> 2.17.1
>
Paul E. McKenney via Libc-alpha Sept. 24, 2021, 12:19 p.m. UTC | #2
Hi Szabolcs,

> The 09/24/2021 07:49, Naohiro Tamura wrote:
> > This patch disables A64FX memcpy/memmove BTI instruction insertion
> > unconditionally such as A64FX memset patch [1] for performance.
> >
> > [1] commit 07b427296b8d59f439144029d9a948f6c1ce0a31
> 
> this is ok to commit, i assume you tested that it does
> not unfavourably misalign some critical loop. i can
> commit this for you if you want.

Thank you for the review.
Yes, I've tested and confirmed no problem.
Please merge it for me.

Thanks.
Naohiro
diff mbox series

Patch

diff --git a/sysdeps/aarch64/multiarch/memcpy_a64fx.S b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
index 65528405bb12..ae7464e09f42 100644
--- a/sysdeps/aarch64/multiarch/memcpy_a64fx.S
+++ b/sysdeps/aarch64/multiarch/memcpy_a64fx.S
@@ -19,6 +19,9 @@ 
 
 #include <sysdep.h>
 
+#undef BTI_C
+#define BTI_C
+
 /* Assumptions:
  *
  * ARMv8.2-a, AArch64, unaligned accesses, sve