From patchwork Fri Sep 10 00:50:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 44918 X-Patchwork-Delegate: siddhesh@gotplt.org Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 017793857402 for ; Fri, 10 Sep 2021 00:51:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 017793857402 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631235090; bh=b3lBI/HephhEK0MZTSTZOCNRr/7IoSm/BX68GdwPBs8=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YPHHMC7ziS2Q4O0XQYYUJFUcmV0OJA1QyiSIh5H6xFi0qeKShIpKcGhGxUWB3fOvG TAVb1hU0aLsUYbxbjDrFqSzpDHqCJkN4FiWoETOErZHOI6EkTgVijuHg0rxION7vGk RjO770/cu3mZ/taIQq8h+aRb7cdau6KxuO57pmH4= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id E39DB3858C2C for ; Fri, 10 Sep 2021 00:51:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E39DB3858C2C Received: by mail-yb1-xb4a.google.com with SMTP id w8-20020a259188000000b0059bf0bed21fso184182ybl.18 for ; Thu, 09 Sep 2021 17:51:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=b3lBI/HephhEK0MZTSTZOCNRr/7IoSm/BX68GdwPBs8=; b=ns2iRyqIfxEUEcEx2VFSb8DjH+fPtN4OM5ONXArm++Ej5z+bM5gBzabEHSaypRynDd 00Ik198QcxcDJSNZmTPqG6rM1wlYnqY81TGb6ayUdIljps5UXDfYuL1w024z9OGFNJGG upqJsr1+xwT4KEVzY1/t1Qh1sD4VmI2O6RVJW1XjGC+mKgJDSKnW53OEIqPrU+CzsX9Y iqKWeXGlyU7o6T6TR9xVBpwYbAy3DufrsxTp56u1A1hrdm3HfWI7QVAVIVLYwmDiD0T6 rbqtVamZ4rRuz3d/1C+elzMgj3h9guH2+ZoGRvRcMu2hkvVwpekIacz3yvE6RFDFY2Zq SgOQ== X-Gm-Message-State: AOAM530tFj+FxZWXWkhnQmafCzIM5KvY3E8XfLPrfY78rzRAFntFspA3 dvZ8ZRAcGVYlv5QPX9hvd2reHJYW5GdBcpMYEKsnS2+RcuXzZk8nbEZgB13oZPofEI+m2+YYGCN pVQpP+iN7TPDLjJGLAiglNFJvPgRgUzbQ5tUVKWlI5mL9/gfEVo9oP6J4Hx3IxBbO/onc X-Google-Smtp-Source: ABdhPJzo69r4Vgu4f15VNaICyTWTxuulDUzwQY5KD0N1l3o6G7q1ODOIsOPbV1QrAXiZjU7H/U27f4zHRiX6 X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:94c7:858:e9b4:3ca0]) (user=maskray job=sendgmr) by 2002:a25:44d5:: with SMTP id r204mr7278920yba.229.1631235065373; Thu, 09 Sep 2021 17:51:05 -0700 (PDT) Date: Thu, 9 Sep 2021 17:50:51 -0700 Message-Id: <20210910005051.2120865-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH] configure: Fix check for INSERT in linker script To: libc-alpha@sourceware.org, "H.J. Lu" X-Spam-Status: No, score=-19.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Libc-alpha From: Fangrui Song Reply-To: Fangrui Song Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" GCC/Clang use local access when referencing a const variable, so the conftest.so may have no dynamic relocation. LLD reports `error: unable to insert .foo after .rela.dyn` when the destination section does not exist. Use a non-const int to ensure that .rela.dyn exists. Reviewed-by: Siddhesh Poyarekar --- configure | 2 +- configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 542802ad35..39d75eb4ed 100755 --- a/configure +++ b/configure @@ -5793,7 +5793,7 @@ if ${libc_cv_insert+:} false; then : $as_echo_n "(cached) " >&6 else cat > conftest.c < conftest.t < conftest.c < conftest.t <