From patchwork Sat Aug 28 13:15:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 44803 X-Patchwork-Delegate: carlos@redhat.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D1B6E3857427 for ; Sat, 28 Aug 2021 13:15:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D1B6E3857427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630156558; bh=CMQd+reC/sIdYZy+Lr8/ocvxRLHpvQiIswyepr/7PTs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=vf4TEoBOrDLvRbyTgrny7e888eKVAV5vwvJ9A+76RuhyHtjk0EA7NqYNyIIvyOEQa hWoTcvymmvG5PlslwidQBXWWWxAU6kPi+eUdVgliwhSulNIw3EJakRSIFHFtUpXcBf lbUs2oZNBs1/VQRk9tf2oSHa8sFYhRXhYP+30r2Y= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id DDD383858435 for ; Sat, 28 Aug 2021 13:15:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDD383858435 Received: by mail-pj1-x1033.google.com with SMTP id n13-20020a17090a4e0d00b0017946980d8dso10805941pjh.5 for ; Sat, 28 Aug 2021 06:15:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CMQd+reC/sIdYZy+Lr8/ocvxRLHpvQiIswyepr/7PTs=; b=XctNwr3zFsATDRiG9CDjP0XkiDoTNegApBNWSdibvfr32qS5cPPG0ONhws3T5AFGJH 6AVv2oI5Quobvpj3PdSKbivJVX/3k5tVvTMmjYEvWu8nI1uVWF/0nX/UETD42mcfW+zB bTSsNjZe/4g5u5o3nZcraNwUa1Cva5eKZAsVDj5X8S9dQDVhY+761nO5qqXcDrBKitcK SAjdIB8qb/ZikNq5F+lqL1et+/n65an2BBOv8u0ZoDXHy6rkSFygfn8zorXYXQIqWSYM 8kWa+YUzlAcp3opPU1VIiEgVYnEXb2K3L8c8hPODNuR0m6NYIuLxiU39HFDTeaIO8E4U 353Q== X-Gm-Message-State: AOAM5312zs4M0Eza7Ewjj4jIBnTLfAWg4p/NykHaocJKcYEyS4vuU9wx Pqacwpum1RRJ7lp/dREit1M= X-Google-Smtp-Source: ABdhPJw3WwNUrUnM0JRkolimO209RBVpvI+h0GMHLJ9r/wPoBRsSV08a3xgfBcxbN1AUFgmczhtv8g== X-Received: by 2002:a17:90a:2e0a:: with SMTP id q10mr1779360pjd.136.1630156532097; Sat, 28 Aug 2021 06:15:32 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.58.38.240]) by smtp.gmail.com with ESMTPSA id m5sm10673402pgn.70.2021.08.28.06.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Aug 2021 06:15:31 -0700 (PDT) Received: from gnu-cfl-2.. (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id C68FCC019F; Sat, 28 Aug 2021 06:15:30 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] x86-64: Use testl to check __x86_string_control Date: Sat, 28 Aug 2021 06:15:30 -0700 Message-Id: <20210828131530.539387-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3031.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Use testl, instead of andl, to check __x86_string_control to avoid updating __x86_string_control. Reviewed-by: Carlos O'Donell --- sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S index 9f02624375..abde8438d4 100644 --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S @@ -325,7 +325,7 @@ L(movsb): /* Avoid slow backward REP MOVSB. */ jb L(more_8x_vec_backward) # if AVOID_SHORT_DISTANCE_REP_MOVSB - andl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) + testl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) jz 3f movq %rdi, %rcx subq %rsi, %rcx @@ -333,7 +333,7 @@ L(movsb): # endif 1: # if AVOID_SHORT_DISTANCE_REP_MOVSB - andl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) + testl $X86_STRING_CONTROL_AVOID_SHORT_DISTANCE_REP_MOVSB, __x86_string_control(%rip) jz 3f movq %rsi, %rcx subq %rdi, %rcx