diff mbox series

llio.texi: Wording fixes in description of closefrom()

Message ID 20210811223053.310018-1-mtk.manpages@gmail.com
State Committed
Commit 5aa359d33163bde660fec9b26e23cfb93d63ecde
Headers show
Series llio.texi: Wording fixes in description of closefrom() | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Michael Kerrisk \(man-pages\) Aug. 11, 2021, 10:30 p.m. UTC
Fix two problems.

Rather than "larger than", better English is "greater than".

Then there is a wordinig error on the follwoing line: "then lowfd"
appears to be cruft.

Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
---
 manual/llio.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Adhemerval Zanella Aug. 24, 2021, 4:11 p.m. UTC | #1
On 11/08/2021 19:30, Michael Kerrisk wrote:
> Fix two problems.
> 
> Rather than "larger than", better English is "greater than".
> 
> Then there is a wordinig error on the follwoing line: "then lowfd"
> appears to be cruft.
> 
> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  manual/llio.texi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/manual/llio.texi b/manual/llio.texi
> index 2c59f6badf..e55b02d8bd 100644
> --- a/manual/llio.texi
> +++ b/manual/llio.texi
> @@ -338,8 +338,8 @@ The kernel does not implement the required functionality.
>  @standards{GNU, unistd.h}
>  @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{@acsfd{}}}
>  
> -The function @code{closefrom} closes all file descriptors larger than or equal
> -to @var{lowfd} then @var{lowfd}.  This function is similar to calling
> +The function @code{closefrom} closes all file descriptors greater than or equal
> +to @var{lowfd}.  This function is similar to calling
>  @code{close} for all open file descriptors not less than @var{lowfd}.
>  
>  Already closed file descriptors are ignored.
>
luca.boccassi--- via Libc-alpha Aug. 24, 2021, 9:41 p.m. UTC | #2
Hello Adhemerval

On Tue, 24 Aug 2021 at 18:11, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 11/08/2021 19:30, Michael Kerrisk wrote:
> > Fix two problems.
> >
> > Rather than "larger than", better English is "greater than".
> >
> > Then there is a wordinig error on the follwoing line: "then lowfd"
> > appears to be cruft.
> >
> > Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Who will apply this? (I can't.)

Thanks,

Michael

> > ---
> >  manual/llio.texi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/manual/llio.texi b/manual/llio.texi
> > index 2c59f6badf..e55b02d8bd 100644
> > --- a/manual/llio.texi
> > +++ b/manual/llio.texi
> > @@ -338,8 +338,8 @@ The kernel does not implement the required functionality.
> >  @standards{GNU, unistd.h}
> >  @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{@acsfd{}}}
> >
> > -The function @code{closefrom} closes all file descriptors larger than or equal
> > -to @var{lowfd} then @var{lowfd}.  This function is similar to calling
> > +The function @code{closefrom} closes all file descriptors greater than or equal
> > +to @var{lowfd}.  This function is similar to calling
> >  @code{close} for all open file descriptors not less than @var{lowfd}.
> >
> >  Already closed file descriptors are ignored.
> >
Adhemerval Zanella Aug. 25, 2021, 12:35 p.m. UTC | #3
On 24/08/2021 18:41, Michael Kerrisk (man-pages) wrote:
> Hello Adhemerval
> 
> On Tue, 24 Aug 2021 at 18:11, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>>
>>
>>
>> On 11/08/2021 19:30, Michael Kerrisk wrote:
>>> Fix two problems.
>>>
>>> Rather than "larger than", better English is "greater than".
>>>
>>> Then there is a wordinig error on the follwoing line: "then lowfd"
>>> appears to be cruft.
>>>
>>> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
>>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 
> Who will apply this? (I can't.)

I will take care of it.
Michael Kerrisk \(man-pages\) Aug. 26, 2021, 11:19 p.m. UTC | #4
On 8/25/21 2:35 PM, Adhemerval Zanella wrote:
> 
> 
> On 24/08/2021 18:41, Michael Kerrisk (man-pages) wrote:
>> Hello Adhemerval
>>
>> On Tue, 24 Aug 2021 at 18:11, Adhemerval Zanella
>> <adhemerval.zanella@linaro.org> wrote:
>>>
>>>
>>>
>>> On 11/08/2021 19:30, Michael Kerrisk wrote:
>>>> Fix two problems.
>>>>
>>>> Rather than "larger than", better English is "greater than".
>>>>
>>>> Then there is a wordinig error on the follwoing line: "then lowfd"
>>>> appears to be cruft.
>>>>
>>>> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
>>>
>>> LGTM, thanks.
>>>
>>> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>>
>> Who will apply this? (I can't.)
> 
> I will take care of it.

Thanks, Adhemerval.

Cheers,

Michael
Siddhesh Poyarekar Aug. 27, 2021, 3:43 a.m. UTC | #5
On 8/25/21 3:11 AM, Michael Kerrisk (man-pages) via Libc-alpha wrote:
>>> Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
>>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 
> Who will apply this? (I can't.)

We should really fix this.  If you're interested, could you please 
submit a request?

https://sourceware.org/cgi-bin/pdw/ps_form.cgi

Thanks!
Siddhesh
diff mbox series

Patch

diff --git a/manual/llio.texi b/manual/llio.texi
index 2c59f6badf..e55b02d8bd 100644
--- a/manual/llio.texi
+++ b/manual/llio.texi
@@ -338,8 +338,8 @@  The kernel does not implement the required functionality.
 @standards{GNU, unistd.h}
 @safety{@prelim{}@mtsafe{}@assafe{}@acsafe{@acsfd{}}}
 
-The function @code{closefrom} closes all file descriptors larger than or equal
-to @var{lowfd} then @var{lowfd}.  This function is similar to calling
+The function @code{closefrom} closes all file descriptors greater than or equal
+to @var{lowfd}.  This function is similar to calling
 @code{close} for all open file descriptors not less than @var{lowfd}.
 
 Already closed file descriptors are ignored.