[3/5] iconv_charmap: Close output file when done
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
---
iconv/iconv_charmap.c | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi Siddhesh,
> ---
> iconv/iconv_charmap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/iconv/iconv_charmap.c b/iconv/iconv_charmap.c
> index e2d53fee3c..a8b6b56124 100644
> --- a/iconv/iconv_charmap.c
> +++ b/iconv/iconv_charmap.c
> @@ -234,6 +234,8 @@ charmap_conversion (const char *from_code, struct charmap_t *from_charmap,
> while (++remaining < argc);
>
> /* All done. */
> + if (output != stdout)
> + fclose (output);
> free_table (cvtbl);
> return status;
> }
Earlier on, output is either the result of an fopen, or assigned stdout.
So, this change looks right.
Reviewed-by: Arjun Shankar <arjun@redhat.com>
Cheers!
@@ -234,6 +234,8 @@ charmap_conversion (const char *from_code, struct charmap_t *from_charmap,
while (++remaining < argc);
/* All done. */
+ if (output != stdout)
+ fclose (output);
free_table (cvtbl);
return status;
}