From patchwork Mon Jul 19 16:45:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 44411 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E02BF395CC03 for ; Mon, 19 Jul 2021 16:48:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E02BF395CC03 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626713323; bh=UUJdZR4ZzxwSZ8P4u1fISmaUDGbYhx53bKvTaJNLpbU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mLH0u7ye5BXfO2u8vxu+MDUTnxOroSJHFvEEP+7hAUamYFpFHnSMITH0uiaUi5+X5 f+djG1yV0fsxAKWv2z943Jm5XVVvZo8gy1gZxIxnaDQ5jPcjAhYIbkOtrJM5+7igY4 fY44SqRr6oLpIYAmarwYXWS3hCIYfU4Czg/F88xo= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by sourceware.org (Postfix) with ESMTPS id A3DAD395C809 for ; Mon, 19 Jul 2021 16:46:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3DAD395C809 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3EFB461245; Mon, 19 Jul 2021 16:46:17 +0000 (UTC) To: Catalin Marinas , Will Deacon Subject: [PATCH v5 3/4] elf: Remove has_interp property from arch_adjust_elf_prot() Date: Mon, 19 Jul 2021 17:45:35 +0100 Message-Id: <20210719164536.19143-4-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210719164536.19143-1-broonie@kernel.org> References: <20210719164536.19143-1-broonie@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2253; h=from:subject; bh=Ct5yJFpFuVch2Ey0mQXeG/FiXFyh3RZPLWGYibJt980=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBg9awux0UYSgSoCn8xj5dLcWfxWqQX2Eru7YRJBEh1 3DMw5I+JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYPWsLgAKCRAk1otyXVSH0O1ZB/ 96l6r7AMYYfDzNEc+gZqOkAUWQGyzAo7IhbjpMxYpk3PFHt8GNGw+371TGtW814kATkSz2OdLSQAKw QNsIByYWi96HV8Es4j53IBIptN40vg1x2OUrzc7FDTLAvsmedf2pGErGrJZFf3DeYYWliKnpFmvHFn sL1o78pOS2IaiGLCrZO4MXwLu2uE7+s1cgoxNQtwU/8hU2/80tlRu5fRe/txj41xeqy7sHCylYAI3P QY7nxAKk1MdSUmwRVs17EmatlY66Du9Nrytuoebxbm0Jm6sYsx8M7K+DeldgYpBFYDxHd0wg2yVdFJ Au5m7z9OPStNdSNQOAmcgqaGiLXlLZ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Mark Brown via Libc-alpha From: Mark Brown Reply-To: Mark Brown Cc: linux-arch@vger.kernel.org, Yu-cheng Yu , libc-alpha@sourceware.org, Szabolcs Nagy , Jeremy Linton , Mark Brown , Dave Martin , linux-arm-kernel@lists.infradead.org Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Since we have added an is_interp flag to arch_parse_elf_property() we can drop the has_interp flag from arch_elf_adjust_prot(), the only user was the arm64 code which no longer needs it and any future users will be able to use arch_parse_elf_properties() to determine if an interpreter is in use. Signed-off-by: Mark Brown Tested-by: Jeremy Linton Reviewed-By: Dave Martin --- arch/arm64/kernel/process.c | 2 +- fs/binfmt_elf.c | 2 +- include/linux/elf.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 2645bc79b35e..14478c5b52d3 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -684,7 +684,7 @@ core_initcall(tagged_addr_init); #ifdef CONFIG_BINFMT_ELF int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, - bool has_interp, bool is_interp) + bool is_interp) { if ((prot & PROT_EXEC) && (state->flags & arm64_elf_bti_flag(is_interp))) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 28eaf36f145b..4f3bea1a697c 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -580,7 +580,7 @@ static inline int make_prot(u32 p_flags, struct arch_elf_state *arch_state, if (p_flags & PF_X) prot |= PROT_EXEC; - return arch_elf_adjust_prot(prot, arch_state, has_interp, is_interp); + return arch_elf_adjust_prot(prot, arch_state, is_interp); } /* This is much more generalized than the library routine read function, diff --git a/include/linux/elf.h b/include/linux/elf.h index 1c45ecf29147..d8392531899d 100644 --- a/include/linux/elf.h +++ b/include/linux/elf.h @@ -101,11 +101,11 @@ extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz, #ifdef CONFIG_ARCH_HAVE_ELF_PROT int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, - bool has_interp, bool is_interp); + bool is_interp); #else static inline int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, - bool has_interp, bool is_interp) + bool is_interp) { return prot; }