diff mbox series

Make mcheck tests conditional on GLIBC_2.24 or earlier

Message ID 20210709111719.651791-1-siddhesh@sourceware.org
State Superseded
Headers show
Series Make mcheck tests conditional on GLIBC_2.24 or earlier | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Siddhesh Poyarekar July 9, 2021, 11:17 a.m. UTC
Targets with base versions later than 2.24 won't have
__malloc_initialize_hook because of which the tests will essentially
be the same as the regular malloc tests.  Avoid running them instead
and save time.
---
 malloc/Makefile | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/malloc/Makefile b/malloc/Makefile
index 37a9a4efab..76c996bb4d 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -77,6 +77,8 @@  tests-exclude-malloc-check = tst-malloc-check tst-malloc-usable \
 # Run all tests with MALLOC_CHECK_=3
 tests-malloc-check = $(filter-out $(tests-exclude-malloc-check),$(tests))
 
+# -lmcheck needs __malloc_initialize_hook, which was deprecated in 2.24.
+ifeq ($(have-GLIBC_2.24)$(build-shared),yesyes)
 # Tests that don't play well with mcheck.  They are either bugs in mcheck or
 # the tests expect specific internal behavior that is changed due to linking to
 # libmcheck.a.
@@ -97,6 +99,7 @@  tests-exclude-mcheck = tst-mallocstate \
 	tst-realloc
 
 tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
+endif
 
 routines = malloc morecore mcheck mtrace obstack reallocarray \
   scratch_buffer_dupfree \