[v4,01/10] Drop source dependencies on hooks.c and arena.c
Checks
| Context |
Check |
Description |
| dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
Dependencies on hooks.c and arena.c get auto-computed when generating
malloc.o{,s}.d so there is no need to add them manually.
---
malloc/Makefile | 4 ----
1 file changed, 4 deletions(-)
Comments
On Jul 02 2021, Siddhesh Poyarekar via Libc-alpha wrote:
> Dependencies on hooks.c and arena.c get auto-computed when generating
> malloc.o{,s}.d so there is no need to add them manually.
Ok.
Andreas.
On 7/2/21 7:38 AM, Siddhesh Poyarekar wrote:
> Dependencies on hooks.c and arena.c get auto-computed when generating
> malloc.o{,s}.d so there is no need to add them manually.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> malloc/Makefile | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/malloc/Makefile b/malloc/Makefile
> index c8256abbbf..2f9b3d596d 100644
> --- a/malloc/Makefile
> +++ b/malloc/Makefile
> @@ -269,10 +269,6 @@ $(objpfx)memusage: memusage.sh
> -e 's|@REPORT_BUGS_TO@|$(REPORT_BUGS_TO)|' $^ > $@.new \
> && rm -f $@ && mv $@.new $@ && chmod +x $@
>
> -
> -# Extra dependencies
> -$(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c
> -
> # Compile the tests with a flag which suppresses the mallopt call in
> # the test skeleton.
> $(tests:%=$(objpfx)%.o): CPPFLAGS += -DTEST_NO_MALLOPT
>
@@ -269,10 +269,6 @@ $(objpfx)memusage: memusage.sh
-e 's|@REPORT_BUGS_TO@|$(REPORT_BUGS_TO)|' $^ > $@.new \
&& rm -f $@ && mv $@.new $@ && chmod +x $@
-
-# Extra dependencies
-$(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c
-
# Compile the tests with a flag which suppresses the mallopt call in
# the test skeleton.
$(tests:%=$(objpfx)%.o): CPPFLAGS += -DTEST_NO_MALLOPT