diff mbox series

[v4,01/10] Drop source dependencies on hooks.c and arena.c

Message ID 20210702113845.3367306-2-siddhesh@sourceware.org
State Committed
Commit 7df5c7bcce5c3e6f6984441d9c4851dba5aacac5
Headers show
Series Remove malloc hooks | expand

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Siddhesh Poyarekar July 2, 2021, 11:38 a.m. UTC
Dependencies on hooks.c and arena.c get auto-computed when generating
malloc.o{,s}.d so there is no need to add them manually.
---
 malloc/Makefile | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andreas Schwab July 2, 2021, 12:12 p.m. UTC | #1
On Jul 02 2021, Siddhesh Poyarekar via Libc-alpha wrote:

> Dependencies on hooks.c and arena.c get auto-computed when generating
> malloc.o{,s}.d so there is no need to add them manually.

Ok.

Andreas.
Carlos O'Donell July 2, 2021, 7:06 p.m. UTC | #2
On 7/2/21 7:38 AM, Siddhesh Poyarekar wrote:
> Dependencies on hooks.c and arena.c get auto-computed when generating
> malloc.o{,s}.d so there is no need to add them manually.

LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  malloc/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/malloc/Makefile b/malloc/Makefile
> index c8256abbbf..2f9b3d596d 100644
> --- a/malloc/Makefile
> +++ b/malloc/Makefile
> @@ -269,10 +269,6 @@ $(objpfx)memusage: memusage.sh
>  	    -e 's|@REPORT_BUGS_TO@|$(REPORT_BUGS_TO)|' $^ > $@.new \
>  	&& rm -f $@ && mv $@.new $@ && chmod +x $@
>  
> -
> -# Extra dependencies
> -$(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c
> -
>  # Compile the tests with a flag which suppresses the mallopt call in
>  # the test skeleton.
>  $(tests:%=$(objpfx)%.o): CPPFLAGS += -DTEST_NO_MALLOPT
>
diff mbox series

Patch

diff --git a/malloc/Makefile b/malloc/Makefile
index c8256abbbf..2f9b3d596d 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -269,10 +269,6 @@  $(objpfx)memusage: memusage.sh
 	    -e 's|@REPORT_BUGS_TO@|$(REPORT_BUGS_TO)|' $^ > $@.new \
 	&& rm -f $@ && mv $@.new $@ && chmod +x $@
 
-
-# Extra dependencies
-$(foreach o,$(all-object-suffixes),$(objpfx)malloc$(o)): arena.c hooks.c
-
 # Compile the tests with a flag which suppresses the mallopt call in
 # the test skeleton.
 $(tests:%=$(objpfx)%.o): CPPFLAGS += -DTEST_NO_MALLOPT