From patchwork Mon Jun 28 10:38:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 44033 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0B98395B803 for ; Mon, 28 Jun 2021 10:39:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0B98395B803 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624876788; bh=VtEfRfjam5I/RBS9398VcpBFGC0DqDW7SbUFZqnYioM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Fm5qy6SCTYNRCNmuHtqTwL7gaxmkIzjpIL4l0A3dUP9+eKfHa/51kWQN67QiUMs0E ppqrKkkeRGtLvT/Tus1mDa3hFF/Ab3Jbp2T+p5sNUM0gD8w5pC5Kq3+MhGTzqqVbZt y3THwybcFfbzYQZFNb7Uee0DPvCcUVo3qrmeWliU= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) by sourceware.org (Postfix) with ESMTPS id 0C6FA3850413 for ; Mon, 28 Jun 2021 10:39:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0C6FA3850413 Received: from DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) by DB8PR08MB5418.eurprd08.prod.outlook.com (2603:10a6:10:116::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.22; Mon, 28 Jun 2021 10:39:22 +0000 Received: from DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:30:cafe::92) by DB6PR0301CA0088.outlook.office365.com (2603:10a6:6:30::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 10:39:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT028.mail.protection.outlook.com (10.152.20.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 10:39:21 +0000 Received: ("Tessian outbound 26e033cda78d:v97"); Mon, 28 Jun 2021 10:39:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4a53de5aade2eefa X-CR-MTA-TID: 64aa7808 Received: from 996a9ffbad19.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 11362D45-3141-4316-B963-EFFFA1ADB524.1; Mon, 28 Jun 2021 10:39:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 996a9ffbad19.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 28 Jun 2021 10:39:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PS9NqFkwYz/RPOUkwmJGGDx3BcblVqcE/Q/50kAlUvUWExlNTfLRm2apPhlSEg1ja/lFrJ8eakZJJgd7a+sahMspCJ/BLbYp1bHcIVb4uGDPlgzbzWdNat8B97tJOgwPBNv5DtHPazVU+p0TwR0fXaPHboe6HaE59iHvKXXNNzc0dQxxifEoJD06vew2eukyW6K0EB4Z5n5OLMktoAFdtiIU07wNfJ0Y6JPzA1NgkAVAbgst2vb/thWyPgdFVCeTZif37BuEMDvp484wpIydCzRmO67gIjMVGNxD7pcMR1+3RFLW3LK3xRRV10d4QUh2d53Fnz3AGEy5YrgjzHbfwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VtEfRfjam5I/RBS9398VcpBFGC0DqDW7SbUFZqnYioM=; b=Aok++DfO1OaQ6D9+hmkc3tU89hjCkgdFsZaMcdrWfDUPPi7efEkW5SVrJx3sK7x9CAg9SYXHS4xvVx+jsSCh5lp5Sdj9mMqkVz6g7N7F/3qhmxjbPceoh1gOsdSPnLIDD511oCqQn8wVM/8nVsBVcOBz1ci1OzsMUBnw+pHDxzZm1SeqUbkeFj3iomkNwGhOgv+gVx6W8jenLdvPCAqnJS7emBnJxGkVQJzVpNafJ7O1FTgpRnMDYkg3oBM50h8qKSLZx9x+7fHGUCeUdrA8aiZDDLb/uhwN5xuWrC3+oug6OmDTEHI5haIC54Y+kOmhDm5RvTD79NgPbU9gZ9p2Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) by DBBPR08MB4760.eurprd08.prod.outlook.com (2603:10a6:10:f6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Mon, 28 Jun 2021 10:39:07 +0000 Received: from DBBPR08MB6313.eurprd08.prod.outlook.com ([fe80::ada5:303a:de76:b0e2]) by DBBPR08MB6313.eurprd08.prod.outlook.com ([fe80::ada5:303a:de76:b0e2%5]) with mapi id 15.20.4242.023; Mon, 28 Jun 2021 10:39:07 +0000 To: libc-alpha@sourceware.org Subject: [COMMITTED] arm: align stack in clone [BZ 28020] Date: Mon, 28 Jun 2021 11:38:56 +0100 Message-Id: <20210628103856.15407-1-szabolcs.nagy@arm.com> X-Mailer: git-send-email 2.17.1 X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: SN6PR01CA0012.prod.exchangelabs.com (2603:10b6:805:b6::25) To DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (217.140.106.55) by SN6PR01CA0012.prod.exchangelabs.com (2603:10b6:805:b6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 10:39:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42922207-679d-4be9-ab44-08d93a20fdb1 X-MS-TrafficTypeDiagnostic: DBBPR08MB4760:|DB8PR08MB5418: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2201;OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DQwZhzhwLtbrEma/NC61aPoSwW4nTI4WgpsTOEQZeGPc95Pu6KLguGapMoKmK3LPRxpg4cLMC+hxWRONSBqGn8G7tAsJcr1jwrKeUUGBjjAywFMjI+BHQjU2qpLoYG2EXtckqzwcS+aWLRahIke2dsJh0GaSzhN8+ytHWPizzefks9qr500EGTANbt7MHgX/8sUJesV8aZwR3HRNCAt/dzFE7jfGtWqMlnBpHpoljGrSS1XA66H+hXdAEMGcgT1QjSkXyhyYaPlgiN4sBtsDXwu05vL4cTLyBPK57edm6quofO7nu6IW3wG4cqR2PhrJnY9dVRfRHYh2/Pat19oDx4seYfpZtM4E4Eu6k+sPblLH4nlPGA964UqiiutLwxUbJM9wOgyRpI0p8RpC/O2Ea8M4A/dVGcvc34rVyY6i6E6UB3iseHI5JZewp8ykNMYQ25Z79+Knr0JP43ra+mHLCqU2UcX9Zd46urb86AFCJAjYxEZFmwxRLUtODA+6uVTLvGnc0u/pyWQN2u3qsV1QGlFPdAYZtDvCejlEs73pGuDFL86EcPrnAgMFbiBpb0WFJu7jObXtUtf3BzQbV8CRmWAc5uuTVu/6kCnSOniXzS3qHPhXlR3GOiphcwgiMmeDmj6D7b88+stXS2ukg/9yoyNTpGbUdXIkvFAT/Crp90BKxda8C7e1WMbPeganCfnK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB6313.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(16526019)(6506007)(186003)(52116002)(38100700002)(6512007)(66946007)(316002)(38350700002)(6666004)(36756003)(44832011)(1076003)(6916009)(8936002)(6486002)(26005)(4744005)(86362001)(956004)(2906002)(8676002)(2616005)(66556008)(478600001)(5660300002)(66476007)(69590400013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: psrz462Q3ChOEicP+PJ/eAz65UC5CUqV9tQjVpRLTeJwLyGg+tgMOo3BtBdFxronIPzi8kIvG8jGIiQnnNS6e3k4TYUU70QFoEkp1ABV5nraKm3y+HOmoAl5Yy0vXHaH0XK0QZ1QC0HSOf+WFvHfp2E7LPmJlX+8G+Afb/7vdVHWuJY6n8b7BSTBpsHmPdzQYTVnKj9aLJ/mXFpTxCD3uT5tznIXwkGl6rzogdJty4OD4E1UlpyKnQflprM+uvyNEo+hs/DAs/wr+Wt+bXJ+so9U2Xg3OeuFY5bFMLHgV4q/aeymSGIQdnRTO3CyyY5pZE+uGjTwGHzudqSJIqGWSFNsJoAnkrn4ErZM4JYp+9UQsP2E3uyZlgEebI1WwwC5jB4hstVQuSkkC4SNUoOGGPOIdcO+7I8hPOdXeCTapgMATdrz91MfI/w/5KUXV9vD07i4Sv73rdy59j2lhyX7Ty+JmMohPblSTm0yfhU+ExN7qjbLlUhtm1NOXreoN/B1vQZqJkR4fRp1/noqt2UipTgOm76QLQI9ZoqM941pNHKpBhtDOENsM4wpSh3+pDGnjpsk2jYu9JjKbXWOvBo4s/6nWGZnfa2QVwvIsUSMlDwuAKsglFR3HgaC8cdybAtnaZAw4e1uEkmGccjKCoM+7noYlJSOqJQ45SdHP8+y3t/HCab98P/9gx3MnILydJPJ8uZLmcDix/tF3igGSKGnlcnO9J57q3iATSzmEXA/IX8K1QmNXhiyeet8n3debYoL2wFDsCLAn6CRqmsdnSKk856jY8+4JfGEd93R77gL4cV6BCVnTu3vROqgE+g3ACvpnqvf0Pk6x90Pf91Yk/qkwh5tb2S8wVRZFTN7Eakn3BngNv5zAGBUTFaerOkZX600ReWsyIjscoV5ey+9tFAqPXJRwUYuGl0xbSxoeIO2EUd1nWeJgXDf6qZlyQrQbc1aXBV4AqXCqpWy7O9gXSEI/38v+j2ERLYFmSSUFqvMuyMOQFZRscFKP5ntoNvrifY0e0yf0jhBfWVmsyyfijcZF4a8wLZMqUqjY5VWX31Xo53i7+3NeI9nSUm2gz0cXOwV/n9DoGxUGk/bMtj999mT2KMaMxRGxAMZvsHVZyRV1+LlUhMnC5K/ldW09j/88YWMWVKUk3kPW4mv0mhObLw0UfpBraGF5NwMeEX/FbkHwhxMBkbLx9xPQ3o1lu7Us0h2a1HhVS75Ipxn7YGJLzyE7C2Il8TVOG8I8GhaTR+WiSG9njMrEauDuPYZq8wnF+zPk5L2ZlsK5PY+eA/1kLJ0EsQs4r+HPz1DA3oTmoKtY1FGhKUcJAfm747J8ALzpe28 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4760 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f4bfa58e-6d9d-4cb8-ee59-08d93a20f4fb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9/uJr+Ixst7XoFHAEEajrHSyas7JGZ4CB9S+Ciw6SzUxno+jNd9sXfMg2LEA963O6tOz8RbfbhBw9cEOMQjqy1NoXOyUR02WPv1ETfYhbPDrT6UZjd5+ajHWTsIKOZdV/sT4flcNmqTUuISCwzEa0Y9tSTzk0HRDBIbmk8WznH07JKxIFg6tD5Jtw/GULgF9nIXJfVMng/KNT8cXgc3UGZEF47EejI6S9Ha4Xco65jKTvxPRWEDPxX8krTsNSn/kfcTpi5XJzcF3lxnJF/LsDNvAth6HQ7vLBP2wnnoyx2M86SxJoCIMIy1UBTBZNS58oRllcT6Myk6K3leskKUO5aSLmEMp5IyjqlTdvu1morNTwYH27EOoa8eq2iJREqhYneGb8x2qvXn2uDGUAXe8awD5vDv9PkWMzFFFSHocIEXsExLM4YQguxzHA20UP99W2KgRF9vRTQUe7zZNF9okIJFZqQQMaNG2Y6sRUxBWzsPIdiOFbDLu6QF07WyzGO2PpFSs1UzOLLpJgGDvNbgmWtQOp0k+XcSf8FxfbMtDOXNkdDjE+ZAKK05PY0OrSjgPEURzJr5js8u0BBOuL0j/MMt9i969KV+QqkpHi2sxLSpaMpkZFtywPjqBusZFM4PJvovDYRnMM2QvzY+T30XrHvP8CLh9D376/GgGkPQ41idpS7OaDhi/2iz9UzSNv28Qzghz4qcaxrZZvFehAnH9PzykQMVVajWv++4Oc9AOjJJowBdHGLP3xk/28naUNnVL X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(396003)(346002)(136003)(36840700001)(46966006)(8676002)(81166007)(82740400003)(8936002)(36860700001)(356005)(82310400003)(86362001)(6512007)(6916009)(47076005)(4744005)(2906002)(5660300002)(2616005)(186003)(956004)(16526019)(336012)(6666004)(70586007)(70206006)(1076003)(26005)(6486002)(478600001)(316002)(36756003)(6506007)(44832011)(69590400013); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 10:39:21.9209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42922207-679d-4be9-ab44-08d93a20fdb1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5418 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Szabolcs Nagy via Libc-alpha From: Szabolcs Nagy Reply-To: Szabolcs Nagy Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The arm PCS requires 8 byte aligned stack at function entry. Previously unaligned stack could crash the clone child. Fixes bug 28020. --- sysdeps/unix/sysv/linux/arm/clone.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/unix/sysv/linux/arm/clone.S b/sysdeps/unix/sysv/linux/arm/clone.S index 44eefee3fc..05596cb7a5 100644 --- a/sysdeps/unix/sysv/linux/arm/clone.S +++ b/sysdeps/unix/sysv/linux/arm/clone.S @@ -31,6 +31,8 @@ ENTRY(__clone) @ sanity check args cmp r0, #0 + @ align sp + and r1, r1, #-8 ite ne cmpne r1, #0 moveq r0, #-EINVAL