Move tst-resolv-res_init-multi to xtests
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
Tests that need network access may cause false failures due to network
glitches because of which they are typically added as xtests. See for
example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi
also to xtests so that it is not executed in a regular test run.
---
resolv/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
Hi, any objections to this move?
Siddhesh
On 6/22/21 10:14 AM, Siddhesh Poyarekar via Libc-alpha wrote:
> Tests that need network access may cause false failures due to network
> glitches because of which they are typically added as xtests. See for
> example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi
> also to xtests so that it is not executed in a regular test run.
> ---
> resolv/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/resolv/Makefile b/resolv/Makefile
> index 3fbc320ee1..3e17fda571 100644
> --- a/resolv/Makefile
> +++ b/resolv/Makefile
> @@ -57,7 +57,6 @@ tests += \
> tst-resolv-edns \
> tst-resolv-network \
> tst-resolv-nondecimal \
> - tst-resolv-res_init-multi \
> tst-resolv-search \
> tst-resolv-trailing \
>
> @@ -103,6 +102,9 @@ xtests += tst-resolv-qtypes
>
> # This test has dropped packet tests and runs for a long time.
> xtests += tst-resolv-rotate
> +
> +# This test needs a functioning network to succeed.
> +xtests += tst-resolv-res_init-multi
> endif
> extra-libs-others = $(extra-libs)
> libresolv-routines := res_comp res_debug \
>
* Siddhesh Poyarekar via Libc-alpha:
> Tests that need network access may cause false failures due to network
> glitches because of which they are typically added as xtests. See for
> example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi
> also to xtests so that it is not executed in a regular test run.
The comment in the test says that it does not matter whether the lookup
succeeds. If this test fails, this could point to a real problem.
Thanks,
Florian
On 6/28/21 10:08 AM, Florian Weimer via Libc-alpha wrote:
> * Siddhesh Poyarekar via Libc-alpha:
>
>> Tests that need network access may cause false failures due to network
>> glitches because of which they are typically added as xtests. See for
>> example posix/tst-getaddrinfo{4,5}.c. Move tst-resolv-res_init-multi
>> also to xtests so that it is not executed in a regular test run.
>
> The comment in the test says that it does not matter whether the lookup
> succeeds. If this test fails, this could point to a real problem.
Ahh, I should have recorded what the failure was; I don't remember it
anymore. It turned up when my network went down in the middle of a
`make check` run.
Siddhesh
@@ -57,7 +57,6 @@ tests += \
tst-resolv-edns \
tst-resolv-network \
tst-resolv-nondecimal \
- tst-resolv-res_init-multi \
tst-resolv-search \
tst-resolv-trailing \
@@ -103,6 +102,9 @@ xtests += tst-resolv-qtypes
# This test has dropped packet tests and runs for a long time.
xtests += tst-resolv-rotate
+
+# This test needs a functioning network to succeed.
+xtests += tst-resolv-res_init-multi
endif
extra-libs-others = $(extra-libs)
libresolv-routines := res_comp res_debug \