From patchwork Thu Jun 17 11:50:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 43867 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CEF9F3894C1E for ; Thu, 17 Jun 2021 11:57:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CEF9F3894C1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623931044; bh=cw/wTvswUiMDXMrHMAZOh54EkS0QmC1YTIBIm0SpATI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=U38TgZgymcCYXmX1mDdmWyesw75ZeTTaJOLLZtnGvGZypSZxDBwkXnWHj6V7rlKGe HObuXkOfD6zHREQuCH2AEe+7YpKAzY2x88ohl3FOPYtBTtXJva5QIn/PgpFhayL75o vsvgQ5a6OgH3VNOCPL1QzFos/15v2liwrb6WJHw0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id D84173854803 for ; Thu, 17 Jun 2021 11:51:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D84173854803 Received: by mail-qk1-x730.google.com with SMTP id c138so2777543qkg.5 for ; Thu, 17 Jun 2021 04:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cw/wTvswUiMDXMrHMAZOh54EkS0QmC1YTIBIm0SpATI=; b=paUHZAASfvLe/pYx21V7wsdpe7w3lOQchH0PVQh0W1IbFKCy06F4ypA9Ve4SCuIGRV 86j9P9LyvqT0HgvoozuzrypRQR7Kbf7ZckBdA/UK7UDYZqyjgLtxT5RaDmOFNFOk1ch4 qYVNIA+Gxdd91+JWnmxl1mUUgR/G1TVoQIwenOXnGzbu8YW+pzHUAYrc66I/w51l0QPu R+sL+p3hNwfkZXE6bYLGX4sRKGHbdCJJL8+TEuzaVxLXvpxtLFJD+bKRXmiINSPRrqNg eFJHD8B1NrW8g+tzjoMBgJvhHM1cMlTNk9MKxc8kBuJ9PYTf2AzxXSSLwv7uxDJe2nQ0 WYxg== X-Gm-Message-State: AOAM530afWP851/Bq+ED5HE9DEHSkOHPWysMUHGEn+m/fZIE9yHy6dDN vCIycl+CEH1jK+6CAYpAEP9MoftSPG5ROQ== X-Google-Smtp-Source: ABdhPJz+9u2cUQENw+/+jSpTqTh/8JPMqMGy5B5sgEUJA7tQQ8l5aC1dJTaTeb5MNOa7LBk+kBNIhA== X-Received: by 2002:ae9:eb82:: with SMTP id b124mr3265319qkg.51.1623930681359; Thu, 17 Jun 2021 04:51:21 -0700 (PDT) Received: from birita.. ([177.194.59.218]) by smtp.googlemail.com with ESMTPSA id p12sm3016435qtw.61.2021.06.17.04.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 04:51:21 -0700 (PDT) To: libc-alpha@sourceware.org, Lukasz Majewski , Carlos O'Donell Subject: [PATCH 07/18] linux: Remove supports_time64 () from clock_getres Date: Thu, 17 Jun 2021 08:50:53 -0300 Message-Id: <20210617115104.1359598-8-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210617115104.1359598-1-adhemerval.zanella@linaro.org> References: <20210617115104.1359598-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" It breaks the usage case of live migration like CRIU or similar. The performance drawback is it would require an extra syscall on older kernels without 64-bit time support. Checked on i686-linux-gnu on a 4.15 kernel and on a 5.11 kernel (with and without --enable-kernel=5.1) and on x86_64-linux-gnu. Reviewed-by: Lukasz Majewski --- sysdeps/unix/sysv/linux/clock_getres.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sysdeps/unix/sysv/linux/clock_getres.c b/sysdeps/unix/sysv/linux/clock_getres.c index a9edec93e6..83f0593074 100644 --- a/sysdeps/unix/sysv/linux/clock_getres.c +++ b/sysdeps/unix/sysv/linux/clock_getres.c @@ -21,7 +21,6 @@ #include #include -#include #include #include @@ -34,19 +33,14 @@ __clock_getres64 (clockid_t clock_id, struct __timespec64 *res) #ifndef __NR_clock_getres_time64 # define __NR_clock_getres_time64 __NR_clock_getres #endif - if (supports_time64 ()) - { + #ifdef HAVE_CLOCK_GETRES64_VSYSCALL - r = INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); + r = INLINE_VSYSCALL (clock_getres_time64, 2, clock_id, res); #else - r = INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); + r = INLINE_SYSCALL_CALL (clock_getres_time64, clock_id, res); #endif - - if (r == 0 || errno != ENOSYS) - return r; - - mark_time64_unsupported (); - } + if (r == 0 || errno != ENOSYS) + return r; #ifndef __ASSUME_TIME64_SYSCALLS /* Fallback code that uses 32-bit support. */