From patchwork Thu Jun 10 13:32:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siddhesh Poyarekar X-Patchwork-Id: 43822 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9B40384840F for ; Thu, 10 Jun 2021 13:32:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9B40384840F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623331964; bh=pSvgVd3fzvyQgzGPQF6iAHCgBBqLBz8+XWHSmcuq3NY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=yz5A2vtIFcRrzXyvAaC4AYaHNghKbXGnB9b32dzEUjAsu7EnYdobz1RHx9+z09A1q L+bYF39b1MJDDSlOaeX/zrb3c4fEmJpqWVL/Bo69dc4svtAyyBX5CMcEjF/gEz1MiE n3bl4c7qZmjJ7O3rqUBJ55fDy7hAv1M0Uh13AS8Y= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from dog.elm.relay.mailchannels.net (dog.elm.relay.mailchannels.net [23.83.212.48]) by sourceware.org (Postfix) with ESMTPS id 4CACB3858034 for ; Thu, 10 Jun 2021 13:32:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CACB3858034 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 608F9222C7; Thu, 10 Jun 2021 13:32:19 +0000 (UTC) Received: from pdx1-sub0-mail-a37.g.dreamhost.com (100-96-133-111.trex.outbound.svc.cluster.local [100.96.133.111]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 438AE220C0; Thu, 10 Jun 2021 13:32:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a37.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.133.111 (trex/6.3.1); Thu, 10 Jun 2021 13:32:19 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Lettuce-Whimsical: 762daa9c4625373d_1623331939179_3314301021 X-MC-Loop-Signature: 1623331939179:3557897779 X-MC-Ingress-Time: 1623331939179 Received: from pdx1-sub0-mail-a37.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTP id E6E2786197; Thu, 10 Jun 2021 06:32:15 -0700 (PDT) Received: from rhbox.intra.reserved-bit.com (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a37.g.dreamhost.com (Postfix) with ESMTPSA id A1AE686EE9; Thu, 10 Jun 2021 06:32:13 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a37 To: libc-alpha@sourceware.org Subject: [PATCH] Reinstate gconv-modules as the default configuration file Date: Thu, 10 Jun 2021 19:02:01 +0530 Message-Id: <20210610133201.2394221-1-siddhesh@sourceware.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3494.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Siddhesh Poyarekar via Libc-alpha From: Siddhesh Poyarekar Reply-To: Siddhesh Poyarekar Cc: schwab@linux-m68k.org Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Reinstate gconv-modules as the main file so that the configuration files in gconv-modules.d/ become add-on configuration. With this, the effective user visible change is that GCONV_PATH can now have supplementary configuration in GCONV_PATH/gconv-modules.d/ in addition to the main GCONV_PATH/gconv-modules file. --- iconvdata/Makefile | 40 ++++++++++--------- .../{gconv-modules.conf => gconv-modules} | 0 2 files changed, 21 insertions(+), 19 deletions(-) rename iconvdata/{gconv-modules.conf => gconv-modules} (100%) diff --git a/iconvdata/Makefile b/iconvdata/Makefile index 3c6929fb59..bb3f621b49 100644 --- a/iconvdata/Makefile +++ b/iconvdata/Makefile @@ -137,13 +137,12 @@ charmaps = ../localedata/charmaps extra-modules-left := $(modules) include extra-module.mk -gconv-modules = gconv-modules.conf gconv-modules-extra.conf +gconv-modules = gconv-modules gconv-modules.d/gconv-modules-extra.conf modpfx = $(objpfx)gconv-modules.d/ extra-objs += $(modules.so) install-others = $(addprefix $(inst_gconvdir)/, $(modules.so)) \ - $(addprefix $(inst_gconvdir)/gconv-modules.d/, \ - $(gconv-modules)) + $(addprefix $(inst_gconvdir)/, $(gconv-modules)) # We can build the conversion tables for numerous charsets automatically. @@ -185,7 +184,7 @@ generated += $(generated-modules:=.h) $(generated-modules:=.stmp) \ iconv-test.out iconv-rules tst-loading.mtrace \ mtrace-tst-loading.out tst-tables.out iconv-test.xxx ifdef objpfx -generated += $(addprefix gconv-modules.d/,$(gconv-modules)) +generated += $(gconv-modules) endif # Rules to generate the headers. @@ -253,8 +252,8 @@ headers: $(addprefix $(objpfx), $(generated-modules:=.h)) $(addprefix $(inst_gconvdir)/, $(modules.so)): \ $(inst_gconvdir)/%: $(objpfx)% $(+force) $(do-install-program) -$(addprefix $(inst_gconvdir)/gconv-modules.d/, $(gconv-modules)): \ - $(inst_gconvdir)/gconv-modules.d/%: $(modpfx)% $(+force) +$(addprefix $(inst_gconvdir)/, $(gconv-modules)): \ + $(inst_gconvdir)/%: $(objpfx)% $(+force) $(do-install) ifeq (no,$(cross-compiling)) # Update the $(prefix)/lib/gconv/gconv-modules.cache file. This is necessary @@ -307,29 +306,29 @@ $(objpfx)mtrace-tst-loading.out: $(objpfx)tst-loading.out $(common-objpfx)malloc/mtrace $(objpfx)tst-loading.mtrace > $@; \ $(evaluate-test) -$(objpfx)bug-iconv1.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv1.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv2.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv2.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv3.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv3.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv5.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv5.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)tst-loading.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)tst-loading.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)tst-iconv4.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)tst-iconv4.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)tst-iconv7.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)tst-iconv7.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv10.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv10.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv12.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv12.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) -$(objpfx)bug-iconv14.out: $(addprefix $(modpfx), $(gconv-modules)) \ +$(objpfx)bug-iconv14.out: $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) $(objpfx)iconv-test.out: run-iconv-test.sh \ - $(addprefix $(modpfx), $(gconv-modules)) \ + $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) \ $(common-objdir)/iconv/iconv_prog TESTS iconv_modules="$(modules)" \ @@ -338,7 +337,7 @@ $(objpfx)iconv-test.out: run-iconv-test.sh \ $(evaluate-test) $(objpfx)tst-tables.out: tst-tables.sh \ - $(addprefix $(modpfx), $(gconv-modules)) \ + $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) \ $(objpfx)tst-table-from $(objpfx)tst-table-to $(SHELL) $< $(common-objpfx) $(common-objpfx)iconvdata/ \ @@ -357,7 +356,10 @@ $(modpfx): $(modpfx)%: % $(modpfx) cp $< $@ +$(objpfx)gconv-modules: gconv-modules + cp $^ $@ + # Test requires BIG5HKSCS. $(objpfx)tst-iconv-big5-hkscs-to-2ucs4.out: \ - $(addprefix $(modpfx), $(gconv-modules)) \ + $(addprefix $(objpfx), $(gconv-modules)) \ $(addprefix $(objpfx),$(modules.so)) diff --git a/iconvdata/gconv-modules.conf b/iconvdata/gconv-modules similarity index 100% rename from iconvdata/gconv-modules.conf rename to iconvdata/gconv-modules