Message ID | 20210609111951.886083-1-stli@linux.ibm.com |
---|---|
State | Committed |
Commit | 51a3df5e358f3229b9f4e9ad1721fee591d4d29e |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5A6E839730F8 for <patchwork@sourceware.org>; Wed, 9 Jun 2021 11:22:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5A6E839730F8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623237740; bh=wg+XtM7UIs0qRRu00aLBeRIxIDJ3M+3iMNNkzm6cbvc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=o8RRFu9rkp7+cTNkGQowaaLghsvrdpOfNDLE7ryyOCCoPBEfn5wAotA+v/udc2hME HZnKTW9Tn1oyLJjoIVLFm7n7kK2xiXWEnrAMN0olIpISI0kLxRws7p7vDIFgkJMBXr 3VClBuDaKcGtM032/KmCVO4+sVZ6movBWQkwka8M= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3426439730EE for <libc-alpha@sourceware.org>; Wed, 9 Jun 2021 11:20:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3426439730EE Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 159B3ICj068883 for <libc-alpha@sourceware.org>; Wed, 9 Jun 2021 07:20:03 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 392us1skdp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <libc-alpha@sourceware.org>; Wed, 09 Jun 2021 07:20:03 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 159B3f9d070083 for <libc-alpha@sourceware.org>; Wed, 9 Jun 2021 07:20:02 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 392us1skcs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Jun 2021 07:20:02 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 159B8nlG009327; Wed, 9 Jun 2021 11:20:00 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma01fra.de.ibm.com with ESMTP id 3900w89607-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Jun 2021 11:20:00 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 159BJv9T35062088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jun 2021 11:19:57 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63F5DAE057; Wed, 9 Jun 2021 11:19:57 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3185CAE051; Wed, 9 Jun 2021 11:19:57 +0000 (GMT) Received: from t35lp56.lnxne.boe (unknown [9.152.108.100]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 9 Jun 2021 11:19:57 +0000 (GMT) To: libc-alpha@sourceware.org Subject: [PATCH] Fix elf/tst-tls9-static after libdl cleanups. Date: Wed, 9 Jun 2021 13:19:51 +0200 Message-Id: <20210609111951.886083-1-stli@linux.ibm.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: c8Qf-SaoBtTLCePtqdalCEc-GRMj6sVs X-Proofpoint-ORIG-GUID: 0DB46nVzq2_4FxBRyKRHMZhp6OqIP2w7 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-09_04:2021-06-04, 2021-06-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxlogscore=787 bulkscore=0 mlxscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106090054 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Stefan Liebler via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Stefan Liebler <stli@linux.ibm.com> Cc: fweimer@redhat.com, Stefan Liebler <stli@linux.ibm.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Fix elf/tst-tls9-static after libdl cleanups.
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Stefan Liebler
June 9, 2021, 11:19 a.m. UTC
The testcase elf/tst-tls9-static sometimes fails with: cannot open 'tst-tlsmod5.so': tst-tlsmod5.so: cannot open shared object file: No such file or directory cannot open 'tst-tlsmod6.so': tst-tlsmod6.so: cannot open shared object file: No such file or directory After recent commit 6f1c701026287f6928d3bdd1aea7359308635abe "dlfcn: Cleanups after -ldl is no longer required" the libdl variable is not set anymore and thus the dependencies were missing. --- elf/Makefile | 2 -- 1 file changed, 2 deletions(-)
Comments
* Stefan Liebler: > The testcase elf/tst-tls9-static sometimes fails with: > cannot open 'tst-tlsmod5.so': tst-tlsmod5.so: cannot open shared object file: No such file or directory > cannot open 'tst-tlsmod6.so': tst-tlsmod6.so: cannot open shared object file: No such file or directory > > After recent commit > 6f1c701026287f6928d3bdd1aea7359308635abe > "dlfcn: Cleanups after -ldl is no longer required" > the libdl variable is not set anymore and thus the > dependencies were missing. > --- > elf/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/elf/Makefile b/elf/Makefile > index e9788d3d4f..6dbb03bbb2 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -1050,10 +1050,8 @@ unload7-ENV = MALLOC_PERTURB_=85 > > $(objpfx)unload8.out: $(objpfx)unload8mod1.so $(objpfx)unload8mod1x.so > > -ifdef libdl > $(objpfx)tst-tls9-static: $(common-objpfx)dlfcn/libdl.a > $(objpfx)tst-tls9-static.out: $(objpfx)tst-tlsmod5.so $(objpfx)tst-tlsmod6.so > -endif Sorry about that. Patch looks fine. That libdl.a reference is stale; I'll see if I can post a patch to remove all them in one go. Thanks, Florian
On 09/06/2021 13:24, Florian Weimer wrote: > * Stefan Liebler: > >> The testcase elf/tst-tls9-static sometimes fails with: >> cannot open 'tst-tlsmod5.so': tst-tlsmod5.so: cannot open shared object file: No such file or directory >> cannot open 'tst-tlsmod6.so': tst-tlsmod6.so: cannot open shared object file: No such file or directory >> >> After recent commit >> 6f1c701026287f6928d3bdd1aea7359308635abe >> "dlfcn: Cleanups after -ldl is no longer required" >> the libdl variable is not set anymore and thus the >> dependencies were missing. >> --- >> elf/Makefile | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/elf/Makefile b/elf/Makefile >> index e9788d3d4f..6dbb03bbb2 100644 >> --- a/elf/Makefile >> +++ b/elf/Makefile >> @@ -1050,10 +1050,8 @@ unload7-ENV = MALLOC_PERTURB_=85 >> >> $(objpfx)unload8.out: $(objpfx)unload8mod1.so $(objpfx)unload8mod1x.so >> >> -ifdef libdl >> $(objpfx)tst-tls9-static: $(common-objpfx)dlfcn/libdl.a >> $(objpfx)tst-tls9-static.out: $(objpfx)tst-tlsmod5.so $(objpfx)tst-tlsmod6.so >> -endif > > Sorry about that. Patch looks fine. > > That libdl.a reference is stale; I'll see if I can post a patch to > remove all them in one go. > > Thanks, > Florian > Okay. I've just pushed the patch. Please remove all those libdl.a references in one go. Thanks, Stefan
diff --git a/elf/Makefile b/elf/Makefile index e9788d3d4f..6dbb03bbb2 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1050,10 +1050,8 @@ unload7-ENV = MALLOC_PERTURB_=85 $(objpfx)unload8.out: $(objpfx)unload8mod1.so $(objpfx)unload8mod1x.so -ifdef libdl $(objpfx)tst-tls9-static: $(common-objpfx)dlfcn/libdl.a $(objpfx)tst-tls9-static.out: $(objpfx)tst-tlsmod5.so $(objpfx)tst-tlsmod6.so -endif ifeq ($(have-z-execstack),yes) $(objpfx)tst-execstack.out: $(objpfx)tst-execstack-mod.so